[Qemu-devel] Re: [PATCH v2] tracetool: Add optional argument to specify dtrace probe names

[Jes Sorensen <Jes.Sorensen@redhat.com>]

On 02/17/11 13:29, Paolo Bonzini wrote:
> On 02/17/2011 01:19 PM, Jes Sorensen wrote:
>> On 02/17/11 13:16, Paolo Bonzini wrote:
>>> On 02/15/2011 01:34 PM, Jes.Sorensen@redhat.com wrote:
>>>> -    if [ -z "$binary" ]; then
>>>> +    if [ -z "$probeprefix" -a -z "$binary" ]; then
>>>>           echo "--binary is required for SystemTAP tapset generator"
>>>>           exit 1
>>>>        fi
>>>
>>> --binary is always required, even with --probe-prefix, since it is
>>> used for
>>>
>>> +probe $probeprefix.$name = process("$binary").mark("$name")
>>
>> if I broke something with this
> 
> No, you didn't break anything.  It's just that someone patching the
> Makefile like you did in 2/2 might.
> 
> Paolo

Sorry for the confusion everybody, I thought I was replying to an
internal email - where I mangled a Makefile.

Please ignore the noise and consider v3 of the patch.

Thanks,
Jes