* [U-Boot] [PATCH v2] arm: get_sp() should always be compiled [not found] <20110216081330.9BE1B1519FE@gemini.denx.de> @ 2011-02-16 8:54 ` Po-Yu Chuang 2011-02-17 12:44 ` Albert ARIBAUD 2011-02-17 17:26 ` Albert ARIBAUD 0 siblings, 2 replies; 7+ messages in thread From: Po-Yu Chuang @ 2011-02-16 8:54 UTC (permalink / raw) To: u-boot From: Po-Yu Chuang <ratbert@faraday-tech.com> get_sp() was incorrectly excluded if none of CONFIG_SETUP_MEMORY_TAGS CONFIG_CMDLINE_TAG CONFIG_INITRD_TAG CONFIG_SERIAL_TAG CONFIG_REVISION_TAG were defined. Signed-off-by: Po-Yu Chuang <ratbert@faraday-tech.com> --- v2: rebase arch/arm/lib/bootm.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/arch/arm/lib/bootm.c b/arch/arm/lib/bootm.c index a1649ee..7734953 100644 --- a/arch/arm/lib/bootm.c +++ b/arch/arm/lib/bootm.c @@ -327,12 +327,12 @@ void setup_revision_tag(struct tag **in_params) } #endif /* CONFIG_REVISION_TAG */ - static void setup_end_tag (bd_t *bd) { params->hdr.tag = ATAG_NONE; params->hdr.size = 0; } +#endif /* CONFIG_SETUP_MEMORY_TAGS || CONFIG_CMDLINE_TAG || CONFIG_INITRD_TAG */ static ulong get_sp(void) { @@ -341,5 +341,3 @@ static ulong get_sp(void) asm("mov %0, sp" : "=r"(ret) : ); return ret; } - -#endif /* CONFIG_SETUP_MEMORY_TAGS || CONFIG_CMDLINE_TAG || CONFIG_INITRD_TAG */ -- 1.6.3.3 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH v2] arm: get_sp() should always be compiled 2011-02-16 8:54 ` [U-Boot] [PATCH v2] arm: get_sp() should always be compiled Po-Yu Chuang @ 2011-02-17 12:44 ` Albert ARIBAUD 2011-02-17 12:54 ` Macpaul Lin 2011-02-17 17:26 ` Albert ARIBAUD 1 sibling, 1 reply; 7+ messages in thread From: Albert ARIBAUD @ 2011-02-17 12:44 UTC (permalink / raw) To: u-boot Hi, Le 16/02/2011 09:54, Po-Yu Chuang a ?crit : > From: Po-Yu Chuang<ratbert@faraday-tech.com> > > get_sp() was incorrectly excluded if none of > CONFIG_SETUP_MEMORY_TAGS > CONFIG_CMDLINE_TAG > CONFIG_INITRD_TAG > CONFIG_SERIAL_TAG > CONFIG_REVISION_TAG > were defined. Which board exactly requires this patch? Amicalement, -- Albert. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH v2] arm: get_sp() should always be compiled 2011-02-17 12:44 ` Albert ARIBAUD @ 2011-02-17 12:54 ` Macpaul Lin 2011-02-17 17:23 ` Albert ARIBAUD 0 siblings, 1 reply; 7+ messages in thread From: Macpaul Lin @ 2011-02-17 12:54 UTC (permalink / raw) To: u-boot Hi, 2011/2/17 Albert ARIBAUD <albert.aribaud@free.fr>: > Hi, > > Le 16/02/2011 09:54, Po-Yu Chuang a ?crit : >> From: Po-Yu Chuang<ratbert@faraday-tech.com> >> >> get_sp() was incorrectly excluded if none of >> ? ?CONFIG_SETUP_MEMORY_TAGS >> ? ?CONFIG_CMDLINE_TAG >> ? ?CONFIG_INITRD_TAG >> ? ?CONFIG_SERIAL_TAG >> ? ?CONFIG_REVISION_TAG >> were defined. > > > Which board exactly requires this patch? > I think it is a320evb. -- Best regards, Macpaul Lin ^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH v2] arm: get_sp() should always be compiled 2011-02-17 12:54 ` Macpaul Lin @ 2011-02-17 17:23 ` Albert ARIBAUD 2011-02-18 5:42 ` Po-Yu Chuang 0 siblings, 1 reply; 7+ messages in thread From: Albert ARIBAUD @ 2011-02-17 17:23 UTC (permalink / raw) To: u-boot Le 17/02/2011 13:54, Macpaul Lin a ?crit : > Hi, > > 2011/2/17 Albert ARIBAUD<albert.aribaud@free.fr>: >> Hi, >> >> Le 16/02/2011 09:54, Po-Yu Chuang a ?crit : >>> From: Po-Yu Chuang<ratbert@faraday-tech.com> >>> >>> get_sp() was incorrectly excluded if none of >>> CONFIG_SETUP_MEMORY_TAGS >>> CONFIG_CMDLINE_TAG >>> CONFIG_INITRD_TAG >>> CONFIG_SERIAL_TAG >>> CONFIG_REVISION_TAG >>> were defined. >> >> >> Which board exactly requires this patch? >> > > I think it is a320evb. Ok. This patch indeed removes the 'get_sp' error on this board's build, but as an FYI, it does not build anyway. Amicalement, -- Albert. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH v2] arm: get_sp() should always be compiled 2011-02-17 17:23 ` Albert ARIBAUD @ 2011-02-18 5:42 ` Po-Yu Chuang 2011-02-18 6:17 ` Albert ARIBAUD 0 siblings, 1 reply; 7+ messages in thread From: Po-Yu Chuang @ 2011-02-18 5:42 UTC (permalink / raw) To: u-boot Hi Albert, On Fri, Feb 18, 2011 at 1:23 AM, Albert ARIBAUD <albert.aribaud@free.fr> wrote: > Le 17/02/2011 13:54, Macpaul Lin a ?crit : >> 2011/2/17 Albert ARIBAUD<albert.aribaud@free.fr>: >>> Le 16/02/2011 09:54, Po-Yu Chuang a ?crit : >>>> From: Po-Yu Chuang<ratbert@faraday-tech.com> >>>> >>>> get_sp() was incorrectly excluded if none of >>>> ? ?CONFIG_SETUP_MEMORY_TAGS >>>> ? ?CONFIG_CMDLINE_TAG >>>> ? ?CONFIG_INITRD_TAG >>>> ? ?CONFIG_SERIAL_TAG >>>> ? ?CONFIG_REVISION_TAG >>>> were defined. >>> >>> Which board exactly requires this patch? >> >> I think it is a320evb. > > Ok. This patch indeed removes the 'get_sp' error on this board's build, but > as an FYI, it does not build anyway. The following patches fix all the build errors of a320evb: (Although it still won't work, its timer still need some fix.) [PATCH v2 1/2] power: ftpmu010: move drivers/power/ftpmu010.h to include/faraday [PATCH v2 2/2] arm: a320: use new ftpmu010 API best regards, Po-Yu Chuang ^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH v2] arm: get_sp() should always be compiled 2011-02-18 5:42 ` Po-Yu Chuang @ 2011-02-18 6:17 ` Albert ARIBAUD 0 siblings, 0 replies; 7+ messages in thread From: Albert ARIBAUD @ 2011-02-18 6:17 UTC (permalink / raw) To: u-boot Le 18/02/2011 06:42, Po-Yu Chuang a ?crit : > Hi Albert, > > On Fri, Feb 18, 2011 at 1:23 AM, Albert ARIBAUD<albert.aribaud@free.fr> wrote: >> Le 17/02/2011 13:54, Macpaul Lin a ?crit : >>> 2011/2/17 Albert ARIBAUD<albert.aribaud@free.fr>: >>>> Le 16/02/2011 09:54, Po-Yu Chuang a ?crit : >>>>> From: Po-Yu Chuang<ratbert@faraday-tech.com> >>>>> >>>>> get_sp() was incorrectly excluded if none of >>>>> CONFIG_SETUP_MEMORY_TAGS >>>>> CONFIG_CMDLINE_TAG >>>>> CONFIG_INITRD_TAG >>>>> CONFIG_SERIAL_TAG >>>>> CONFIG_REVISION_TAG >>>>> were defined. >>>> >>>> Which board exactly requires this patch? >>> >>> I think it is a320evb. >> >> Ok. This patch indeed removes the 'get_sp' error on this board's build, but >> as an FYI, it does not build anyway. > > The following patches fix all the build errors of a320evb: > (Although it still won't work, its timer still need some fix.) > > [PATCH v2 1/2] power: ftpmu010: move drivers/power/ftpmu010.h to include/faraday > [PATCH v2 2/2] arm: a320: use new ftpmu010 API Thanks. If these receive review soon, I'll include them in my next pull along with the ARM machine type update. > best regards, > Po-Yu Chuang Amicalement, -- Albert. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH v2] arm: get_sp() should always be compiled 2011-02-16 8:54 ` [U-Boot] [PATCH v2] arm: get_sp() should always be compiled Po-Yu Chuang 2011-02-17 12:44 ` Albert ARIBAUD @ 2011-02-17 17:26 ` Albert ARIBAUD 1 sibling, 0 replies; 7+ messages in thread From: Albert ARIBAUD @ 2011-02-17 17:26 UTC (permalink / raw) To: u-boot Hi Po-Yu Chang, Le 16/02/2011 09:54, Po-Yu Chuang a ?crit : > From: Po-Yu Chuang<ratbert@faraday-tech.com> > > get_sp() was incorrectly excluded if none of > CONFIG_SETUP_MEMORY_TAGS > CONFIG_CMDLINE_TAG > CONFIG_INITRD_TAG > CONFIG_SERIAL_TAG > CONFIG_REVISION_TAG > were defined. > > Signed-off-by: Po-Yu Chuang<ratbert@faraday-tech.com> > --- > v2: > rebase Applied, to u-boot-arm/master as it is actually an old patch submission and a bugfix. Amicalement, -- Albert. ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-02-18 6:17 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20110216081330.9BE1B1519FE@gemini.denx.de>
2011-02-16 8:54 ` [U-Boot] [PATCH v2] arm: get_sp() should always be compiled Po-Yu Chuang
2011-02-17 12:44 ` Albert ARIBAUD
2011-02-17 12:54 ` Macpaul Lin
2011-02-17 17:23 ` Albert ARIBAUD
2011-02-18 5:42 ` Po-Yu Chuang
2011-02-18 6:17 ` Albert ARIBAUD
2011-02-17 17:26 ` Albert ARIBAUD
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.