From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 3/4] ARM: Xilinx: base header files and assembly macros
Date: Thu, 17 Feb 2011 13:58:24 -0800 [thread overview]
Message-ID: <4D5D9A00.7060609@codeaurora.org> (raw)
In-Reply-To: <20110217100126.GD22961@pulham.picochip.com>
On 02/17/2011 02:01 AM, Jamie Iles wrote:
>> +
>> +static void putc(char ch)
>> +{
>> + /*
>> + * Wait for room in the FIFO, then write the char into the FIFO
>> + */
>> + while (UART_STATUS(LL_UART_PADDR) & UART_SR_TXFULL)
>> + ;
>
> It might be worth adding a barrier() call to these loops to be explicit
> about the volatility.
I think you want cpu_relax() then.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@codeaurora.org>
To: Jamie Iles <jamie@jamieiles.com>
Cc: John Linn <john.linn@xilinx.com>,
linux@arm.linux.org.uk, arnd@arndb.de, catalin.marinas@arm.com,
linux-kernel@vger.kernel.org, glikely@secretlab.ca,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V3 3/4] ARM: Xilinx: base header files and assembly macros
Date: Thu, 17 Feb 2011 13:58:24 -0800 [thread overview]
Message-ID: <4D5D9A00.7060609@codeaurora.org> (raw)
In-Reply-To: <20110217100126.GD22961@pulham.picochip.com>
On 02/17/2011 02:01 AM, Jamie Iles wrote:
>> +
>> +static void putc(char ch)
>> +{
>> + /*
>> + * Wait for room in the FIFO, then write the char into the FIFO
>> + */
>> + while (UART_STATUS(LL_UART_PADDR) & UART_SR_TXFULL)
>> + ;
>
> It might be worth adding a barrier() call to these loops to be explicit
> about the volatility.
I think you want cpu_relax() then.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-02-17 21:58 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1297872716-13353-1-git-send-email-john.linn@xilinx.com>
2011-02-16 16:11 ` [PATCH V3 1/4] ARM: Xilinx: Adding Xilinx board support John Linn
2011-02-16 16:11 ` John Linn
2011-02-17 9:34 ` Jamie Iles
2011-02-17 9:34 ` Jamie Iles
2011-02-17 14:24 ` John Linn
2011-02-17 14:24 ` John Linn
[not found] ` <1297872716-13353-2-git-send-email-john.linn@xilinx.com>
2011-02-16 16:11 ` [PATCH V3 2/4] ARM: Xilinx: Adding timer support to the platform John Linn
2011-02-16 16:11 ` John Linn
2011-02-17 9:48 ` Jamie Iles
2011-02-17 9:48 ` Jamie Iles
2011-02-17 14:27 ` John Linn
2011-02-17 14:27 ` John Linn
[not found] ` <1297872716-13353-3-git-send-email-john.linn@xilinx.com>
2011-02-16 16:11 ` [PATCH V3 3/4] ARM: Xilinx: base header files and assembly macros John Linn
2011-02-16 16:11 ` John Linn
2011-02-17 10:01 ` Jamie Iles
2011-02-17 10:01 ` Jamie Iles
2011-02-17 14:31 ` John Linn
2011-02-17 14:31 ` John Linn
2011-02-17 14:41 ` Arnd Bergmann
2011-02-17 14:41 ` Arnd Bergmann
2011-02-17 15:12 ` Russell King - ARM Linux
2011-02-17 15:12 ` Russell King - ARM Linux
2011-02-17 15:18 ` Arnd Bergmann
2011-02-17 15:18 ` Arnd Bergmann
2011-02-17 21:58 ` Stephen Boyd [this message]
2011-02-17 21:58 ` Stephen Boyd
2011-02-18 1:29 ` John Linn
2011-02-18 1:29 ` John Linn
2011-02-18 0:37 ` John Linn
2011-02-18 0:37 ` John Linn
2011-02-18 0:45 ` Jamie Iles
2011-02-18 0:45 ` Jamie Iles
2011-02-18 1:19 ` John Linn
2011-02-18 1:19 ` John Linn
2011-02-18 9:06 ` Jamie Iles
2011-02-18 9:06 ` Jamie Iles
2011-02-18 13:59 ` John Linn
2011-02-18 13:59 ` John Linn
2011-02-18 14:28 ` John Linn
2011-02-18 14:28 ` John Linn
[not found] ` <1297872716-13353-4-git-send-email-john.linn@xilinx.com>
2011-02-16 16:11 ` [PATCH V3 4/4] ARM: Xilinx: Adding Xilinx platform infrastructure support John Linn
2011-02-16 16:11 ` John Linn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5D9A00.7060609@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.