* [PATCH] u-boot-2009.03: Fix sector table direction for AMIC (hipox machine only)
@ 2011-02-16 13:26 Mario Schuknecht
2011-02-16 14:50 ` Steffen Sledz
2011-02-16 14:52 ` Paul Menzel
0 siblings, 2 replies; 13+ messages in thread
From: Mario Schuknecht @ 2011-02-16 13:26 UTC (permalink / raw)
To: openembedded-devel
Signed-off-by: Mario Schuknecht <m.schuknecht@dresearch.de>
---
.../u-boot-2009.03/hipox/11-cfi-amic-fixup.patch | 11 +++++++++++
recipes/u-boot/u-boot_2009.03.bb | 1 +
2 files changed, 12 insertions(+), 0 deletions(-)
create mode 100644 recipes/u-boot/u-boot-2009.03/hipox/11-cfi-amic-fixup.patch
diff --git a/recipes/u-boot/u-boot-2009.03/hipox/11-cfi-amic-fixup.patch b/recipes/u-boot/u-boot-2009.03/hipox/11-cfi-amic-fixup.patch
new file mode 100644
index 0000000..a7432a5
--- /dev/null
+++ b/recipes/u-boot/u-boot-2009.03/hipox/11-cfi-amic-fixup.patch
@@ -0,0 +1,11 @@
+diff -Nurd u-boot-2009.03.orig//drivers/mtd/cfi_flash.c u-boot-2009.03/drivers/mtd/cfi_flash.c
+--- u-boot-2009.03.orig//drivers/mtd/cfi_flash.c 2011-02-11 15:18:38.000000000 +0100
++++ u-boot-2009.03/drivers/mtd/cfi_flash.c 2011-02-11 15:19:06.000000000 +0100
+@@ -1883,6 +1883,7 @@
+ /* Do manufacturer-specific fixups */
+ switch (info->manufacturer_id) {
+ case 0x0001:
++ case 0x0037: // AMIC
+ case 0x00da: // Winbond
+ flash_fixup_amd(info, &qry);
+ break;
diff --git a/recipes/u-boot/u-boot_2009.03.bb b/recipes/u-boot/u-boot_2009.03.bb
index 2cbded9..d6e9768 100644
--- a/recipes/u-boot/u-boot_2009.03.bb
+++ b/recipes/u-boot/u-boot_2009.03.bb
@@ -14,6 +14,7 @@ SRC_URI_append_hipox = "file://00-hipox.patch \
file://03-hipox-direct-switch.patch \
file://04-hipox-env.patch \
file://10-hipox-boot-abort-key.patch \
+ file://11-cfi-amic-fixup.patch \
"
TARGET_LDFLAGS = ""
--
1.7.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] u-boot-2009.03: Fix sector table direction for AMIC (hipox machine only)
2011-02-16 13:26 [PATCH] u-boot-2009.03: Fix sector table direction for AMIC (hipox machine only) Mario Schuknecht
@ 2011-02-16 14:50 ` Steffen Sledz
2011-02-16 14:52 ` Paul Menzel
1 sibling, 0 replies; 13+ messages in thread
From: Steffen Sledz @ 2011-02-16 14:50 UTC (permalink / raw)
To: openembedded-devel
Am 16.02.2011 14:26, schrieb Mario Schuknecht:
> Signed-off-by: Mario Schuknecht <m.schuknecht@dresearch.de>
Acked-by: Steffen Sledz <sledz@dresearch.de>
--
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:sledz@DResearch.de
Fax: +49 30 515932-299
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] u-boot-2009.03: Fix sector table direction for AMIC (hipox machine only)
2011-02-16 13:26 [PATCH] u-boot-2009.03: Fix sector table direction for AMIC (hipox machine only) Mario Schuknecht
2011-02-16 14:50 ` Steffen Sledz
@ 2011-02-16 14:52 ` Paul Menzel
2011-02-16 15:16 ` Schuknecht, Mario
1 sibling, 1 reply; 13+ messages in thread
From: Paul Menzel @ 2011-02-16 14:52 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 1437 bytes --]
Dear Mario,
thank you for your patch.
Am Mittwoch, den 16.02.2011, 14:26 +0100 schrieb Mario Schuknecht:
Just curious. What were the symptoms of this problem?
> Signed-off-by: Mario Schuknecht <m.schuknecht@dresearch.de>
> ---
> .../u-boot-2009.03/hipox/11-cfi-amic-fixup.patch | 11 +++++++++++
> recipes/u-boot/u-boot_2009.03.bb | 1 +
> 2 files changed, 12 insertions(+), 0 deletions(-)
> create mode 100644 recipes/u-boot/u-boot-2009.03/hipox/11-cfi-amic-fixup.patch
>
> diff --git a/recipes/u-boot/u-boot-2009.03/hipox/11-cfi-amic-fixup.patch b/recipes/u-boot/u-boot-2009.03/hipox/11-cfi-amic-fixup.patch
> new file mode 100644
> index 0000000..a7432a5
> --- /dev/null
> +++ b/recipes/u-boot/u-boot-2009.03/hipox/11-cfi-amic-fixup.patch
> @@ -0,0 +1,11 @@
> +diff -Nurd u-boot-2009.03.orig//drivers/mtd/cfi_flash.c u-boot-2009.03/drivers/mtd/cfi_flash.c
> +--- u-boot-2009.03.orig//drivers/mtd/cfi_flash.c 2011-02-11 15:18:38.000000000 +0100
> ++++ u-boot-2009.03/drivers/mtd/cfi_flash.c 2011-02-11 15:19:06.000000000 +0100
> +@@ -1883,6 +1883,7 @@
> + /* Do manufacturer-specific fixups */
> + switch (info->manufacturer_id) {
> + case 0x0001:
> ++ case 0x0037: // AMIC
> + case 0x00da: // Winbond
> + flash_fixup_amd(info, &qry);
> + break;
Has this fix been applied upstream yet? What uBoot versions are
affected?
[…]
Thanks,
Paul
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] u-boot-2009.03: Fix sector table direction for AMIC (hipox machine only)
2011-02-16 14:52 ` Paul Menzel
@ 2011-02-16 15:16 ` Schuknecht, Mario
2011-02-16 18:34 ` Wolfgang Denk
2011-02-18 14:12 ` [PATCH v2] u-boot-2009.03: use AMD fixups for AMIC too Steffen Sledz
0 siblings, 2 replies; 13+ messages in thread
From: Schuknecht, Mario @ 2011-02-16 15:16 UTC (permalink / raw)
To: openembedded-devel
Hello Paul,
>
> Dear Mario,
>
>
> thank you for your patch.
>
> Am Mittwoch, den 16.02.2011, 14:26 +0100 schrieb Mario Schuknecht:
>
> Just curious. What were the symptoms of this problem?
The symptom is that the uBoot command "saveenv" dont work.
>
> > Signed-off-by: Mario Schuknecht <m.schuknecht@dresearch.de>
> > ---
> > .../u-boot-2009.03/hipox/11-cfi-amic-fixup.patch | 11
> +++++++++++
> > recipes/u-boot/u-boot_2009.03.bb | 1 +
> > 2 files changed, 12 insertions(+), 0 deletions(-)
> > create mode 100644
> recipes/u-boot/u-boot-2009.03/hipox/11-cfi-amic-fixup.patch
> >
> > diff --git
> a/recipes/u-boot/u-boot-2009.03/hipox/11-cfi-amic-fixup.patch
> b/recipes/u-boot/u-boot-2009.03/hipox/11-cfi-amic-fixup.patch
> > new file mode 100644
> > index 0000000..a7432a5
> > --- /dev/null
> > +++ b/recipes/u-boot/u-boot-2009.03/hipox/11-cfi-amic-fixup.patch
> > @@ -0,0 +1,11 @@
> > +diff -Nurd u-boot-2009.03.orig//drivers/mtd/cfi_flash.c
> u-boot-2009.03/drivers/mtd/cfi_flash.c
> > +--- u-boot-2009.03.orig//drivers/mtd/cfi_flash.c
> 2011-02-11 15:18:38.000000000 +0100
> > ++++ u-boot-2009.03/drivers/mtd/cfi_flash.c 2011-02-11
> 15:19:06.000000000 +0100
> > +@@ -1883,6 +1883,7 @@
> > + /* Do manufacturer-specific fixups */
> > + switch (info->manufacturer_id) {
> > + case 0x0001:
> > ++ case 0x0037: // AMIC
> > + case 0x00da: // Winbond
> > + flash_fixup_amd(info, &qry);
> > + break;
>
> Has this fix been applied upstream yet? What uBoot versions are
> affected?
Yes, the fix has been applied
<http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/94465>.
In my opinion all uBoot versions are affected. There are special fixes
for AMD flashes. And the AMIC flash is an AMD clone.
Mario
>
> [...]
>
>
> Thanks,
>
> Paul
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] u-boot-2009.03: Fix sector table direction for AMIC (hipox machine only)
2011-02-16 15:16 ` Schuknecht, Mario
@ 2011-02-16 18:34 ` Wolfgang Denk
2011-02-16 20:19 ` Sledz, Steffen
2011-02-18 14:12 ` [PATCH v2] u-boot-2009.03: use AMD fixups for AMIC too Steffen Sledz
1 sibling, 1 reply; 13+ messages in thread
From: Wolfgang Denk @ 2011-02-16 18:34 UTC (permalink / raw)
To: openembedded-devel, Schuknecht, Mario
Dear "Schuknecht, Mario",
In message <DB561678F08F554EB0D9F21B70E268A5056575@exchange.intern.dresearch.de> you wrote:
>
> > Has this fix been applied upstream yet? What uBoot versions are
> > affected?
>
> Yes, the fix has been applied
> <http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/94465>.
No, it has NOT been applied in mainline yet.
See http://patchwork.ozlabs.org/patch/82763/ - status is still NEW.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
"Once they go up, who cares where they come down? That's not my
department." - Werner von Braun
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] u-boot-2009.03: Fix sector table direction for AMIC (hipox machine only)
2011-02-16 18:34 ` Wolfgang Denk
@ 2011-02-16 20:19 ` Sledz, Steffen
2011-02-16 21:10 ` Wolfgang Denk
0 siblings, 1 reply; 13+ messages in thread
From: Sledz, Steffen @ 2011-02-16 20:19 UTC (permalink / raw)
To: openembedded-devel; +Cc: Schuknecht, Mario
Am 16.02.2011 19:34, schrieb Wolfgang Denk:
> Dear "Schuknecht, Mario",
>
> In message <DB561678F08F554EB0D9F21B70E268A5056575@exchange.intern.dresearch.de> you wrote:
>>
>>> Has this fix been applied upstream yet? What uBoot versions are
>>> affected?
>>
>> Yes, the fix has been applied
>> <http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/94465>.
>
> No, it has NOT been applied in mainline yet.
> See http://patchwork.ozlabs.org/patch/82763/ - status is still NEW.
Your right. I'm sure that Mario meant "suggested" instead of "applied".
BTW@Wolfgang: Any chance that it will be applied? We had no feedback (good or bad) in the u-boot ml for nearly a week.
Steffen
--
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:sledz@DResearch.de
Fax: +49 30 515932-299
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] u-boot-2009.03: Fix sector table direction for AMIC (hipox machine only)
2011-02-16 20:19 ` Sledz, Steffen
@ 2011-02-16 21:10 ` Wolfgang Denk
0 siblings, 0 replies; 13+ messages in thread
From: Wolfgang Denk @ 2011-02-16 21:10 UTC (permalink / raw)
To: Sledz, Steffen; +Cc: Schuknecht, Mario, openembedded-devel
Dear "Sledz, Steffen",
In message <DB561678F08F554EB0D9F21B70E268A505AFA8@exchange.intern.dresearch.de> you wrote:
>
> > No, it has NOT been applied in mainline yet.
> > See http://patchwork.ozlabs.org/patch/82763/ - status is still NEW.
>
> Your right. I'm sure that Mario meant "suggested" instead of "applied".
>
> BTW@Wolfgang: Any chance that it will be applied? We had no feedback
> (good or bad) in the u-boot ml for nearly a week.
No news is usually good news.
It would have been a good idea to Cc: the responsible maintainer,
though.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
The thing is, as you progress in the Craft, you'll learn there is
another rule... When you break rules, break 'em good and hard.
- Terry Pratchett, _Wyrd Sisters_
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2] u-boot-2009.03: use AMD fixups for AMIC too
2011-02-16 15:16 ` Schuknecht, Mario
2011-02-16 18:34 ` Wolfgang Denk
@ 2011-02-18 14:12 ` Steffen Sledz
2011-02-18 14:13 ` Steffen Sledz
` (2 more replies)
1 sibling, 3 replies; 13+ messages in thread
From: Steffen Sledz @ 2011-02-18 14:12 UTC (permalink / raw)
To: openembedded-devel
From: Mario Schuknecht <m.schuknecht@dresearch.de>
* AMIC flashes are AMD clones and need the same fixups.
Signed-off-by: Mario Schuknecht <m.schuknecht@dresearch.de>
Signed-off-by: Steffen Sledz <sledz@dresearch.de>
---
recipes/u-boot/u-boot-2009.03/cfi-amic-fixup.patch | 11 +++++++++++
recipes/u-boot/u-boot-2009.03/hipox/00-hipox.patch | 3 ++-
recipes/u-boot/u-boot_2009.03.bb | 7 +++++--
3 files changed, 18 insertions(+), 3 deletions(-)
create mode 100644 recipes/u-boot/u-boot-2009.03/cfi-amic-fixup.patch
diff --git a/recipes/u-boot/u-boot-2009.03/cfi-amic-fixup.patch b/recipes/u-boot/u-boot-2009.03/cfi-amic-fixup.patch
new file mode 100644
index 0000000..9d8c7ab
--- /dev/null
+++ b/recipes/u-boot/u-boot-2009.03/cfi-amic-fixup.patch
@@ -0,0 +1,11 @@
+diff -Nurd u-boot-2009.03.orig//drivers/mtd/cfi_flash.c u-boot-2009.03/drivers/mtd/cfi_flash.c
+--- u-boot-2009.03.orig//drivers/mtd/cfi_flash.c 2011-02-18 14:11:24.870432001 +0100
++++ u-boot-2009.03/drivers/mtd/cfi_flash.c 2011-02-18 14:11:45.440432001 +0100
+@@ -1883,6 +1883,7 @@
+ /* Do manufacturer-specific fixups */
+ switch (info->manufacturer_id) {
+ case 0x0001:
++ case 0x0037: // AMIC
+ flash_fixup_amd(info, &qry);
+ break;
+ case 0x001f:
diff --git a/recipes/u-boot/u-boot-2009.03/hipox/00-hipox.patch b/recipes/u-boot/u-boot-2009.03/hipox/00-hipox.patch
index 5b91d28..20a47da 100644
--- a/recipes/u-boot/u-boot-2009.03/hipox/00-hipox.patch
+++ b/recipes/u-boot/u-boot-2009.03/hipox/00-hipox.patch
@@ -6190,10 +6190,11 @@ diff -Nurd u-boot-2009.03.orig/cpu/arm926ejs/start.S u-boot-2009.03/cpu/arm926ej
diff -Nurd u-boot-2009.03.orig/drivers/mtd/cfi_flash.c u-boot-2009.03/drivers/mtd/cfi_flash.c
--- u-boot-2009.03.orig/drivers/mtd/cfi_flash.c 2009-04-15 11:05:24.000000000 +0200
+++ u-boot-2009.03/drivers/mtd/cfi_flash.c 2009-04-15 11:08:18.000000000 +0200
-@@ -1883,6 +1883,7 @@
+@@ -1883,7 +1883,8 @@
/* Do manufacturer-specific fixups */
switch (info->manufacturer_id) {
case 0x0001:
+ case 0x0037: // AMIC
+ case 0x00da: // Winbond
flash_fixup_amd(info, &qry);
break;
diff --git a/recipes/u-boot/u-boot_2009.03.bb b/recipes/u-boot/u-boot_2009.03.bb
index 2cbded9..4b822f1 100644
--- a/recipes/u-boot/u-boot_2009.03.bb
+++ b/recipes/u-boot/u-boot_2009.03.bb
@@ -6,9 +6,12 @@ DEFAULT_PREFERENCE_hipox = "1"
DEPENDS_append_hipox = " oxnas-boot-tools oxnas-boot-tools-native "
-SRC_URI = "ftp://ftp.denx.de/pub/u-boot/u-boot-${PV}.tar.bz2 "
+SRC_URI = "ftp://ftp.denx.de/pub/u-boot/u-boot-${PV}.tar.bz2 \
+ file://cfi-amic-fixup.patch \
+"
-SRC_URI_append_hipox = "file://00-hipox.patch \
+SRC_URI_append_hipox = " \
+ file://00-hipox.patch \
file://01-hipox-fix-gmac-reset.patch \
file://02-hipox-enable-mmu.patch \
file://03-hipox-direct-switch.patch \
--
1.7.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v2] u-boot-2009.03: use AMD fixups for AMIC too
2011-02-18 14:12 ` [PATCH v2] u-boot-2009.03: use AMD fixups for AMIC too Steffen Sledz
@ 2011-02-18 14:13 ` Steffen Sledz
2011-02-18 19:16 ` Tom Rini
2011-02-18 22:48 ` Paul Menzel
2 siblings, 0 replies; 13+ messages in thread
From: Steffen Sledz @ 2011-02-18 14:13 UTC (permalink / raw)
To: Steffen Sledz; +Cc: openembedded-devel
Am 18.02.2011 15:12, schrieb Steffen Sledz:
> From: Mario Schuknecht <m.schuknecht@dresearch.de>
>
> * AMIC flashes are AMD clones and need the same fixups.
I made some modifications to the patch to make it available at least for all u-boot-2009.03 users.
Steffen
--
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:sledz@DResearch.de
Fax: +49 30 515932-299
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2] u-boot-2009.03: use AMD fixups for AMIC too
2011-02-18 14:12 ` [PATCH v2] u-boot-2009.03: use AMD fixups for AMIC too Steffen Sledz
2011-02-18 14:13 ` Steffen Sledz
@ 2011-02-18 19:16 ` Tom Rini
2011-02-18 22:48 ` Paul Menzel
2 siblings, 0 replies; 13+ messages in thread
From: Tom Rini @ 2011-02-18 19:16 UTC (permalink / raw)
To: openembedded-devel
On 02/18/2011 07:12 AM, Steffen Sledz wrote:
> From: Mario Schuknecht<m.schuknecht@dresearch.de>
>
> * AMIC flashes are AMD clones and need the same fixups.
>
> Signed-off-by: Mario Schuknecht<m.schuknecht@dresearch.de>
> Signed-off-by: Steffen Sledz<sledz@dresearch.de>
Acked-by: Tom Rini <tom_rini@mentor.com>
> ---
> recipes/u-boot/u-boot-2009.03/cfi-amic-fixup.patch | 11 +++++++++++
> recipes/u-boot/u-boot-2009.03/hipox/00-hipox.patch | 3 ++-
> recipes/u-boot/u-boot_2009.03.bb | 7 +++++--
> 3 files changed, 18 insertions(+), 3 deletions(-)
> create mode 100644 recipes/u-boot/u-boot-2009.03/cfi-amic-fixup.patch
>
> diff --git a/recipes/u-boot/u-boot-2009.03/cfi-amic-fixup.patch b/recipes/u-boot/u-boot-2009.03/cfi-amic-fixup.patch
> new file mode 100644
> index 0000000..9d8c7ab
> --- /dev/null
> +++ b/recipes/u-boot/u-boot-2009.03/cfi-amic-fixup.patch
> @@ -0,0 +1,11 @@
> +diff -Nurd u-boot-2009.03.orig//drivers/mtd/cfi_flash.c u-boot-2009.03/drivers/mtd/cfi_flash.c
> +--- u-boot-2009.03.orig//drivers/mtd/cfi_flash.c 2011-02-18 14:11:24.870432001 +0100
> ++++ u-boot-2009.03/drivers/mtd/cfi_flash.c 2011-02-18 14:11:45.440432001 +0100
> +@@ -1883,6 +1883,7 @@
> + /* Do manufacturer-specific fixups */
> + switch (info->manufacturer_id) {
> + case 0x0001:
> ++ case 0x0037: // AMIC
> + flash_fixup_amd(info,&qry);
> + break;
> + case 0x001f:
> diff --git a/recipes/u-boot/u-boot-2009.03/hipox/00-hipox.patch b/recipes/u-boot/u-boot-2009.03/hipox/00-hipox.patch
> index 5b91d28..20a47da 100644
> --- a/recipes/u-boot/u-boot-2009.03/hipox/00-hipox.patch
> +++ b/recipes/u-boot/u-boot-2009.03/hipox/00-hipox.patch
> @@ -6190,10 +6190,11 @@ diff -Nurd u-boot-2009.03.orig/cpu/arm926ejs/start.S u-boot-2009.03/cpu/arm926ej
> diff -Nurd u-boot-2009.03.orig/drivers/mtd/cfi_flash.c u-boot-2009.03/drivers/mtd/cfi_flash.c
> --- u-boot-2009.03.orig/drivers/mtd/cfi_flash.c 2009-04-15 11:05:24.000000000 +0200
> +++ u-boot-2009.03/drivers/mtd/cfi_flash.c 2009-04-15 11:08:18.000000000 +0200
> -@@ -1883,6 +1883,7 @@
> +@@ -1883,7 +1883,8 @@
> /* Do manufacturer-specific fixups */
> switch (info->manufacturer_id) {
> case 0x0001:
> + case 0x0037: // AMIC
> + case 0x00da: // Winbond
> flash_fixup_amd(info,&qry);
> break;
> diff --git a/recipes/u-boot/u-boot_2009.03.bb b/recipes/u-boot/u-boot_2009.03.bb
> index 2cbded9..4b822f1 100644
> --- a/recipes/u-boot/u-boot_2009.03.bb
> +++ b/recipes/u-boot/u-boot_2009.03.bb
> @@ -6,9 +6,12 @@ DEFAULT_PREFERENCE_hipox = "1"
>
> DEPENDS_append_hipox = " oxnas-boot-tools oxnas-boot-tools-native "
>
> -SRC_URI = "ftp://ftp.denx.de/pub/u-boot/u-boot-${PV}.tar.bz2 "
> +SRC_URI = "ftp://ftp.denx.de/pub/u-boot/u-boot-${PV}.tar.bz2 \
> + file://cfi-amic-fixup.patch \
> +"
>
> -SRC_URI_append_hipox = "file://00-hipox.patch \
> +SRC_URI_append_hipox = " \
> + file://00-hipox.patch \
> file://01-hipox-fix-gmac-reset.patch \
> file://02-hipox-enable-mmu.patch \
> file://03-hipox-direct-switch.patch \
--
Tom Rini
Mentor Graphics Corporation
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2] u-boot-2009.03: use AMD fixups for AMIC too
2011-02-18 14:12 ` [PATCH v2] u-boot-2009.03: use AMD fixups for AMIC too Steffen Sledz
2011-02-18 14:13 ` Steffen Sledz
2011-02-18 19:16 ` Tom Rini
@ 2011-02-18 22:48 ` Paul Menzel
2011-02-19 6:53 ` Steffen Sledz
2 siblings, 1 reply; 13+ messages in thread
From: Paul Menzel @ 2011-02-18 22:48 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 3518 bytes --]
Am Freitag, den 18.02.2011, 15:12 +0100 schrieb Steffen Sledz:
> From: Mario Schuknecht <m.schuknecht@dresearch.de>
>
> * AMIC flashes are AMD clones and need the same fixups.
… otherwise the uBoot command `saveenv` does not work.
Please add in the commit message or in the patch file that this patch
has been sent upstream [1].
[1] http://patchwork.ozlabs.org/patch/82763/
> Signed-off-by: Mario Schuknecht <m.schuknecht@dresearch.de>
> Signed-off-by: Steffen Sledz <sledz@dresearch.de>
> ---
> recipes/u-boot/u-boot-2009.03/cfi-amic-fixup.patch | 11 +++++++++++
> recipes/u-boot/u-boot-2009.03/hipox/00-hipox.patch | 3 ++-
> recipes/u-boot/u-boot_2009.03.bb | 7 +++++--
> 3 files changed, 18 insertions(+), 3 deletions(-)
> create mode 100644 recipes/u-boot/u-boot-2009.03/cfi-amic-fixup.patch
>
> diff --git a/recipes/u-boot/u-boot-2009.03/cfi-amic-fixup.patch b/recipes/u-boot/u-boot-2009.03/cfi-amic-fixup.patch
> new file mode 100644
> index 0000000..9d8c7ab
> --- /dev/null
> +++ b/recipes/u-boot/u-boot-2009.03/cfi-amic-fixup.patch
> @@ -0,0 +1,11 @@
> +diff -Nurd u-boot-2009.03.orig//drivers/mtd/cfi_flash.c u-boot-2009.03/drivers/mtd/cfi_flash.c
> +--- u-boot-2009.03.orig//drivers/mtd/cfi_flash.c 2011-02-18 14:11:24.870432001 +0100
> ++++ u-boot-2009.03/drivers/mtd/cfi_flash.c 2011-02-18 14:11:45.440432001 +0100
> +@@ -1883,6 +1883,7 @@
> + /* Do manufacturer-specific fixups */
> + switch (info->manufacturer_id) {
> + case 0x0001:
> ++ case 0x0037: // AMIC
> + flash_fixup_amd(info, &qry);
> + break;
> + case 0x001f:
> diff --git a/recipes/u-boot/u-boot-2009.03/hipox/00-hipox.patch b/recipes/u-boot/u-boot-2009.03/hipox/00-hipox.patch
> index 5b91d28..20a47da 100644
> --- a/recipes/u-boot/u-boot-2009.03/hipox/00-hipox.patch
> +++ b/recipes/u-boot/u-boot-2009.03/hipox/00-hipox.patch
> @@ -6190,10 +6190,11 @@ diff -Nurd u-boot-2009.03.orig/cpu/arm926ejs/start.S u-boot-2009.03/cpu/arm926ej
> diff -Nurd u-boot-2009.03.orig/drivers/mtd/cfi_flash.c u-boot-2009.03/drivers/mtd/cfi_flash.c
> --- u-boot-2009.03.orig/drivers/mtd/cfi_flash.c 2009-04-15 11:05:24.000000000 +0200
> +++ u-boot-2009.03/drivers/mtd/cfi_flash.c 2009-04-15 11:08:18.000000000 +0200
> -@@ -1883,6 +1883,7 @@
> +@@ -1883,7 +1883,8 @@
> /* Do manufacturer-specific fixups */
> switch (info->manufacturer_id) {
> case 0x0001:
> + case 0x0037: // AMIC
> + case 0x00da: // Winbond
> flash_fixup_amd(info, &qry);
> break;
> diff --git a/recipes/u-boot/u-boot_2009.03.bb b/recipes/u-boot/u-boot_2009.03.bb
> index 2cbded9..4b822f1 100644
> --- a/recipes/u-boot/u-boot_2009.03.bb
> +++ b/recipes/u-boot/u-boot_2009.03.bb
> @@ -6,9 +6,12 @@ DEFAULT_PREFERENCE_hipox = "1"
>
> DEPENDS_append_hipox = " oxnas-boot-tools oxnas-boot-tools-native "
>
> -SRC_URI = "ftp://ftp.denx.de/pub/u-boot/u-boot-${PV}.tar.bz2 "
> +SRC_URI = "ftp://ftp.denx.de/pub/u-boot/u-boot-${PV}.tar.bz2 \
> + file://cfi-amic-fixup.patch \
> +"
>
> -SRC_URI_append_hipox = "file://00-hipox.patch \
> +SRC_URI_append_hipox = " \
> + file://00-hipox.patch \
> file://01-hipox-fix-gmac-reset.patch \
> file://02-hipox-enable-mmu.patch \
> file://03-hipox-direct-switch.patch \
If you build for `hipox` is not your fix applied twice? Or am I
mistaken?
If I am and with the changes requested in the beginning,
Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>
Thanks,
Paul
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2] u-boot-2009.03: use AMD fixups for AMIC too
2011-02-18 22:48 ` Paul Menzel
@ 2011-02-19 6:53 ` Steffen Sledz
2011-02-19 9:05 ` Paul Menzel
0 siblings, 1 reply; 13+ messages in thread
From: Steffen Sledz @ 2011-02-19 6:53 UTC (permalink / raw)
To: openembedded-devel; +Cc: Paul Menzel
On 02/18/2011 11:48 PM, Paul Menzel wrote:
> Am Freitag, den 18.02.2011, 15:12 +0100 schrieb Steffen Sledz:
>> From: Mario Schuknecht <m.schuknecht@dresearch.de>
>>
>> * AMIC flashes are AMD clones and need the same fixups.
>
> … otherwise the uBoot command `saveenv` does not work.
>
> Please add in the commit message or in the patch file that this patch
> has been sent upstream [1].
>
> [1] http://patchwork.ozlabs.org/patch/82763/
Added.
> If you build for `hipox` is not your fix applied twice? Or am I
> mistaken?
Your mistaken. ;-)
> If I am and with the changes requested in the beginning,
>
> Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>
Pushed.
--
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:sledz@DResearch.de
Fax: +49 30 515932-299
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2] u-boot-2009.03: use AMD fixups for AMIC too
2011-02-19 6:53 ` Steffen Sledz
@ 2011-02-19 9:05 ` Paul Menzel
0 siblings, 0 replies; 13+ messages in thread
From: Paul Menzel @ 2011-02-19 9:05 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 393 bytes --]
Am Samstag, den 19.02.2011, 07:53 +0100 schrieb Steffen Sledz:
> On 02/18/2011 11:48 PM, Paul Menzel wrote:
[…]
> > If you build for `hipox` is not your fix applied twice? Or am I
> > mistaken?
>
> Your mistaken. ;-)
I should have seen that the »+« are on different levels. I always get
confused by patches to patches.
Sorry for the noise.
[…]
Thanks,
Paul
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2011-02-19 9:06 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-16 13:26 [PATCH] u-boot-2009.03: Fix sector table direction for AMIC (hipox machine only) Mario Schuknecht
2011-02-16 14:50 ` Steffen Sledz
2011-02-16 14:52 ` Paul Menzel
2011-02-16 15:16 ` Schuknecht, Mario
2011-02-16 18:34 ` Wolfgang Denk
2011-02-16 20:19 ` Sledz, Steffen
2011-02-16 21:10 ` Wolfgang Denk
2011-02-18 14:12 ` [PATCH v2] u-boot-2009.03: use AMD fixups for AMIC too Steffen Sledz
2011-02-18 14:13 ` Steffen Sledz
2011-02-18 19:16 ` Tom Rini
2011-02-18 22:48 ` Paul Menzel
2011-02-19 6:53 ` Steffen Sledz
2011-02-19 9:05 ` Paul Menzel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.