[PATCH] cross.bbclass: Fix many QA RPATH errors for distros preferring libtool-2.2

[PATCH] cross.bbclass: Fix many QA RPATH errors for distros preferring libtool-2.2

[Andreas Mueller]

* This patch removes the absolute path in sysroots/<arch>/usr/lib/libstdc++.la
*
* It was build tested wih clean tmp for xfce46-image. Additional known
* QA-RPATH-error-candidates were checked for successful build:
*
* aspell-0.60.6-r0
* curl-7.21.2-r4.0
* clutter-box2d-0.10.0-r2.0+git4e72b9c135a9439b82d801c62422531db611f98b
* enchant-1.6.0-r2
* gnome-vfs-2.24.1-r3
* libcdio-0.82-r3.0
* libsoup-2.2.100-r1:
* neon-0.25.5-r4
* schroedinger-1.0.9-r0
* tiff-3.9.4+4.0.0beta6-r0
*
* Build environment was (RPATH QA errors treated as fatal / acl fixed manually)
*
* BB_VERSION        = "1.10.2"
* METADATA_BRANCH   = "cross-bbclass-test"
* METADATA_REVISION = "a44300e"
* TARGET_ARCH       = "arm"
* TARGET_OS         = "linux-gnueabi"
* MACHINE           = "overo"
* DISTRO            = "angstrom"
* DISTRO_VERSION    = "2010.7-test-20110219"
* TARGET_FPU        = "hard"
*
* Notes:
* - To have effect, gcc-cross has to be rebuild (changing all gcc packed
*   was not an option)
* - This patch does not affect libtool-2.4 distos
* - The story is found at
*   http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-February/030115.html

Signed-off-by: Andreas Mueller <schnitzeltony@gmx.de>
---
 classes/cross.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/classes/cross.bbclass b/classes/cross.bbclass
index 1a6d906..50c0f63 100644
--- a/classes/cross.bbclass
+++ b/classes/cross.bbclass
@@ -75,6 +75,6 @@ sysroot_stage_all() {
 
 #
 # Cross .la files have more path issues we have to correct only for libtool < 2.4
-SYSROOTEXTRALIBDIRSED_OLD = " -e \"/^libdir=/s,.*,libdir=${STAGING_DIR_TARGET}${target_libdir},g\" -e \"/^dependency_libs=/s,\([[:space:]']\)-L${STAGING_LIBDIR_NATIVE},,g\""
+SYSROOTEXTRALIBDIRSED_OLD = " -e \"/^libdir=/s,.*,libdir=${target_libdir},g\" -e \"/^dependency_libs=/s,\([[:space:]']\)-L${STAGING_LIBDIR_NATIVE},,g\""
 
 SYSROOTEXTRALIBDIRSED = "${@["${SYSROOTEXTRALIBDIRSED_OLD}",""][("${LIBTOOL_HAS_SYSROOT}" == "yes")]}"
-- 
1.7.2.3

Re: [PATCH] cross.bbclass: Fix many QA RPATH errors for distros preferring libtool-2.2

[Eric Benard]

Hi Andreas,

> index 1a6d906..50c0f63 100644
> --- a/classes/cross.bbclass
> +++ b/classes/cross.bbclass
> @@ -75,6 +75,6 @@ sysroot_stage_all() {
>
>   #
>   # Cross .la files have more path issues we have to correct only for libtool<  2.4
> -SYSROOTEXTRALIBDIRSED_OLD = " -e \"/^libdir=/s,.*,libdir=${STAGING_DIR_TARGET}${target_libdir},g\" -e \"/^dependency_libs=/s,\([[:space:]']\)-L${STAGING_LIBDIR_NATIVE},,g\""
> +SYSROOTEXTRALIBDIRSED_OLD = " -e \"/^libdir=/s,.*,libdir=${target_libdir},g\" -e \"/^dependency_libs=/s,\([[:space:]']\)-L${STAGING_LIBDIR_NATIVE},,g\""
>
>   SYSROOTEXTRALIBDIRSED = "${@["${SYSROOTEXTRALIBDIRSED_OLD}",""][("${LIBTOOL_HAS_SYSROOT}" == "yes")]}"

I was just finishing to test a similar fix and this seems to be the right 
direction. Now testing your fix which is cleaner.

Eric

Re: [PATCH] cross.bbclass: Fix many QA RPATH errors for distros preferring libtool-2.2

[Khem Raj]

On (19/02/11 13:11), Eric Benard wrote:
> Hi Andreas,
> 
> >index 1a6d906..50c0f63 100644
> >--- a/classes/cross.bbclass
> >+++ b/classes/cross.bbclass
> >@@ -75,6 +75,6 @@ sysroot_stage_all() {
> >
> >  #
> >  # Cross .la files have more path issues we have to correct only for libtool<  2.4
> >-SYSROOTEXTRALIBDIRSED_OLD = " -e \"/^libdir=/s,.*,libdir=${STAGING_DIR_TARGET}${target_libdir},g\" -e \"/^dependency_libs=/s,\([[:space:]']\)-L${STAGING_LIBDIR_NATIVE},,g\""
> >+SYSROOTEXTRALIBDIRSED_OLD = " -e \"/^libdir=/s,.*,libdir=${target_libdir},g\" -e \"/^dependency_libs=/s,\([[:space:]']\)-L${STAGING_LIBDIR_NATIVE},,g\""
> >
> >  SYSROOTEXTRALIBDIRSED = "${@["${SYSROOTEXTRALIBDIRSED_OLD}",""][("${LIBTOOL_HAS_SYSROOT}" == "yes")]}"
> 
> I was just finishing to test a similar fix and this seems to be the
> right direction. Now testing your fix which is cleaner.

Also try meta-toolchain targets 
> 
> Eric
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

-- 
-Khem

Re: [PATCH] cross.bbclass: Fix many QA RPATH errors for distros preferring libtool-2.2

[Tom Rini]

On 02/19/2011 06:23 PM, Khem Raj wrote:
> On (19/02/11 13:11), Eric Benard wrote:
>> Hi Andreas,
>>
>>> index 1a6d906..50c0f63 100644
>>> --- a/classes/cross.bbclass
>>> +++ b/classes/cross.bbclass
>>> @@ -75,6 +75,6 @@ sysroot_stage_all() {
>>>
>>>   #
>>>   # Cross .la files have more path issues we have to correct only for libtool<   2.4
>>> -SYSROOTEXTRALIBDIRSED_OLD = " -e \"/^libdir=/s,.*,libdir=${STAGING_DIR_TARGET}${target_libdir},g\" -e \"/^dependency_libs=/s,\([[:space:]']\)-L${STAGING_LIBDIR_NATIVE},,g\""
>>> +SYSROOTEXTRALIBDIRSED_OLD = " -e \"/^libdir=/s,.*,libdir=${target_libdir},g\" -e \"/^dependency_libs=/s,\([[:space:]']\)-L${STAGING_LIBDIR_NATIVE},,g\""
>>>
>>>   SYSROOTEXTRALIBDIRSED = "${@["${SYSROOTEXTRALIBDIRSED_OLD}",""][("${LIBTOOL_HAS_SYSROOT}" == "yes")]}"
>>
>> I was just finishing to test a similar fix and this seems to be the
>> right direction. Now testing your fix which is cleaner.
>
> Also try meta-toolchain targets

I'm kicking off a subset of my normal matrix with this change applied 
and hope to report back results in the morning (-0700).

-- 
Tom Rini
Mentor Graphics Corporation

Re: [PATCH] cross.bbclass: Fix many QA RPATH errors for distros preferring libtool-2.2

[Eric Benard]

On 19/02/2011 12:53, Andreas Mueller wrote:
> * This patch removes the absolute path in sysroots/<arch>/usr/lib/libstdc++.la
> *
> * It was build tested wih clean tmp for xfce46-image. Additional known
> * QA-RPATH-error-candidates were checked for successful build:
> *
> * aspell-0.60.6-r0
> * curl-7.21.2-r4.0
> * clutter-box2d-0.10.0-r2.0+git4e72b9c135a9439b82d801c62422531db611f98b
> * enchant-1.6.0-r2
> * gnome-vfs-2.24.1-r3
> * libcdio-0.82-r3.0
> * libsoup-2.2.100-r1:
> * neon-0.25.5-r4
> * schroedinger-1.0.9-r0
> * tiff-3.9.4+4.0.0beta6-r0
> *
> * Build environment was (RPATH QA errors treated as fatal / acl fixed manually)
> *
> * BB_VERSION        = "1.10.2"
> * METADATA_BRANCH   = "cross-bbclass-test"
> * METADATA_REVISION = "a44300e"
> * TARGET_ARCH       = "arm"
> * TARGET_OS         = "linux-gnueabi"
> * MACHINE           = "overo"
> * DISTRO            = "angstrom"
> * DISTRO_VERSION    = "2010.7-test-20110219"
> * TARGET_FPU        = "hard"
> *
> * Notes:
> * - To have effect, gcc-cross has to be rebuild (changing all gcc packed
> *   was not an option)
> * - This patch does not affect libtool-2.4 distos
> * - The story is found at
> *   http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-February/030115.html
>
> Signed-off-by: Andreas Mueller<schnitzeltony@gmx.de>
Acked-by: Eric Bénard <eric@eukrea.com>

Re: [PATCH] cross.bbclass: Fix many QA RPATH errors for distros preferring libtool-2.2

[Tom Rini]

On 02/22/2011 01:19 AM, Eric Benard wrote:
> On 19/02/2011 12:53, Andreas Mueller wrote:
>> * This patch removes the absolute path in
>> sysroots/<arch>/usr/lib/libstdc++.la
>> *
>> * It was build tested wih clean tmp for xfce46-image. Additional known
>> * QA-RPATH-error-candidates were checked for successful build:
>> *
>> * aspell-0.60.6-r0
>> * curl-7.21.2-r4.0
>> * clutter-box2d-0.10.0-r2.0+git4e72b9c135a9439b82d801c62422531db611f98b
>> * enchant-1.6.0-r2
>> * gnome-vfs-2.24.1-r3
>> * libcdio-0.82-r3.0
>> * libsoup-2.2.100-r1:
>> * neon-0.25.5-r4
>> * schroedinger-1.0.9-r0
>> * tiff-3.9.4+4.0.0beta6-r0
>> *
>> * Build environment was (RPATH QA errors treated as fatal / acl fixed
>> manually)
>> *
>> * BB_VERSION = "1.10.2"
>> * METADATA_BRANCH = "cross-bbclass-test"
>> * METADATA_REVISION = "a44300e"
>> * TARGET_ARCH = "arm"
>> * TARGET_OS = "linux-gnueabi"
>> * MACHINE = "overo"
>> * DISTRO = "angstrom"
>> * DISTRO_VERSION = "2010.7-test-20110219"
>> * TARGET_FPU = "hard"
>> *
>> * Notes:
>> * - To have effect, gcc-cross has to be rebuild (changing all gcc packed
>> * was not an option)
>> * - This patch does not affect libtool-2.4 distos
>> * - The story is found at
>> *
>> http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-February/030115.html
>>
>>
>> Signed-off-by: Andreas Mueller<schnitzeltony@gmx.de>
> Acked-by: Eric Bénard <eric@eukrea.com>

Acked-by: Tom Rini <tom_rini@mentor.com>

-- 
Tom Rini
Mentor Graphics Corporation

Re: [PATCH] cross.bbclass: Fix many QA RPATH errors for distros preferring libtool-2.2

[Tom Rini]

On 02/21/2011 06:44 PM, Tom Rini wrote:
> On 02/19/2011 06:23 PM, Khem Raj wrote:
>> On (19/02/11 13:11), Eric Benard wrote:
>>> Hi Andreas,
>>>
>>>> index 1a6d906..50c0f63 100644
>>>> --- a/classes/cross.bbclass
>>>> +++ b/classes/cross.bbclass
>>>> @@ -75,6 +75,6 @@ sysroot_stage_all() {
>>>>
>>>> #
>>>> # Cross .la files have more path issues we have to correct only for
>>>> libtool< 2.4
>>>> -SYSROOTEXTRALIBDIRSED_OLD = " -e
>>>> \"/^libdir=/s,.*,libdir=${STAGING_DIR_TARGET}${target_libdir},g\" -e
>>>> \"/^dependency_libs=/s,\([[:space:]']\)-L${STAGING_LIBDIR_NATIVE},,g\""
>>>> +SYSROOTEXTRALIBDIRSED_OLD = " -e
>>>> \"/^libdir=/s,.*,libdir=${target_libdir},g\" -e
>>>> \"/^dependency_libs=/s,\([[:space:]']\)-L${STAGING_LIBDIR_NATIVE},,g\""
>>>>
>>>> SYSROOTEXTRALIBDIRSED =
>>>> "${@["${SYSROOTEXTRALIBDIRSED_OLD}",""][("${LIBTOOL_HAS_SYSROOT}" ==
>>>> "yes")]}"
>>>
>>> I was just finishing to test a similar fix and this seems to be the
>>> right direction. Now testing your fix which is cleaner.
>>
>> Also try meta-toolchain targets
>
> I'm kicking off a subset of my normal matrix with this change applied
> and hope to report back results in the morning (-0700).

Results look good.  The results are at http://i.imgur.com/3zmKi.png and 
the failures here are:
- qemux86 + libpcap2 + current kheaders aren't happy
- A lot of failures like:
| checking host system type...
| configure: error: invalid value of canonical host
NOTE: package xextproto-1_7.1.2-r2.0: task do_configure: Failed
ERROR: Function 'do_configure' failed (see 
/var/hudson/workspace/sb_openembedded_autobuilder_quicktest/BBPKGS/qt4e-demo-image/DISTRO/minimal/MACHINE/qemush4/label/sb-u1004/tmp/work/sh4-oe-linux/xextproto-1_7.1.2-r2.0/temp/log.do_configure.13916 
for further information)
ERROR: Task 2867 
(/var/hudson/workspace/sb_openembedded_autobuilder_quicktest/BBPKGS/qt4e-demo-image/DISTRO/minimal/MACHINE/qemush4/label/sb-u1004/recipes/xorg-proto/xextproto_7.1.2.bb, 
do_configure) failed with exit code '1'

Which I need to dig into.

-- 
Tom Rini
Mentor Graphics Corporation

Re: [PATCH] cross.bbclass: Fix many QA RPATH errors for distros preferring libtool-2.2

[Andreas Mueller]

On Tuesday 22 February 2011 15:59:59 Tom Rini wrote:
> On 02/21/2011 06:44 PM, Tom Rini wrote:
> > On 02/19/2011 06:23 PM, Khem Raj wrote:
> >> On (19/02/11 13:11), Eric Benard wrote:
> >>> Hi Andreas,
> >>> 
> >>>> index 1a6d906..50c0f63 100644
> >>>> --- a/classes/cross.bbclass
> >>>> +++ b/classes/cross.bbclass
> >>>> @@ -75,6 +75,6 @@ sysroot_stage_all() {
> >>>> 
> >>>> #
> >>>> # Cross .la files have more path issues we have to correct only for
> >>>> libtool< 2.4
> >>>> -SYSROOTEXTRALIBDIRSED_OLD = " -e
> >>>> \"/^libdir=/s,.*,libdir=${STAGING_DIR_TARGET}${target_libdir},g\" -e
> >>>> \"/^dependency_libs=/s,\([[:space:]']\)-L${STAGING_LIBDIR_NATIVE},,g\"
> >>>> " +SYSROOTEXTRALIBDIRSED_OLD = " -e
> >>>> \"/^libdir=/s,.*,libdir=${target_libdir},g\" -e
> >>>> \"/^dependency_libs=/s,\([[:space:]']\)-L${STAGING_LIBDIR_NATIVE},,g\"
> >>>> "
> >>>> 
> >>>> SYSROOTEXTRALIBDIRSED =
> >>>> "${@["${SYSROOTEXTRALIBDIRSED_OLD}",""][("${LIBTOOL_HAS_SYSROOT}" ==
> >>>> "yes")]}"
> >>> 
> >>> I was just finishing to test a similar fix and this seems to be the
> >>> right direction. Now testing your fix which is cleaner.
> >> 
> >> Also try meta-toolchain targets
> > 
> > I'm kicking off a subset of my normal matrix with this change applied
> > and hope to report back results in the morning (-0700).
> 
> Results look good.  The results are at http://i.imgur.com/3zmKi.png and
> the failures here are:
> - qemux86 + libpcap2 + current kheaders aren't happy
> 
> - A lot of failures like:
> | checking host system type...
> | configure: error: invalid value of canonical host
> 
> NOTE: package xextproto-1_7.1.2-r2.0: task do_configure: Failed
> ERROR: Function 'do_configure' failed (see
> /var/hudson/workspace/sb_openembedded_autobuilder_quicktest/BBPKGS/qt4e-dem
> o-image/DISTRO/minimal/MACHINE/qemush4/label/sb-u1004/tmp/work/sh4-oe-linux
> /xextproto-1_7.1.2-r2.0/temp/log.do_configure.13916 for further
> information)
> ERROR: Task 2867
> (/var/hudson/workspace/sb_openembedded_autobuilder_quicktest/BBPKGS/qt4e-de
> mo-image/DISTRO/minimal/MACHINE/qemush4/label/sb-u1004/recipes/xorg-proto/x
> extproto_7.1.2.bb, do_configure) failed with exit code '1'
> 
> Which I need to dig into.
wow - your job getting the release out of the door is really impressive - thanks 
a lot!

Andreas