All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Éric Piel" <Eric.Piel@tremplin-utc.net>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 0/4] Move lis3lv02d and hp_accel out of
Date: Sun, 20 Feb 2011 18:16:24 +0000	[thread overview]
Message-ID: <4D615A78.3090206@tremplin-utc.net> (raw)
In-Reply-To: <20110219141219.47aba4f8@endymion.delvare>

Op 19-02-11 14:12, Jean Delvare schreef:
> Hi all,
>
> Here is a patch set moving lis3lv02d and hp_accel out of drivers/hwmon.
> hp_accel goes where it belongs, i.e. drivers/platform/x86 (next to
> hdaps.) For lis3lv02d, I would have preferred a more specific home, but
> none seems to be suitable at the moment, so I went for drivers/misc. We
> might revisit this later.
>
> [PATCH 1/4] Let Kconfig handle lis3lv02d dependencies
> [PATCH 2/4] Move hp_accel to drivers/platform/x86
> [PATCH 3/4] Move lis3lv02d drivers to drivers/misc
> [PATCH 4/4] hp_accel: Fix driver name
>
> As with every patch moving files around, the patches look very large
> but most of them can be ignored, all you really have to look at are the
> Kconfig and Makefile changes.
>
> Note that I don't have supported hardware so I wasn't able to test the
> patches. So I would welcome testing as much as review.
>
Hello,
I'm completely fine with the move (it was in hwmon only because in the 
first place there were other accelerometers there). So here is my:
Acked-by: Éric Piel <eric.piel@tremplin-utc.net>

I'll try to test the changes tomorrow (on an HP notebook), to confirm.

BTW, why do hp_accel has to be in a different directory than the rest? 
To me it's just a different interface to the chip: ACPI/HP, instead of 
SPI or I²C.

See you,
Eric


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  reply	other threads:[~2011-02-20 18:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-19 13:12 [lm-sensors] [PATCH 0/4] Move lis3lv02d and hp_accel out of Jean Delvare
2011-02-20 18:16 ` Éric Piel [this message]
2011-02-20 19:26 ` Jean Delvare
2011-02-21 18:24 ` Jonathan Cameron
2011-02-22  9:21 ` Jean Delvare
2011-02-22 12:14 ` Jonathan Cameron
2011-02-24  9:09 ` Éric Piel
2011-02-24  9:14 ` Takashi Iwai
2011-02-24  9:18 ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D615A78.3090206@tremplin-utc.net \
    --to=eric.piel@tremplin-utc.net \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.