From: "Cousson, Benoit" <b-cousson@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/3] OMAP: smartreflex: move plat/smartreflex.h to mach-omap2/smartreflex.h
Date: Mon, 21 Feb 2011 10:55:58 +0100 [thread overview]
Message-ID: <4D6236AE.7000407@ti.com> (raw)
In-Reply-To: <20110221020851.7598.57763.stgit@twilight.localdomain>
Hi Paul,
On 2/21/2011 3:08 AM, Paul Walmsley wrote:
> There's no reason for this header file to be in
> plat-omap/include/plat/smartreflex.h. The hardware devices are in
> OMAP2+ SoCs only. Leaving this header file in plat-omap causes
> problems due to cross-dependencies with other header files that should
> live in mach-omap2/.
>
> Signed-off-by: Paul Walmsley<paul@pwsan.com>
> ---
> arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 2 +-
> arch/arm/mach-omap2/smartreflex-class3.c | 2 +-
> arch/arm/mach-omap2/smartreflex.c | 2 +-
> arch/arm/mach-omap2/smartreflex.h | 0
> arch/arm/mach-omap2/sr_device.c | 2 +-
> 5 files changed, 4 insertions(+), 4 deletions(-)
> rename arch/arm/{plat-omap/include/plat/smartreflex.h => mach-omap2/smartreflex.h} (100%)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> index 8d81813..7f0b5e7 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> @@ -21,13 +21,13 @@
> #include<plat/l4_3xxx.h>
> #include<plat/i2c.h>
> #include<plat/gpio.h>
> -#include<plat/smartreflex.h>
In fact that include is not used for OMAP4 data and does not seems to be
used either in this file.
I guess you can simply remove it.
Benoit
WARNING: multiple messages have this Message-ID (diff)
From: b-cousson@ti.com (Cousson, Benoit)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] OMAP: smartreflex: move plat/smartreflex.h to mach-omap2/smartreflex.h
Date: Mon, 21 Feb 2011 10:55:58 +0100 [thread overview]
Message-ID: <4D6236AE.7000407@ti.com> (raw)
In-Reply-To: <20110221020851.7598.57763.stgit@twilight.localdomain>
Hi Paul,
On 2/21/2011 3:08 AM, Paul Walmsley wrote:
> There's no reason for this header file to be in
> plat-omap/include/plat/smartreflex.h. The hardware devices are in
> OMAP2+ SoCs only. Leaving this header file in plat-omap causes
> problems due to cross-dependencies with other header files that should
> live in mach-omap2/.
>
> Signed-off-by: Paul Walmsley<paul@pwsan.com>
> ---
> arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 2 +-
> arch/arm/mach-omap2/smartreflex-class3.c | 2 +-
> arch/arm/mach-omap2/smartreflex.c | 2 +-
> arch/arm/mach-omap2/smartreflex.h | 0
> arch/arm/mach-omap2/sr_device.c | 2 +-
> 5 files changed, 4 insertions(+), 4 deletions(-)
> rename arch/arm/{plat-omap/include/plat/smartreflex.h => mach-omap2/smartreflex.h} (100%)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> index 8d81813..7f0b5e7 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> @@ -21,13 +21,13 @@
> #include<plat/l4_3xxx.h>
> #include<plat/i2c.h>
> #include<plat/gpio.h>
> -#include<plat/smartreflex.h>
In fact that include is not used for OMAP4 data and does not seems to be
used either in this file.
I guess you can simply remove it.
Benoit
next prev parent reply other threads:[~2011-02-21 9:56 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 2:08 [PATCH 0/3] OMAP2+: voltage: first pass at cleanup/reorganization Paul Walmsley
2011-02-21 2:08 ` Paul Walmsley
2011-02-21 2:08 ` [PATCH 1/3] OMAP: smartreflex: move plat/smartreflex.h to mach-omap2/smartreflex.h Paul Walmsley
2011-02-21 2:08 ` Paul Walmsley
2011-02-21 9:55 ` Cousson, Benoit [this message]
2011-02-21 9:55 ` Cousson, Benoit
2011-02-21 18:08 ` Paul Walmsley
2011-02-21 18:08 ` Paul Walmsley
2011-02-21 2:08 ` [PATCH 2/3] OMAP: voltage: move plat/voltage.h to mach-omap2/voltage.h Paul Walmsley
2011-02-21 2:08 ` Paul Walmsley
2011-02-21 4:51 ` Gulati, Shweta
2011-02-21 4:51 ` Gulati, Shweta
2011-02-21 2:08 ` [PATCH 3/3] OMAP2+: voltage: reorganize, split code from data Paul Walmsley
2011-02-21 2:08 ` Paul Walmsley
2011-02-21 7:59 ` Gulati, Shweta
2011-02-21 7:59 ` Gulati, Shweta
2011-02-21 18:53 ` Paul Walmsley
2011-02-21 18:53 ` Paul Walmsley
2011-02-21 19:00 ` Paul Walmsley
2011-02-21 19:00 ` Paul Walmsley
2011-02-24 11:57 ` [PATCH 0/3] OMAP2+: voltage: first pass at cleanup/reorganization Rajendra Nayak
2011-02-24 11:57 ` Rajendra Nayak
2011-02-25 5:03 ` Paul Walmsley
2011-02-25 5:03 ` Paul Walmsley
2011-02-25 5:32 ` Rajendra Nayak
2011-02-25 5:32 ` Rajendra Nayak
2011-02-25 21:42 ` Paul Walmsley
2011-02-25 21:42 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6236AE.7000407@ti.com \
--to=b-cousson@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.