All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
To: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	konkers-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org,
	ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org
Subject: Re: [PATCH 1/6] ARM: tegra: add tegra_gpio_table and tegra_gpio_config
Date: Tue, 22 Feb 2011 16:13:05 +0300	[thread overview]
Message-ID: <4D63B661.6000407@ru.mvista.com> (raw)
In-Reply-To: <1298354117-19097-2-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>

Hello.

On 22-02-2011 8:55, Olof Johansson wrote:

> To give one place to setup the pins that are used as GPIOs instead
> of as their pinmuxed functions. Specifying enabled as false explicitly
> disables the gpio mode of that pin (if left on by firmware).

> This should remove the need for calling these from specific drivers and
> thus reduce tegra-specific code from them.

> Signed-off-by: Olof Johansson<olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
[...]

> diff --git a/arch/arm/mach-tegra/include/mach/gpio.h b/arch/arm/mach-tegra/include/mach/gpio.h
> index e31f486..2369fba 100644
> --- a/arch/arm/mach-tegra/include/mach/gpio.h
> +++ b/arch/arm/mach-tegra/include/mach/gpio.h
> @@ -20,6 +20,7 @@
>   #ifndef __MACH_TEGRA_GPIO_H
>   #define __MACH_TEGRA_GPIO_H
>
> +#include<linux/init.h>
>   #include<mach/irqs.h>
>
>   #define TEGRA_NR_GPIOS		INT_GPIO_NR
> @@ -47,6 +48,12 @@ static inline int irq_to_gpio(unsigned int irq)
>   	return -EINVAL;
>   }
>
> +struct tegra_gpio_table {
> +	int	gpio;	/* GPIO number */
> +	bool	enable;	/* Enable for GPIO at init? */
> +};
> +
> +void __init tegra_gpio_config(struct tegra_gpio_table *table, int num);

    You don't need to annotate the declaration as __init.

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] ARM: tegra: add tegra_gpio_table and tegra_gpio_config
Date: Tue, 22 Feb 2011 16:13:05 +0300	[thread overview]
Message-ID: <4D63B661.6000407@ru.mvista.com> (raw)
In-Reply-To: <1298354117-19097-2-git-send-email-olof@lixom.net>

Hello.

On 22-02-2011 8:55, Olof Johansson wrote:

> To give one place to setup the pins that are used as GPIOs instead
> of as their pinmuxed functions. Specifying enabled as false explicitly
> disables the gpio mode of that pin (if left on by firmware).

> This should remove the need for calling these from specific drivers and
> thus reduce tegra-specific code from them.

> Signed-off-by: Olof Johansson<olof@lixom.net>
[...]

> diff --git a/arch/arm/mach-tegra/include/mach/gpio.h b/arch/arm/mach-tegra/include/mach/gpio.h
> index e31f486..2369fba 100644
> --- a/arch/arm/mach-tegra/include/mach/gpio.h
> +++ b/arch/arm/mach-tegra/include/mach/gpio.h
> @@ -20,6 +20,7 @@
>   #ifndef __MACH_TEGRA_GPIO_H
>   #define __MACH_TEGRA_GPIO_H
>
> +#include<linux/init.h>
>   #include<mach/irqs.h>
>
>   #define TEGRA_NR_GPIOS		INT_GPIO_NR
> @@ -47,6 +48,12 @@ static inline int irq_to_gpio(unsigned int irq)
>   	return -EINVAL;
>   }
>
> +struct tegra_gpio_table {
> +	int	gpio;	/* GPIO number */
> +	bool	enable;	/* Enable for GPIO at init? */
> +};
> +
> +void __init tegra_gpio_config(struct tegra_gpio_table *table, int num);

    You don't need to annotate the declaration as __init.

WBR, Sergei

  parent reply	other threads:[~2011-02-22 13:13 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-22  5:55 [PATCH v3 0/6] Tegra board patches Olof Johansson
2011-02-22  5:55 ` Olof Johansson
     [not found] ` <1298354117-19097-1-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
2011-02-22  5:55   ` [PATCH 1/6] ARM: tegra: add tegra_gpio_table and tegra_gpio_config Olof Johansson
2011-02-22  5:55     ` Olof Johansson
     [not found]     ` <1298354117-19097-2-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
2011-02-22 13:13       ` Sergei Shtylyov [this message]
2011-02-22 13:13         ` Sergei Shtylyov
     [not found]         ` <4D63B661.6000407-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2011-02-22 15:31           ` Olof Johansson
2011-02-22 15:31             ` Olof Johansson
2011-02-22 19:18       ` Erik Gilling
2011-02-22 19:18         ` Erik Gilling
     [not found]         ` <AANLkTik9_t0mq07mysO2CcK4ppKAmuPAujownfeWEGL5-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-02-22 19:35           ` Olof Johansson
2011-02-22 19:35             ` Olof Johansson
     [not found]             ` <AANLkTimBh2qDx71+P3QCeWJ0sKS1AzYOUohAdSW=AoeS-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-02-22 23:14               ` Erik Gilling
2011-02-22 23:14                 ` Erik Gilling
2011-02-22 20:46       ` Russell King - ARM Linux
2011-02-22 20:46         ` Russell King - ARM Linux
     [not found]         ` <20110222204654.GD29559-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2011-02-22 21:00           ` Olof Johansson
2011-02-22 21:00             ` Olof Johansson
2011-02-22  5:55   ` [PATCH 2/6] ARM: tegra: common device resources Olof Johansson
2011-02-22  5:55     ` Olof Johansson
2011-02-22  5:55   ` [PATCH 3/6] ARM: tegra: remove stale nvidia atag handler Olof Johansson
2011-02-22  5:55     ` Olof Johansson
     [not found]     ` <1298354117-19097-4-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
2011-02-22 19:39       ` Colin Cross
2011-02-22 19:39         ` Colin Cross
2011-02-22  5:55   ` [PATCH 4/6] ARM: tegra: harmony: register sdhci devices Olof Johansson
2011-02-22  5:55     ` Olof Johansson
     [not found]     ` <1298354117-19097-5-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
2011-02-22  6:59       ` Mike Rapoport
2011-02-22  6:59         ` Mike Rapoport
     [not found]         ` <4D635EC4.2030102-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2011-02-22 15:44           ` Olof Johansson
2011-02-22 15:44             ` Olof Johansson
     [not found]             ` <AANLkTi=mjR6dnxcTxYzTvJK4DgEW7mO+p4TUeu6kq6fn-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-02-23 20:53               ` Grant Likely
2011-02-23 20:53                 ` Grant Likely
2011-02-22 19:40       ` Colin Cross
2011-02-22 19:40         ` Colin Cross
2011-02-22  5:55   ` [PATCH 5/6] ARM: tegra: harmony: fix pinmux for MMC slot Olof Johansson
2011-02-22  5:55     ` Olof Johansson
2011-02-22  5:55   ` [PATCH 6/6] ARM: tegra: add seaboard, wario and kaen boards Olof Johansson
2011-02-22  5:55     ` Olof Johansson
     [not found]     ` <1298354117-19097-7-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
2011-02-22  7:05       ` Colin Cross
2011-02-22  7:05         ` Colin Cross
2011-02-22 20:48       ` Russell King - ARM Linux
2011-02-22 20:48         ` Russell King - ARM Linux
     [not found]         ` <20110222204821.GE29559-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2011-02-22 21:05           ` Olof Johansson
2011-02-22 21:05             ` Olof Johansson
     [not found] <AANLkTikauaANKBpfNHXF5PgCRS4vdbq+eNDF6itU6yHS@mail.gmail.com>
     [not found] ` <AANLkTikauaANKBpfNHXF5PgCRS4vdbq+eNDF6itU6yHS-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-02-21 20:44   ` [PATCH 1/6] ARM: tegra: add tegra_gpio_table and tegra_gpio_config Olof Johansson
     [not found]     ` <AANLkTi=Mg7-hM69EMVSOkS8goU+H53KnDC5q2KASHOtz-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-02-21 22:58       ` Erik Gilling
2011-02-22  5:24         ` Olof Johansson
  -- strict thread matches above, loose matches on Subject: below --
2011-02-21 19:06 [PATCH 0/6] Tegra board patches Olof Johansson
     [not found] ` <1298315206-8887-1-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
2011-02-21 19:06   ` [PATCH 1/6] ARM: tegra: add tegra_gpio_table and tegra_gpio_config Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D63B661.6000407@ru.mvista.com \
    --to=sshtylyov-igf4poytycdqt0dzr+alfa@public.gmane.org \
    --cc=ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
    --cc=konkers-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.