All of lore.kernel.org
 help / color / mirror / Atom feed
From: henry.nestler@gmail.com (Henry Nestler)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] DM9000B: Fix PHY power for network down/up
Date: Tue, 22 Feb 2011 20:58:20 +0100	[thread overview]
Message-ID: <4D64155C.9050407@henry.nestler.mail.gmail.com> (raw)
In-Reply-To: <20110222.102410.260079835.davem@davemloft.net>

Hello David,

On 22.02.2011 19:24, David Miller wrote:
> From: Henry Nestler <henry.nestler@gmail.com>
> Date: Mon, 21 Feb 2011 22:03:31 +0100
> 
>> On 21.02.2011 12:14, Sergei Shtylyov wrote:
>>> On 21-02-2011 0:45, Henry Nestler wrote:
>>>> +	udelay(1000); /* delay needs by DM9000B */
>>>
>>>     Why not mdelay(1)?
>>
>> Because udelay is the base of mdelay.
>> See include/linux/delay.h:31
>>
>> #define mdelay(n) ... udelay((n)*1000)
> 
> He is telling you to use mdelay(1) because it's clearer.  Please do
> so.

Thanks, that text explains it better. No problem. I will resend this patch.

-- 
Henry N.

WARNING: multiple messages have this Message-ID (diff)
From: Henry Nestler <henry.nestler@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: sshtylyov@mvista.com, netdev@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Sergei Shtylyov <sshtylyov@mvista.com>
Subject: Re: [PATCH 2/2] DM9000B: Fix PHY power for network down/up
Date: Tue, 22 Feb 2011 20:58:20 +0100	[thread overview]
Message-ID: <4D64155C.9050407@henry.nestler.mail.gmail.com> (raw)
In-Reply-To: <20110222.102410.260079835.davem@davemloft.net>

Hello David,

On 22.02.2011 19:24, David Miller wrote:
> From: Henry Nestler <henry.nestler@gmail.com>
> Date: Mon, 21 Feb 2011 22:03:31 +0100
> 
>> On 21.02.2011 12:14, Sergei Shtylyov wrote:
>>> On 21-02-2011 0:45, Henry Nestler wrote:
>>>> +	udelay(1000); /* delay needs by DM9000B */
>>>
>>>     Why not mdelay(1)?
>>
>> Because udelay is the base of mdelay.
>> See include/linux/delay.h:31
>>
>> #define mdelay(n) ... udelay((n)*1000)
> 
> He is telling you to use mdelay(1) because it's clearer.  Please do
> so.

Thanks, that text explains it better. No problem. I will resend this patch.

-- 
Henry N.

  reply	other threads:[~2011-02-22 19:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-20 21:45 [PATCH 2/2] DM9000B: Fix PHY power for network down/up Henry Nestler
2011-02-20 21:45 ` Henry Nestler
2011-02-21 11:14 ` Sergei Shtylyov
2011-02-21 11:14   ` Sergei Shtylyov
2011-02-21 21:03   ` Henry Nestler
2011-02-21 21:03     ` Henry Nestler
2011-02-22 12:36     ` Sergei Shtylyov
2011-02-22 12:36       ` Sergei Shtylyov
2011-02-22 18:24     ` David Miller
2011-02-22 18:24       ` David Miller
2011-02-22 19:58       ` Henry Nestler [this message]
2011-02-22 19:58         ` Henry Nestler
2011-02-22 21:29       ` [PATCHv2 " Henry Nestler
2011-02-22 21:29         ` Henry Nestler
2011-02-23 22:30         ` David Miller
2011-02-23 22:30           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D64155C.9050407@henry.nestler.mail.gmail.com \
    --to=henry.nestler@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.