* [refpolicy] [PATCH 9/34]: patch for logging in the sysadm role
@ 2011-02-16 6:07 Guido Trentalancia
2011-02-23 14:19 ` Christopher J. PeBenito
0 siblings, 1 reply; 8+ messages in thread
From: Guido Trentalancia @ 2011-02-16 6:07 UTC (permalink / raw)
To: refpolicy
This patch adds some permissions (through interface calls) needed
by the sysadm role (in particular logging permissions).
diff -pruN refpolicy-git-15022011-new-before-modification/policy/modules/roles/sysadm.te refpolicy-git-15022011-new-modified/policy/modules/roles/sysadm.te
--- refpolicy-git-15022011-new-before-modification/policy/modules/roles/sysadm.te 2011-01-08 19:07:21.214736932 +0100
+++ refpolicy-git-15022011-new-modified/policy/modules/roles/sysadm.te 2011-02-15 23:10:39.681408593 +0100
@@ -34,6 +34,10 @@ ubac_file_exempt(sysadm_t)
ubac_fd_exempt(sysadm_t)
init_exec(sysadm_t)
+init_stream_connect(sysadm_t)
+
+logging_send_audit_msgs(sysadm_t)
+logging_set_tty_audit(sysadm_t)
# Add/remove user home directories
userdom_manage_user_home_dirs(sysadm_t)
^ permalink raw reply [flat|nested] 8+ messages in thread
* [refpolicy] [PATCH 9/34]: patch for logging in the sysadm role
2011-02-16 6:07 [refpolicy] [PATCH 9/34]: patch for logging in the sysadm role Guido Trentalancia
@ 2011-02-23 14:19 ` Christopher J. PeBenito
2011-02-23 19:28 ` Guido Trentalancia
0 siblings, 1 reply; 8+ messages in thread
From: Christopher J. PeBenito @ 2011-02-23 14:19 UTC (permalink / raw)
To: refpolicy
On 02/16/11 01:07, Guido Trentalancia wrote:
> This patch adds some permissions (through interface calls) needed
> by the sysadm role (in particular logging permissions).
>
> diff -pruN refpolicy-git-15022011-new-before-modification/policy/modules/roles/sysadm.te refpolicy-git-15022011-new-modified/policy/modules/roles/sysadm.te
> --- refpolicy-git-15022011-new-before-modification/policy/modules/roles/sysadm.te 2011-01-08 19:07:21.214736932 +0100
> +++ refpolicy-git-15022011-new-modified/policy/modules/roles/sysadm.te 2011-02-15 23:10:39.681408593 +0100
> @@ -34,6 +34,10 @@ ubac_file_exempt(sysadm_t)
> ubac_fd_exempt(sysadm_t)
>
> init_exec(sysadm_t)
> +init_stream_connect(sysadm_t)
Is this on an upstart system? If so these two rules should probably
turn into init_telinit() and also that interface updated to handle
stream sockets.
> +logging_send_audit_msgs(sysadm_t)
Why is this necessary?
> +logging_set_tty_audit(sysadm_t)
>
> # Add/remove user home directories
> userdom_manage_user_home_dirs(sysadm_t)
--
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* [refpolicy] [PATCH 9/34]: patch for logging in the sysadm role
2011-02-23 14:19 ` Christopher J. PeBenito
@ 2011-02-23 19:28 ` Guido Trentalancia
2011-03-01 19:16 ` Christopher J. PeBenito
2011-03-01 20:02 ` Guido Trentalancia
0 siblings, 2 replies; 8+ messages in thread
From: Guido Trentalancia @ 2011-02-23 19:28 UTC (permalink / raw)
To: refpolicy
On Wed, 23/02/2011 at 09.19 -0500, Christopher J. PeBenito wrote:
> On 02/16/11 01:07, Guido Trentalancia wrote:
> > This patch adds some permissions (through interface calls) needed
> > by the sysadm role (in particular logging permissions).
> >
> > diff -pruN refpolicy-git-15022011-new-before-modification/policy/modules/roles/sysadm.te refpolicy-git-15022011-new-modified/policy/modules/roles/sysadm.te
> > --- refpolicy-git-15022011-new-before-modification/policy/modules/roles/sysadm.te 2011-01-08 19:07:21.214736932 +0100
> > +++ refpolicy-git-15022011-new-modified/policy/modules/roles/sysadm.te 2011-02-15 23:10:39.681408593 +0100
> > @@ -34,6 +34,10 @@ ubac_file_exempt(sysadm_t)
> > ubac_fd_exempt(sysadm_t)
> >
> > init_exec(sysadm_t)
> > +init_stream_connect(sysadm_t)
>
> Is this on an upstart system? If so these two rules should probably
> turn into init_telinit() and also that interface updated to handle
> stream sockets.
I confirm it's an upstart system. At the moment I can't check about the
interface that you suggest to use. If it is equivalent, then that's
fine. Is it a way to compact things ?
Do you think we should use the upstart boolean here ?
> > +logging_send_audit_msgs(sysadm_t)
>
> Why is this necessary?
I am not sure. If I can get some more insight on this I will let you
know later on or tomorrow.
> > +logging_set_tty_audit(sysadm_t)
> >
> > # Add/remove user home directories
> > userdom_manage_user_home_dirs(sysadm_t)
Regards,
Guido
^ permalink raw reply [flat|nested] 8+ messages in thread
* [refpolicy] [PATCH 9/34]: patch for logging in the sysadm role
2011-02-23 19:28 ` Guido Trentalancia
@ 2011-03-01 19:16 ` Christopher J. PeBenito
2011-03-01 20:07 ` Guido Trentalancia
2011-03-01 20:02 ` Guido Trentalancia
1 sibling, 1 reply; 8+ messages in thread
From: Christopher J. PeBenito @ 2011-03-01 19:16 UTC (permalink / raw)
To: refpolicy
On 02/23/11 14:28, Guido Trentalancia wrote:
> On Wed, 23/02/2011 at 09.19 -0500, Christopher J. PeBenito wrote:
>> On 02/16/11 01:07, Guido Trentalancia wrote:
>>> This patch adds some permissions (through interface calls) needed
>>> by the sysadm role (in particular logging permissions).
>>>
>>> diff -pruN refpolicy-git-15022011-new-before-modification/policy/modules/roles/sysadm.te refpolicy-git-15022011-new-modified/policy/modules/roles/sysadm.te
>>> --- refpolicy-git-15022011-new-before-modification/policy/modules/roles/sysadm.te 2011-01-08 19:07:21.214736932 +0100
>>> +++ refpolicy-git-15022011-new-modified/policy/modules/roles/sysadm.te 2011-02-15 23:10:39.681408593 +0100
>>> @@ -34,6 +34,10 @@ ubac_file_exempt(sysadm_t)
>>> ubac_fd_exempt(sysadm_t)
>>>
>>> init_exec(sysadm_t)
>>> +init_stream_connect(sysadm_t)
>>
>> Is this on an upstart system? If so these two rules should probably
>> turn into init_telinit() and also that interface updated to handle
>> stream sockets.
>
> I confirm it's an upstart system. At the moment I can't check about the
> interface that you suggest to use. If it is equivalent, then that's
> fine. Is it a way to compact things ?
Its not completely identical, as init_telinit() uses datagram sockets,
and this has stream sockets. But init_telinit() may need to be updated
if upstart changed its socket type.
> Do you think we should use the upstart boolean here ?
No, its in the init_telinit() interface.
--
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* [refpolicy] [PATCH 9/34]: patch for logging in the sysadm role
2011-02-23 19:28 ` Guido Trentalancia
2011-03-01 19:16 ` Christopher J. PeBenito
@ 2011-03-01 20:02 ` Guido Trentalancia
2011-03-01 20:13 ` Daniel J Walsh
1 sibling, 1 reply; 8+ messages in thread
From: Guido Trentalancia @ 2011-03-01 20:02 UTC (permalink / raw)
To: refpolicy
Hello Christopher !
Finally I am getting back on this...
On Wed, 23/02/2011 at 20.28 +0100, Guido Trentalancia wrote:
> On Wed, 23/02/2011 at 09.19 -0500, Christopher J. PeBenito wrote:
> > On 02/16/11 01:07, Guido Trentalancia wrote:
> > > This patch adds some permissions (through interface calls) needed
> > > by the sysadm role (in particular logging permissions).
> > >
> > > diff -pruN refpolicy-git-15022011-new-before-modification/policy/modules/roles/sysadm.te refpolicy-git-15022011-new-modified/policy/modules/roles/sysadm.te
> > > --- refpolicy-git-15022011-new-before-modification/policy/modules/roles/sysadm.te 2011-01-08 19:07:21.214736932 +0100
> > > +++ refpolicy-git-15022011-new-modified/policy/modules/roles/sysadm.te 2011-02-15 23:10:39.681408593 +0100
> > > @@ -34,6 +34,10 @@ ubac_file_exempt(sysadm_t)
> > > ubac_fd_exempt(sysadm_t)
> > >
> > > init_exec(sysadm_t)
> > > +init_stream_connect(sysadm_t)
> >
> > Is this on an upstart system? If so these two rules should probably
> > turn into init_telinit() and also that interface updated to handle
> > stream sockets.
>
> I confirm it's an upstart system. At the moment I can't check about the
> interface that you suggest to use. If it is equivalent, then that's
> fine. Is it a way to compact things ?
>
> Do you think we should use the upstart boolean here ?
>
> > > +logging_send_audit_msgs(sysadm_t)
> >
> > Why is this necessary?
>
> I am not sure. If I can get some more insight on this I will let you
> know later on or tomorrow.
>
> > > +logging_set_tty_audit(sysadm_t)
> > >
> > > # Add/remove user home directories
> > > userdom_manage_user_home_dirs(sysadm_t)
I found the following logs about the logging calls:
type=AVC msg=audit(1295734084.283:24): avc: denied { create } for pid=2677 comm="bash" scontext=root:sysadm_r:sysadm_t:s0-s0:c0.c1023 tcontext=root:sysadm_r:sysadm_t:s0-s0:c0.c1023 tclass=netlink_audit_socket
type=AVC msg=audit(1295734079.261:20): avc: denied { create } for pid=2765 comm="bash" scontext=root:sysadm_r:sysadm_t:s0-s0:c0.c1023 tcontext=root:sysadm_r:sysadm_t:s0-s0:c0.c1023 tclass=netlink_audit_socket
type=AVC msg=audit(1295734079.536:21): avc: denied { create } for pid=2765 comm="bash" scontext=root:sysadm_r:sysadm_t:s0-s0:c0.c1023 tcontext=root:sysadm_r:sysadm_t:s0-s0:c0.c1023 tclass=netlink_audit_socket
type=AVC msg=audit(1295736796.387:81): avc: denied { nlmsg_relay } for pid=2821 comm="bash" scontext=root:sysadm_r:sysadm_t:s0-s0:c0.c1023 tcontext=root:sysadm_r:sysadm_t:s0-s0:c0.c1023 tclass=netlink_audit_socket
type=AVC msg=audit(1294619138.946:19637): avc: denied { create } for pid=5744 comm="bash" scontext=root:sysadm_r:sysadm_t:s0-s0:c0.c1023 tcontext=root:sysadm_r:sysadm_t:s0-s0:c0.c1023 tclass=netlink_audit_socket
type=AVC msg=audit(1294683721.351:42): avc: denied { write } for pid=2670 comm="bash" scontext=root:sysadm_r:sysadm_t:s0-s0:c0.c1023 tcontext=root:sysadm_r:sysadm_t:s0-s0:c0.c1023 tclass=netlink_audit_socket
>From the sysadm_t context, I bet this is something interactive from the
console. And I told you already that there are a few problems from the
console. It needs to be checked carefully as soon as you have finished
to evaluate and commit the patches that I have already submitted.
Regards,
Guido
^ permalink raw reply [flat|nested] 8+ messages in thread
* [refpolicy] [PATCH 9/34]: patch for logging in the sysadm role
2011-03-01 19:16 ` Christopher J. PeBenito
@ 2011-03-01 20:07 ` Guido Trentalancia
2011-03-04 13:15 ` Christopher J. PeBenito
0 siblings, 1 reply; 8+ messages in thread
From: Guido Trentalancia @ 2011-03-01 20:07 UTC (permalink / raw)
To: refpolicy
On Tue, 01/03/2011 at 14.16 -0500, Christopher J. PeBenito wrote:
> On 02/23/11 14:28, Guido Trentalancia wrote:
> > On Wed, 23/02/2011 at 09.19 -0500, Christopher J. PeBenito wrote:
> >> On 02/16/11 01:07, Guido Trentalancia wrote:
> >>> This patch adds some permissions (through interface calls) needed
> >>> by the sysadm role (in particular logging permissions).
> >>>
> >>> diff -pruN refpolicy-git-15022011-new-before-modification/policy/modules/roles/sysadm.te refpolicy-git-15022011-new-modified/policy/modules/roles/sysadm.te
> >>> --- refpolicy-git-15022011-new-before-modification/policy/modules/roles/sysadm.te 2011-01-08 19:07:21.214736932 +0100
> >>> +++ refpolicy-git-15022011-new-modified/policy/modules/roles/sysadm.te 2011-02-15 23:10:39.681408593 +0100
> >>> @@ -34,6 +34,10 @@ ubac_file_exempt(sysadm_t)
> >>> ubac_fd_exempt(sysadm_t)
> >>>
> >>> init_exec(sysadm_t)
> >>> +init_stream_connect(sysadm_t)
> >>
> >> Is this on an upstart system? If so these two rules should probably
> >> turn into init_telinit() and also that interface updated to handle
> >> stream sockets.
> >
> > I confirm it's an upstart system. At the moment I can't check about the
> > interface that you suggest to use. If it is equivalent, then that's
> > fine. Is it a way to compact things ?
>
> Its not completely identical, as init_telinit() uses datagram sockets,
> and this has stream sockets. But init_telinit() may need to be updated
> if upstart changed its socket type.
>
> > Do you think we should use the upstart boolean here ?
>
> No, its in the init_telinit() interface.
That's fine to me, good idea ! As soon as you commit, I will test.
Regards,
Guido
^ permalink raw reply [flat|nested] 8+ messages in thread
* [refpolicy] [PATCH 9/34]: patch for logging in the sysadm role
2011-03-01 20:02 ` Guido Trentalancia
@ 2011-03-01 20:13 ` Daniel J Walsh
0 siblings, 0 replies; 8+ messages in thread
From: Daniel J Walsh @ 2011-03-01 20:13 UTC (permalink / raw)
To: refpolicy
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 03/01/2011 03:02 PM, Guido Trentalancia wrote:
> Hello Christopher !
>
> Finally I am getting back on this...
>
> On Wed, 23/02/2011 at 20.28 +0100, Guido Trentalancia wrote:
>> On Wed, 23/02/2011 at 09.19 -0500, Christopher J. PeBenito wrote:
>>> On 02/16/11 01:07, Guido Trentalancia wrote:
>>>> This patch adds some permissions (through interface calls) needed
>>>> by the sysadm role (in particular logging permissions).
>>>>
>>>> diff -pruN refpolicy-git-15022011-new-before-modification/policy/modules/roles/sysadm.te refpolicy-git-15022011-new-modified/policy/modules/roles/sysadm.te
>>>> --- refpolicy-git-15022011-new-before-modification/policy/modules/roles/sysadm.te 2011-01-08 19:07:21.214736932 +0100
>>>> +++ refpolicy-git-15022011-new-modified/policy/modules/roles/sysadm.te 2011-02-15 23:10:39.681408593 +0100
>>>> @@ -34,6 +34,10 @@ ubac_file_exempt(sysadm_t)
>>>> ubac_fd_exempt(sysadm_t)
>>>>
>>>> init_exec(sysadm_t)
>>>> +init_stream_connect(sysadm_t)
>>>
>>> Is this on an upstart system? If so these two rules should probably
>>> turn into init_telinit() and also that interface updated to handle
>>> stream sockets.
>>
>> I confirm it's an upstart system. At the moment I can't check about the
>> interface that you suggest to use. If it is equivalent, then that's
>> fine. Is it a way to compact things ?
>>
>> Do you think we should use the upstart boolean here ?
>>
>>>> +logging_send_audit_msgs(sysadm_t)
>>>
>>> Why is this necessary?
>>
>> I am not sure. If I can get some more insight on this I will let you
>> know later on or tomorrow.
>>
>>>> +logging_set_tty_audit(sysadm_t)
>>>>
>>>> # Add/remove user home directories
>>>> userdom_manage_user_home_dirs(sysadm_t)
>
> I found the following logs about the logging calls:
>
> type=AVC msg=audit(1295734084.283:24): avc: denied { create } for pid=2677 comm="bash" scontext=root:sysadm_r:sysadm_t:s0-s0:c0.c1023 tcontext=root:sysadm_r:sysadm_t:s0-s0:c0.c1023 tclass=netlink_audit_socket
> type=AVC msg=audit(1295734079.261:20): avc: denied { create } for pid=2765 comm="bash" scontext=root:sysadm_r:sysadm_t:s0-s0:c0.c1023 tcontext=root:sysadm_r:sysadm_t:s0-s0:c0.c1023 tclass=netlink_audit_socket
> type=AVC msg=audit(1295734079.536:21): avc: denied { create } for pid=2765 comm="bash" scontext=root:sysadm_r:sysadm_t:s0-s0:c0.c1023 tcontext=root:sysadm_r:sysadm_t:s0-s0:c0.c1023 tclass=netlink_audit_socket
> type=AVC msg=audit(1295736796.387:81): avc: denied { nlmsg_relay } for pid=2821 comm="bash" scontext=root:sysadm_r:sysadm_t:s0-s0:c0.c1023 tcontext=root:sysadm_r:sysadm_t:s0-s0:c0.c1023 tclass=netlink_audit_socket
> type=AVC msg=audit(1294619138.946:19637): avc: denied { create } for pid=5744 comm="bash" scontext=root:sysadm_r:sysadm_t:s0-s0:c0.c1023 tcontext=root:sysadm_r:sysadm_t:s0-s0:c0.c1023 tclass=netlink_audit_socket
> type=AVC msg=audit(1294683721.351:42): avc: denied { write } for pid=2670 comm="bash" scontext=root:sysadm_r:sysadm_t:s0-s0:c0.c1023 tcontext=root:sysadm_r:sysadm_t:s0-s0:c0.c1023 tclass=netlink_audit_socket
>
>>From the sysadm_t context, I bet this is something interactive from the
> console. And I told you already that there are a few problems from the
> console. It needs to be checked carefully as soon as you have finished
> to evaluate and commit the patches that I have already submitted.
>
> Regards,
>
> Guido
>
> _______________________________________________
> refpolicy mailing list
> refpolicy at oss.tresys.com
> http://oss.tresys.com/mailman/listinfo/refpolicy
bash has builtin audit logging.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAk1tU10ACgkQrlYvE4MpobMVzQCdGJSFxMEHq9vHvROwxS1JBSwP
isMAn24kv49S3agafRGkJCP09Jn4cPi0
=hWTl
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 8+ messages in thread
* [refpolicy] [PATCH 9/34]: patch for logging in the sysadm role
2011-03-01 20:07 ` Guido Trentalancia
@ 2011-03-04 13:15 ` Christopher J. PeBenito
0 siblings, 0 replies; 8+ messages in thread
From: Christopher J. PeBenito @ 2011-03-04 13:15 UTC (permalink / raw)
To: refpolicy
On 03/01/11 15:07, Guido Trentalancia wrote:
> On Tue, 01/03/2011 at 14.16 -0500, Christopher J. PeBenito wrote:
>> On 02/23/11 14:28, Guido Trentalancia wrote:
>>> On Wed, 23/02/2011 at 09.19 -0500, Christopher J. PeBenito wrote:
>>>> On 02/16/11 01:07, Guido Trentalancia wrote:
>>>>> This patch adds some permissions (through interface calls) needed
>>>>> by the sysadm role (in particular logging permissions).
>>>>>
>>>>> diff -pruN refpolicy-git-15022011-new-before-modification/policy/modules/roles/sysadm.te refpolicy-git-15022011-new-modified/policy/modules/roles/sysadm.te
>>>>> --- refpolicy-git-15022011-new-before-modification/policy/modules/roles/sysadm.te 2011-01-08 19:07:21.214736932 +0100
>>>>> +++ refpolicy-git-15022011-new-modified/policy/modules/roles/sysadm.te 2011-02-15 23:10:39.681408593 +0100
>>>>> @@ -34,6 +34,10 @@ ubac_file_exempt(sysadm_t)
>>>>> ubac_fd_exempt(sysadm_t)
>>>>>
>>>>> init_exec(sysadm_t)
>>>>> +init_stream_connect(sysadm_t)
>>>>
>>>> Is this on an upstart system? If so these two rules should probably
>>>> turn into init_telinit() and also that interface updated to handle
>>>> stream sockets.
>>>
>>> I confirm it's an upstart system. At the moment I can't check about the
>>> interface that you suggest to use. If it is equivalent, then that's
>>> fine. Is it a way to compact things ?
>>
>> Its not completely identical, as init_telinit() uses datagram sockets,
>> and this has stream sockets. But init_telinit() may need to be updated
>> if upstart changed its socket type.
>>
>>> Do you think we should use the upstart boolean here ?
>>
>> No, its in the init_telinit() interface.
>
> That's fine to me, good idea ! As soon as you commit, I will test.
I think you misunderstand. I'm not going to commit it until you can
confirm this is telinit (which also happens when you run shutdown).
--
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-03-04 13:15 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-16 6:07 [refpolicy] [PATCH 9/34]: patch for logging in the sysadm role Guido Trentalancia
2011-02-23 14:19 ` Christopher J. PeBenito
2011-02-23 19:28 ` Guido Trentalancia
2011-03-01 19:16 ` Christopher J. PeBenito
2011-03-01 20:07 ` Guido Trentalancia
2011-03-04 13:15 ` Christopher J. PeBenito
2011-03-01 20:02 ` Guido Trentalancia
2011-03-01 20:13 ` Daniel J Walsh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.