[PATCH 0/2] Disable command echo for hfp emulators

[PATCH 0/2] Disable command echo for hfp emulators

[=?unknown-8bit?q?Fr=C3=A9d=C3=A9ric?= Dalleau]

[-- Attachment #1: Type: text/plain, Size: 383 bytes --]

This is the default asked by HSP and HFP specifications, which
is the opposite of what v250 is asking.

Frédéric Dalleau (2):
  gatchat: Add function to enable/disable echo
  emulator: Disable echo for hfp emulators

 gatchat/gatserver.c |   10 ++++++++++
 gatchat/gatserver.h |    1 +
 src/emulator.c      |    2 ++
 3 files changed, 13 insertions(+), 0 deletions(-)

[PATCH 1/2] gatchat: Add function to enable/disable echo

[=?unknown-8bit?q?Fr=C3=A9d=C3=A9ric?= Dalleau]

[-- Attachment #1: Type: text/plain, Size: 1141 bytes --]

---
 gatchat/gatserver.c |   10 ++++++++++
 gatchat/gatserver.h |    1 +
 2 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/gatchat/gatserver.c b/gatchat/gatserver.c
index b092a68..d9b1592 100644
--- a/gatchat/gatserver.c
+++ b/gatchat/gatserver.c
@@ -1235,6 +1235,16 @@ gboolean g_at_server_shutdown(GAtServer *server)
 	return TRUE;
 }
 
+gboolean g_at_server_set_echo(GAtServer *server, gboolean echo)
+{
+	if (server == NULL)
+		return FALSE;
+
+	server->v250.echo = echo;
+
+	return TRUE;
+}
+
 gboolean g_at_server_set_disconnect_function(GAtServer *server,
 						GAtDisconnectFunc disconnect,
 						gpointer user_data)
diff --git a/gatchat/gatserver.h b/gatchat/gatserver.h
index a42c8b5..bb0ae84 100644
--- a/gatchat/gatserver.h
+++ b/gatchat/gatserver.h
@@ -80,6 +80,7 @@ void g_at_server_unref(GAtServer *server);
 
 gboolean g_at_server_shutdown(GAtServer *server);
 
+gboolean g_at_server_set_echo(GAtServer *server, gboolean echo);
 gboolean g_at_server_set_disconnect_function(GAtServer *server,
 					GAtDisconnectFunc disconnect,
 					gpointer user_data);
-- 
1.7.1

[PATCH 2/2] emulator: Disable echo for hfp emulators

[=?unknown-8bit?q?Fr=C3=A9d=C3=A9ric?= Dalleau]

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

---
 src/emulator.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/emulator.c b/src/emulator.c
index dcfd296..7007882 100644
--- a/src/emulator.c
+++ b/src/emulator.c
@@ -203,6 +203,8 @@ void ofono_emulator_register(struct ofono_emulator *em, int fd)
 
 	if (em->type == OFONO_EMULATOR_TYPE_DUN)
 		g_at_server_register(em->server, "D", dial_cb, em, NULL);
+	else if (em->type == OFONO_EMULATOR_TYPE_HFP)
+		g_at_server_set_echo(em->server, FALSE);
 }
 
 static void emulator_remove(struct ofono_atom *atom)
-- 
1.7.1

Re: [PATCH 0/2] Disable command echo for hfp emulators

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 535 bytes --]

Hi Frédéric,

On 02/23/2011 07:19 AM, Frédéric Dalleau wrote:
> This is the default asked by HSP and HFP specifications, which
> is the opposite of what v250 is asking.
> 
> Frédéric Dalleau (2):
>   gatchat: Add function to enable/disable echo
>   emulator: Disable echo for hfp emulators
> 
>  gatchat/gatserver.c |   10 ++++++++++
>  gatchat/gatserver.h |    1 +
>  src/emulator.c      |    2 ++
>  3 files changed, 13 insertions(+), 0 deletions(-)

Both patches have been applied, thanks.

Regards,
-Denis