From: Zdenek Kabelac <zkabelac@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH 1/3] Refactor vg allocation code
Date: Wed, 23 Feb 2011 19:40:16 +0100 [thread overview]
Message-ID: <4D655490.8040102@redhat.com> (raw)
In-Reply-To: <20110223164836.GA3626@agk-dp.fab.redhat.com>
Dne 23.2.2011 17:48, Alasdair G Kergon napsal(a):
> On Wed, Feb 23, 2011 at 02:52:15PM +0100, Zdenek Kabelac wrote:
>> Usure about naming strategy - we use i.e. alloc_lv,
>> but most the new function have now operation prefix.
>
> alloc_vg for now...because it's paired with free_vg and vg_free is already used
> for something else:)
>
>> Also the location after Dave's refactoring patches is unclear.
>
> vg.c - move free_vg there too.
>
>> + if (!(vgmem = dm_pool_create("lvm2 vg_handle", VG_MEMPOOL_CHUNK)) ||
>
> The code is now shared - "alloc_vg" will have to do, or if that makes
> the log too hard to understand, pass the existing strings into the function.
Ok - I'll add string arg to alloc_vg() for debug purposes.
Zdenek
next prev parent reply other threads:[~2011-02-23 18:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 13:52 [PATCH 0/3] Share vg metadata for read only Zdenek Kabelac
2011-02-23 13:52 ` [PATCH 1/3] Refactor vg allocation code Zdenek Kabelac
2011-02-23 16:48 ` Alasdair G Kergon
2011-02-23 18:40 ` Zdenek Kabelac [this message]
2011-02-23 13:52 ` [PATCH 2/3] Add VG refcount and cache created VG structure Zdenek Kabelac
2011-02-23 13:52 ` [PATCH 3/3] Destroy 'fic' memory in error path Zdenek Kabelac
2011-02-23 14:14 ` Peter Rajnoha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D655490.8040102@redhat.com \
--to=zkabelac@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.