[PATCH] groff - fix do_install failure

[PATCH] groff - fix do_install failure

[Mike Westerhof]

Bitbaking groff fails in the do_install step, complaining that img/pic* does
not exist.  Normally, these files would be created by groff itself during the
build process, but since we are cross-compiling, the old recipe replaces the
invocation of groff and troff with echo commands.  However, echo does not
create the output files, which eventually results in the do_install failure.

This patch makes groff dependent on groff-native, and instead of using echo,
it instructs the build process to use the staged groff binaries.

Signed-off-by: Mike Westerhof <mike@mwester.net>

---
diff --git a/recipes/groff/groff_1.20.1.bb b/recipes/groff/groff_1.20.1.bb
index 6ea87dc..5869ff7 100644
--- a/recipes/groff/groff_1.20.1.bb
+++ b/recipes/groff/groff_1.20.1.bb
@@ -1,7 +1,10 @@
 DESCRIPTION = "GNU roff"
 SECTION = "base"
 LICENSE = "GPL"
-PR = "r2"
+PR = "r3"
+
+DEPENDS = "groff-native"
+DEPENDS_virtclass-native = ""

 SRC_URI = "http://ftp.gnu.org/gnu/groff/groff-${PV}.tar.gz \
           "
@@ -15,10 +18,10 @@ PARALLEL_MAKE = ""
 do_configure_prepend(){
        if [ "${BUILD_SYS}" != "${HOST_SYS}" ]; then
                sed -i \
-                   -e '/^GROFFBIN=/s:=.*:=echo:' \
-                   -e '/^TROFFBIN=/s:=.*:=echo:' \
-                   -e '/^GROFF_BIN_PATH=/s:=.*:=:' \
-                   -e '/^GROFF_BIN_DIR=/s:=.*:=:' \
+                   -e '/^GROFFBIN=/s:=.*:=${STAGING_BINDIR_NATIVE}/groff:' \
+                   -e '/^TROFFBIN=/s:=.*:=${STAGING_BINDIR_NATIVE}/troff:' \
+                   -e '/^GROFF_BIN_PATH=/s:=.*:=${STAGING_BINDIR_NATIVE}:' \
+                   -e '/^GROFF_BIN_DIR=/s:=.*:=${STAGING_BINDIR_NATIVE}:' \
                    ${S}/contrib/*/Makefile.sub \
                    ${S}/doc/Makefile.in \
                    ${S}/doc/Makefile.sub

Re: [PATCH] groff - fix do_install failure

[Khem Raj]

On Wed, Feb 23, 2011 at 10:44 AM, Mike Westerhof <mike@mwester.net> wrote:
> Bitbaking groff fails in the do_install step, complaining that img/pic* does
> not exist.  Normally, these files would be created by groff itself during the
> build process, but since we are cross-compiling, the old recipe replaces the
> invocation of groff and troff with echo commands.  However, echo does not
> create the output files, which eventually results in the do_install failure.
>
> This patch makes groff dependent on groff-native, and instead of using echo,
> it instructs the build process to use the staged groff binaries.
>
> Signed-off-by: Mike Westerhof <mike@mwester.net>

looks good.

Acked-by: Khem Raj <raj.khem@gmail.com>

>
> ---
> diff --git a/recipes/groff/groff_1.20.1.bb b/recipes/groff/groff_1.20.1.bb
> index 6ea87dc..5869ff7 100644
> --- a/recipes/groff/groff_1.20.1.bb
> +++ b/recipes/groff/groff_1.20.1.bb
> @@ -1,7 +1,10 @@
>  DESCRIPTION = "GNU roff"
>  SECTION = "base"
>  LICENSE = "GPL"
> -PR = "r2"
> +PR = "r3"
> +
> +DEPENDS = "groff-native"
> +DEPENDS_virtclass-native = ""
>
>  SRC_URI = "http://ftp.gnu.org/gnu/groff/groff-${PV}.tar.gz \
>           "
> @@ -15,10 +18,10 @@ PARALLEL_MAKE = ""
>  do_configure_prepend(){
>        if [ "${BUILD_SYS}" != "${HOST_SYS}" ]; then
>                sed -i \
> -                   -e '/^GROFFBIN=/s:=.*:=echo:' \
> -                   -e '/^TROFFBIN=/s:=.*:=echo:' \
> -                   -e '/^GROFF_BIN_PATH=/s:=.*:=:' \
> -                   -e '/^GROFF_BIN_DIR=/s:=.*:=:' \
> +                   -e '/^GROFFBIN=/s:=.*:=${STAGING_BINDIR_NATIVE}/groff:' \
> +                   -e '/^TROFFBIN=/s:=.*:=${STAGING_BINDIR_NATIVE}/troff:' \
> +                   -e '/^GROFF_BIN_PATH=/s:=.*:=${STAGING_BINDIR_NATIVE}:' \
> +                   -e '/^GROFF_BIN_DIR=/s:=.*:=${STAGING_BINDIR_NATIVE}:' \
>                    ${S}/contrib/*/Makefile.sub \
>                    ${S}/doc/Makefile.in \
>                    ${S}/doc/Makefile.sub
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>