From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/2] PRUSS UIO driver support
Date: Wed, 23 Feb 2011 23:49:49 +0300 [thread overview]
Message-ID: <4D6572ED.9020805@mvista.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1102232057260.2701@localhost6.localdomain6>
Hello.
On 23-02-2011 23:25, Thomas Gleixner wrote:
>> + prussio_virt_addr =
>> + ioremap(regs_prussio->start,
>> + regs_prussio->end - regs_prussio->start + 1);
> Either make those variable names shorter or do:
> len = regs_prussio->end - regs_prussio->start + 1;
Or even:
len = resource_size(regs_prussio);
> prussio_virt_addr = ioremap(regs_prussio->start, len);
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Pratheesh Gangadhar <pratheesh@ti.com>,
davinci-linux-open-source@linux.davincidsp.com,
amit.chatterjee@ti.com, gregkh@suse.de,
linux-kernel@vger.kernel.org, hjk@hansjkoch.de,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/2] PRUSS UIO driver support
Date: Wed, 23 Feb 2011 23:49:49 +0300 [thread overview]
Message-ID: <4D6572ED.9020805@mvista.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1102232057260.2701@localhost6.localdomain6>
Hello.
On 23-02-2011 23:25, Thomas Gleixner wrote:
>> + prussio_virt_addr =
>> + ioremap(regs_prussio->start,
>> + regs_prussio->end - regs_prussio->start + 1);
> Either make those variable names shorter or do:
> len = regs_prussio->end - regs_prussio->start + 1;
Or even:
len = resource_size(regs_prussio);
> prussio_virt_addr = ioremap(regs_prussio->start, len);
WBR, Sergei
next prev parent reply other threads:[~2011-02-23 20:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 13:52 [PATCH v3 0/2] Add PRUSS UIO driver support Pratheesh Gangadhar
2011-02-23 13:52 ` Pratheesh Gangadhar
2011-02-23 13:52 ` [PATCH v3 1/2] " Pratheesh Gangadhar
2011-02-23 13:52 ` Pratheesh Gangadhar
2011-02-23 13:52 ` [PATCH v3 2/2] Defines DA850/AM18xx/OMAPL1-38 SOC resources used by PRUSS UIO driver Pratheesh Gangadhar
2011-02-23 13:52 ` Pratheesh Gangadhar
2011-02-23 17:37 ` [PATCH v3 1/2] PRUSS UIO driver support Hans J. Koch
2011-02-23 17:37 ` Hans J. Koch
2011-02-24 13:56 ` TK, Pratheesh Gangadhar
2011-02-24 13:56 ` TK, Pratheesh Gangadhar
2011-02-23 20:25 ` Thomas Gleixner
2011-02-23 20:25 ` Thomas Gleixner
2011-02-23 20:49 ` Sergei Shtylyov [this message]
2011-02-23 20:49 ` Sergei Shtylyov
2011-02-23 20:54 ` Thomas Gleixner
2011-02-23 20:54 ` Thomas Gleixner
2011-02-24 13:55 ` TK, Pratheesh Gangadhar
2011-02-24 13:55 ` TK, Pratheesh Gangadhar
2011-02-24 13:54 ` TK, Pratheesh Gangadhar
2011-02-24 13:54 ` TK, Pratheesh Gangadhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6572ED.9020805@mvista.com \
--to=sshtylyov@mvista.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.