* [LTP] [POSIX][PATCH]Fix bug of script implemented tests @ 2011-02-23 7:02 Bian Naimeng 2011-02-23 7:48 ` Garrett Cooper 0 siblings, 1 reply; 4+ messages in thread From: Bian Naimeng @ 2011-02-23 7:02 UTC (permalink / raw) To: Garrett Cooper; +Cc: ltp-list Tests implemented by script will fail, because they try to invoke a inexistent binary file. [root@Linux sigaddset]# ./1-1.sh ./1-1.sh: line 20: conformance/interfaces/sigaddset/1-core-buildonly.test: No such file or directory It's a widespread problem on the latest LTP. Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com> --- .../conformance/interfaces/sigaddset/1-1.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/testcases/open_posix_testsuite/conformance/interfaces/sigaddset/1-1.sh b/testcases/open_posix_testsuite/conformance/interfaces/sigaddset/1-1.sh index e12c69e..e77ed54 100755 --- a/testcases/open_posix_testsuite/conformance/interfaces/sigaddset/1-1.sh +++ b/testcases/open_posix_testsuite/conformance/interfaces/sigaddset/1-1.sh @@ -17,4 +17,4 @@ # Calling 1-core-buildonly.test with a 0 parameter initializes to an # empty set. -conformance/interfaces/sigaddset/1-core-buildonly.test 0 +./1-core 0 -- 1.7.0.4 ------------------------------------------------------------------------------ Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [LTP] [POSIX][PATCH]Fix bug of script implemented tests 2011-02-23 7:02 [LTP] [POSIX][PATCH]Fix bug of script implemented tests Bian Naimeng @ 2011-02-23 7:48 ` Garrett Cooper 2011-02-24 1:14 ` Peng Haitao 0 siblings, 1 reply; 4+ messages in thread From: Garrett Cooper @ 2011-02-23 7:48 UTC (permalink / raw) To: Bian Naimeng; +Cc: ltp-list On Tue, Feb 22, 2011 at 11:02 PM, Bian Naimeng <biannm@cn.fujitsu.com> wrote: > Tests implemented by script will fail, because they try to invoke a inexistent binary file. > > [root@Linux sigaddset]# ./1-1.sh > ./1-1.sh: line 20: conformance/interfaces/sigaddset/1-core-buildonly.test: No such file or directory > > It's a widespread problem on the latest LTP. It's a problem, but it isn't a disaster (28 scripts in all is small in comparison to the number of C tests). This sed fixed things on FreeBSD at least, but it isn't that hard to convert over to the GNU/sed format of calling sed though: $ find [cms]* -name '*.sh' | xargs grep -l buildonly | xargs -J % sed -i .bk -E -e 's,^[cfs].+[^/]/(.+)\.test,\./\1,g' -e 's,\-buildonly\.test,,g' % I've committed the end result after verifying that git diff's output was sane. Thanks, -Garrett ------------------------------------------------------------------------------ Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [LTP] [POSIX][PATCH]Fix bug of script implemented tests 2011-02-23 7:48 ` Garrett Cooper @ 2011-02-24 1:14 ` Peng Haitao 2011-02-24 5:27 ` Garrett Cooper 0 siblings, 1 reply; 4+ messages in thread From: Peng Haitao @ 2011-02-24 1:14 UTC (permalink / raw) To: Garrett Cooper; +Cc: ltp-list Hi Garrett, Garrett Cooper said the following on 2011-2-23 15:48: > $ find [cms]* -name '*.sh' | xargs grep -l buildonly | xargs -J % sed > -i .bk -E -e 's,^[cfs].+[^/]/(.+)\.test,\./\1,g' -e > 's,\-buildonly\.test,,g' % > > I've committed the end result after verifying that git diff's output was sane. > There are four cases, and they have same problem. The following patch can fix the bug. Signed-off-by: Peng Haitao <penght@cn.fujitsu.com> --- .../conformance/interfaces/sigaddset/4-1.sh | 2 +- .../conformance/interfaces/sigaddset/4-2.sh | 2 +- .../conformance/interfaces/sigaddset/4-3.sh | 2 +- .../conformance/interfaces/sigaddset/4-4.sh | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/testcases/open_posix_testsuite/conformance/interfaces/sigaddset/4-1.sh b/testcases/open_posix_testsuite/conformance/interfaces/sigaddset/4-1.sh index cb29ca9..32dc8a9 100755 --- a/testcases/open_posix_testsuite/conformance/interfaces/sigaddset/4-1.sh +++ b/testcases/open_posix_testsuite/conformance/interfaces/sigaddset/4-1.sh @@ -9,4 +9,4 @@ # Test various methods of adding invalid signals to sigaddset(). # -conformance/interfaces/sigaddset/4-core.run-test 1 +./4-core 1 diff --git a/testcases/open_posix_testsuite/conformance/interfaces/sigaddset/4-2.sh b/testcases/open_posix_testsuite/conformance/interfaces/sigaddset/4-2.sh index 5ab480d..708fe1a 100755 --- a/testcases/open_posix_testsuite/conformance/interfaces/sigaddset/4-2.sh +++ b/testcases/open_posix_testsuite/conformance/interfaces/sigaddset/4-2.sh @@ -10,4 +10,4 @@ # Test various methods of adding invalid signals to sigaddset(). # -conformance/interfaces/sigaddset/4-core.run-test 2 +./4-core 2 diff --git a/testcases/open_posix_testsuite/conformance/interfaces/sigaddset/4-3.sh b/testcases/open_posix_testsuite/conformance/interfaces/sigaddset/4-3.sh index 644512f..ad4fee1 100755 --- a/testcases/open_posix_testsuite/conformance/interfaces/sigaddset/4-3.sh +++ b/testcases/open_posix_testsuite/conformance/interfaces/sigaddset/4-3.sh @@ -9,4 +9,4 @@ # Test various methods of adding invalid signals to sigaddset(). # -conformance/interfaces/sigaddset/4-core.run-test 3 +./4-core 3 diff --git a/testcases/open_posix_testsuite/conformance/interfaces/sigaddset/4-4.sh b/testcases/open_posix_testsuite/conformance/interfaces/sigaddset/4-4.sh index ca8523f..c33d8fb 100755 --- a/testcases/open_posix_testsuite/conformance/interfaces/sigaddset/4-4.sh +++ b/testcases/open_posix_testsuite/conformance/interfaces/sigaddset/4-4.sh @@ -9,4 +9,4 @@ # Test various methods of adding invalid signals to sigaddset(). # -conformance/interfaces/sigaddset/4-core.run-test 4 +./4-core 4 -- 1.7.1 -- Best Regards, Peng Haitao ------------------------------------------------------------------------------ Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [LTP] [POSIX][PATCH]Fix bug of script implemented tests 2011-02-24 1:14 ` Peng Haitao @ 2011-02-24 5:27 ` Garrett Cooper 0 siblings, 0 replies; 4+ messages in thread From: Garrett Cooper @ 2011-02-24 5:27 UTC (permalink / raw) To: Peng Haitao; +Cc: ltp-list On Wed, Feb 23, 2011 at 5:14 PM, Peng Haitao <penght@cn.fujitsu.com> wrote: > Hi Garrett, > > Garrett Cooper said the following on 2011-2-23 15:48: >> $ find [cms]* -name '*.sh' | xargs grep -l buildonly | xargs -J % sed >> -i .bk -E -e 's,^[cfs].+[^/]/(.+)\.test,\./\1,g' -e >> 's,\-buildonly\.test,,g' % >> >> I've committed the end result after verifying that git diff's output was sane. >> > > There are four cases, and they have same problem. > The following patch can fix the bug. Committed -- thanks! -Garrett ------------------------------------------------------------------------------ Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-02-24 5:27 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-02-23 7:02 [LTP] [POSIX][PATCH]Fix bug of script implemented tests Bian Naimeng 2011-02-23 7:48 ` Garrett Cooper 2011-02-24 1:14 ` Peng Haitao 2011-02-24 5:27 ` Garrett Cooper
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.