From: Andre Przywara <andre.przywara@amd.com>
To: Juergen Gross <juergen.gross@ts.fujitsu.com>,
Keir Fraser <keir.fraser@eu.citrix.com>
Cc: Dunlap <George.Dunlap@eu.citrix.com>,
"xen-devel@lists.xensource.com"
<xen-devel@lists.xensource.com>George, "Diestelhorst,
Stephan" <Stephan.Diestelhorst@amd.com>
Subject: Re: [PATCH] Avoid race when moving cpu between cpupools
Date: Thu, 24 Feb 2011 15:08:56 +0100 [thread overview]
Message-ID: <4D666678.1000301@amd.com> (raw)
In-Reply-To: <5485071c8b0a6a49f65b.1298541625@nehalem1>
Juergen Gross wrote:
> Moving cpus between cpupools is done under the schedule lock of the moved cpu.
> When checking a cpu being member of a cpupool this must be done with the lock
> of that cpu being held.
I have reviewed and tested the patch. It fixes my problem. My script has
been running for several hundred iterations without any Xen crash,
whereas without the patch the hypervisor crashed mostly at the second
iteration.
Thanks Juergen and George for the persistent work!
> Hot-unplugging of physical cpus might encounter the same problems, but this
> should happen only very rarely.
>
> Signed-off-by: juergen.gross@ts.fujitsu.com
Acked-by: Andre Przywara <andre.przywara@amd.com>
Keir, please apply for 4.1.0.
Regards,
Andre.
--
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
next prev parent reply other threads:[~2011-02-24 14:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-24 10:00 [PATCH] Avoid race when moving cpu between cpupools Juergen Gross
2011-02-24 14:08 ` Andre Przywara [this message]
2011-02-24 14:33 ` George Dunlap
2011-02-25 14:25 ` Andre Przywara
2011-02-25 14:36 ` Keir Fraser
2011-02-28 9:29 ` Juergen Gross
2011-02-28 10:00 ` Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D666678.1000301@amd.com \
--to=andre.przywara@amd.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=juergen.gross@ts.fujitsu.com \
--cc=keir.fraser@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.