[PATCH] common: '+' is not valid phone number anymore

[PATCH] common: '+' is not valid phone number anymore

[Paavo Leinonen]

[-- Attachment #1: Type: text/plain, Size: 771 bytes --]

Reject phone number if it contains only plus sign.
---
Hi,

Originally this issue was found while testing Call Forwarding. If 
user would set call fowarding to number '+', oFono actually erased 
existing CF settings. Fix was made to common.c as I don't think plus
should be considered as a valid phone number in any case.

BR,
Paavo

 src/common.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/src/common.c b/src/common.c
index 247fff0..520360c 100644
--- a/src/common.c
+++ b/src/common.c
@@ -246,6 +246,9 @@ gboolean valid_number_format(const char *number, int length)
 	if (number[0] == '+')
 		begin = 1;
 
+	if (begin == len)
+		return FALSE;
+
 	if ((len - begin) > length)
 		return FALSE;
 
-- 
1.7.1

Re: [PATCH] common: '+' is not valid phone number anymore

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

Hi Paavo,

On 02/24/2011 02:33 AM, Paavo Leinonen wrote:
> Reject phone number if it contains only plus sign.
> ---
> Hi,
> 
> Originally this issue was found while testing Call Forwarding. If 
> user would set call fowarding to number '+', oFono actually erased 
> existing CF settings. Fix was made to common.c as I don't think plus
> should be considered as a valid phone number in any case.
> 
> BR,
> Paavo
> 
>  src/common.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 

Patch has been applied, thanks.

Regards,
-Denis