From: Josh Durgin <josh.durgin@dreamhost.com>
To: Colin McCabe <cmccabe@alumni.cmu.edu>
Cc: ceph-devel@vger.kernel.org
Subject: Re: C++ api for librados 0.25
Date: Thu, 24 Feb 2011 10:02:48 -0800 [thread overview]
Message-ID: <4D669D48.6060202@dreamhost.com> (raw)
In-Reply-To: <AANLkTin3gXaBv1y+MPEvJVxNYVhtJdkqtzf+1vp=XApw@mail.gmail.com>
On 02/23/2011 11:11 PM, Colin McCabe wrote:
> Here is the proposed C++ API for librados 0.25.
> The main changes are that I created class Pool, class Snap, and the
> ObjectIterator interface.
I like the idea of a more OO interface. This will allow easily
stacking librbd on top of librados, eliminating the need for a
separate librbd pool type.
I have a couple suggestions:
- The pool_t parameters in the self-managed snap methods can be
removed, since they're part of the Pool class.
- The aio_read/write functions can be members of Pool instead of
having a pool_t parameter.
- aio_create_completion could be moved into Pool since it's only
used within the context of a pool. (librbd would need this unless
Pool had a get_rados method).
Also, what is the constructor Pool(Rados *rados_, pool_t *pool_)
intended to be used for? I don't see a method to get a pool_t from
this API.
-Josh Durgin
next prev parent reply other threads:[~2011-02-24 18:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-24 7:11 C++ api for librados 0.25 Colin McCabe
2011-02-24 7:51 ` Wido den Hollander
2011-02-24 18:02 ` Josh Durgin [this message]
2011-02-24 18:13 ` Colin McCabe
2011-02-24 18:30 ` Sage Weil
2011-02-24 18:38 ` Josh Durgin
2011-02-24 23:20 ` Colin McCabe
2011-02-25 0:14 ` Sage Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D669D48.6060202@dreamhost.com \
--to=josh.durgin@dreamhost.com \
--cc=ceph-devel@vger.kernel.org \
--cc=cmccabe@alumni.cmu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.