From: Josh Durgin <josh.durgin@dreamhost.com>
To: Colin McCabe <cmccabe@alumni.cmu.edu>
Cc: ceph-devel@vger.kernel.org
Subject: Re: C++ api for librados 0.25
Date: Thu, 24 Feb 2011 10:38:33 -0800 [thread overview]
Message-ID: <4D66A5A9.4050107@dreamhost.com> (raw)
In-Reply-To: <AANLkTi=RW=AWkDoZsM8TsKdZP+6AJNCfwdJ2SKtU3oVV@mail.gmail.com>
On 02/24/2011 10:13 AM, Colin McCabe wrote:
> On Thu, Feb 24, 2011 at 10:02 AM, Josh Durgin <josh.durgin@dreamhost.com> wrote:
>> - aio_create_completion could be moved into Pool since it's only
>> used within the context of a pool. (librbd would need this unless
>> Pool had a get_rados method).
>
> Hmm. I'm not seeing the pool dependency for aio_create_completion. It
> looks like this has nothing to do with any particular pool. It's just
> a callback?
My thinking was that the only reason for creating one is for doing aio, which is done on a pool.
Looking at the implementation, however, there's no dependency on the RadosClient at all.
These could just be constructors of AioCompletion (in the interface and implementation).
-Josh Durgin
next prev parent reply other threads:[~2011-02-24 18:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-24 7:11 C++ api for librados 0.25 Colin McCabe
2011-02-24 7:51 ` Wido den Hollander
2011-02-24 18:02 ` Josh Durgin
2011-02-24 18:13 ` Colin McCabe
2011-02-24 18:30 ` Sage Weil
2011-02-24 18:38 ` Josh Durgin [this message]
2011-02-24 23:20 ` Colin McCabe
2011-02-25 0:14 ` Sage Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D66A5A9.4050107@dreamhost.com \
--to=josh.durgin@dreamhost.com \
--cc=ceph-devel@vger.kernel.org \
--cc=cmccabe@alumni.cmu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.