Re: [PATCH] fsmc-nand: Add fsmc_nand_set_plat_data in linux/mtd/fsmc.h

[viresh kumar <viresh.kumar@st.com>]

On 02/25/2011 04:41 PM, Artem Bityutskiy wrote:
>> > diff --git a/include/linux/mtd/fsmc.h b/include/linux/mtd/fsmc.h
>> > index 6987995..0cba324 100644
>> > --- a/include/linux/mtd/fsmc.h
>> > +++ b/include/linux/mtd/fsmc.h
>> > @@ -160,4 +160,21 @@ extern void __init fsmc_init_board_info(struct platform_device *pdev,
>> >  		struct mtd_partition *partitions, unsigned int nr_partitions,
>> >  		unsigned int width);
>> >  
>> > +/* This function is used to set platform data field of pdev->dev */
>> > +static inline void fsmc_nand_set_plat_data(struct platform_device *pdev,
>> > +		struct mtd_partition *partitions, unsigned int nr_partitions,
>> > +		unsigned int options, unsigned int width)
>> > +{
>> > +	struct fsmc_nand_platform_data *plat_data;
>> > +	plat_data = dev_get_platdata(&pdev->dev);
>> > +
>> > +	if (partitions) {
>> > +		plat_data->partitions = partitions;
>> > +		plat_data->nr_partitions = nr_partitions;
>> > +	}
>> > +
>> > +	plat_data->options = options;
>> > +	plat_data->width = width;
>> > +}
> Isn't this function too big to be an inline func in a header file?
> 

Sorry, i have already resent this patch with change in commit message.

Actually this routine will not be called many times. Only for setting
plat_data of few devices (depending on board). So i thought keeping
it inline would be better. But will change if you want. Should i move
it in fsmc-nand.c??

-- 
viresh