From: viresh kumar <viresh.kumar@st.com>
To: "dedekind1@gmail.com" <dedekind1@gmail.com>
Cc: Vipin KUMAR <vipin.kumar@st.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
Linus WALLEIJ <linus.walleij@stericsson.com>
Subject: Re: [PATCH] fsmc-nand: Add fsmc_nand_set_plat_data in linux/mtd/fsmc.h
Date: Fri, 25 Feb 2011 17:13:03 +0530 [thread overview]
Message-ID: <4D6795C7.6090708@st.com> (raw)
In-Reply-To: <1298633138.2798.72.camel@localhost>
On 02/25/2011 04:55 PM, Artem Bityutskiy wrote:
> On Fri, 2011-02-25 at 16:52 +0530, viresh kumar wrote:
>> > Actually this routine will not be called many times.
> Which means it is not on the hot path which means inline is not really
> needed. Also, today it is not called too many times, tomorrow it could
> be called more often...
>
>> > Only for setting
>> > plat_data of few devices (depending on board). So i thought keeping
>> > it inline would be better. But will change if you want. Should i move
>> > it in fsmc-nand.c??
> Hi, up to you, I would not keep it in a header file, this is more about
> personal taste, I guess.
Ok. I have moved this to fsmc-nand.c. Will send V2.
--
viresh
prev parent reply other threads:[~2011-02-25 11:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 6:49 [PATCH] fsmc-nand: Add fsmc_nand_set_plat_data in linux/mtd/fsmc.h Viresh Kumar
2011-02-24 12:38 ` Linus Walleij
2011-02-25 3:44 ` viresh kumar
2011-02-25 8:39 ` Linus Walleij
2011-02-25 11:07 ` Artem Bityutskiy
2011-02-25 11:11 ` viresh kumar
2011-02-25 11:12 ` Artem Bityutskiy
2011-02-25 11:11 ` Artem Bityutskiy
2011-02-25 11:22 ` viresh kumar
2011-02-25 11:25 ` Artem Bityutskiy
2011-02-25 11:43 ` viresh kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6795C7.6090708@st.com \
--to=viresh.kumar@st.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-mtd@lists.infradead.org \
--cc=vipin.kumar@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.