All of lore.kernel.org
 help / color / mirror / Atom feed
From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/8 resend] dw_dmac: Mark all tx_descriptors with DMA_CRTL_ACK after xfer finish
Date: Mon, 28 Feb 2011 15:05:24 +0300	[thread overview]
Message-ID: <4D6B8F84.40905@ru.mvista.com> (raw)
In-Reply-To: <82027aa0c6446df3f7fb8e3c5fbdc28f60ea33b7.1298889267.git.viresh.kumar@st.com>

Hello.

On 28-02-2011 13:41, Viresh Kumar wrote:

> dwc_desc_get checks all descriptors for DMA_CTRL_ACK before allocating them for
> transfers. And descriptors are not marked with DMA_CRTL_ACK after transfer
> finishes. Thus descriptor once used is not usable again. This patch marks
> descriptors with DMA_CRTL_ACK after dma xfer finishes

> Signed-off-by: Viresh Kumar<viresh.kumar@st.com>
> ---
>   drivers/dma/dw_dmac.c |    7 +++++++
>   1 files changed, 7 insertions(+), 0 deletions(-)

> diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
> index c40b89f..01f783d 100644
> --- a/drivers/dma/dw_dmac.c
> +++ b/drivers/dma/dw_dmac.c
> @@ -196,6 +196,7 @@ dwc_descriptor_complete(struct dw_dma_chan *dwc, struct dw_desc *desc)
>   	dma_async_tx_callback		callback;
>   	void				*param;
>   	struct dma_async_tx_descriptor	*txd =&desc->txd;
> +	struct dw_desc	*child;

    Shouldn't this varaible name be aligned with the above variable names?

WBR, Sergei

WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Viresh Kumar <viresh.kumar@st.com>
Cc: dan.j.williams@intel.com, linus.walleij@stericsson.com,
	amit.goel@st.com, linux-kernel@vger.kernel.org,
	armando.visconti@st.com, shiraz.hashim@st.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 6/8 resend] dw_dmac: Mark all tx_descriptors with DMA_CRTL_ACK after xfer finish
Date: Mon, 28 Feb 2011 15:05:24 +0300	[thread overview]
Message-ID: <4D6B8F84.40905@ru.mvista.com> (raw)
In-Reply-To: <82027aa0c6446df3f7fb8e3c5fbdc28f60ea33b7.1298889267.git.viresh.kumar@st.com>

Hello.

On 28-02-2011 13:41, Viresh Kumar wrote:

> dwc_desc_get checks all descriptors for DMA_CTRL_ACK before allocating them for
> transfers. And descriptors are not marked with DMA_CRTL_ACK after transfer
> finishes. Thus descriptor once used is not usable again. This patch marks
> descriptors with DMA_CRTL_ACK after dma xfer finishes

> Signed-off-by: Viresh Kumar<viresh.kumar@st.com>
> ---
>   drivers/dma/dw_dmac.c |    7 +++++++
>   1 files changed, 7 insertions(+), 0 deletions(-)

> diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
> index c40b89f..01f783d 100644
> --- a/drivers/dma/dw_dmac.c
> +++ b/drivers/dma/dw_dmac.c
> @@ -196,6 +196,7 @@ dwc_descriptor_complete(struct dw_dma_chan *dwc, struct dw_desc *desc)
>   	dma_async_tx_callback		callback;
>   	void				*param;
>   	struct dma_async_tx_descriptor	*txd =&desc->txd;
> +	struct dw_desc	*child;

    Shouldn't this varaible name be aligned with the above variable names?

WBR, Sergei

  reply	other threads:[~2011-02-28 12:05 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-28 10:41 [PATCH 0/8 resend] dw_dmac: Extending support & minor fixes Viresh Kumar
2011-02-28 10:41 ` Viresh Kumar
2011-02-28 10:41 ` [PATCH 1/8 resend] dw_dmac: Remove compilation dependency from AVR32 Viresh Kumar
2011-02-28 10:41   ` Viresh Kumar
2011-03-02 16:46   ` Koul, Vinod
2011-03-02 16:46     ` Koul, Vinod
2011-03-03  3:42     ` viresh kumar
2011-03-03  3:42       ` viresh kumar
2011-03-03  4:19       ` Shiraz Hashim
2011-03-03  4:19         ` Shiraz Hashim
2011-03-05 11:38         ` Russell King - ARM Linux
2011-03-05 11:38           ` Russell King - ARM Linux
2011-03-07  4:15           ` viresh kumar
2011-03-07  4:15             ` viresh kumar
2011-02-28 10:41 ` [PATCH 2/8 resend] dw_dmac: Move single descriptor from dwc->queue to dwc->active_list in dwc_complete_all Viresh Kumar
2011-02-28 10:41   ` Viresh Kumar
2011-02-28 10:41 ` [PATCH 3/8 resend] dw_dmac: call dwc_scan_descriptor from dwc_issue_pending only if active list is empty Viresh Kumar
2011-02-28 10:41   ` Viresh Kumar
2011-02-28 10:46   ` Jamie Iles
2011-02-28 10:46     ` Jamie Iles
2011-02-28 10:58     ` viresh kumar
2011-02-28 10:58       ` viresh kumar
2011-02-28 10:41 ` [PATCH 4/8 resend] dw_dmac: calling dwc_scan_descriptors from dwc_tx_status() after taking lock Viresh Kumar
2011-02-28 10:41   ` Viresh Kumar
2011-03-02 18:13   ` Koul, Vinod
2011-03-02 18:13     ` Koul, Vinod
2011-03-03  3:44     ` viresh kumar
2011-03-03  3:44       ` viresh kumar
2011-02-28 10:41 ` [PATCH 5/8 resend] dw_dmac: adding support for 64 bit access width for memcpy xfers Viresh Kumar
2011-02-28 10:41   ` Viresh Kumar
2011-02-28 10:41 ` [PATCH 6/8 resend] dw_dmac: Mark all tx_descriptors with DMA_CRTL_ACK after xfer finish Viresh Kumar
2011-02-28 10:41   ` Viresh Kumar
2011-02-28 12:05   ` Sergei Shtylyov [this message]
2011-02-28 12:05     ` Sergei Shtylyov
2011-02-28 15:04     ` viresh kumar
2011-02-28 15:04       ` viresh kumar
2011-03-02 18:34   ` Koul, Vinod
2011-03-02 18:34     ` Koul, Vinod
2011-03-03  3:45     ` viresh kumar
2011-03-03  3:45       ` viresh kumar
2011-02-28 10:41 ` [PATCH 7/8 resend] dw_dmac.c: Pass Channel Allocation Order from platform_data Viresh Kumar
2011-02-28 10:41   ` Viresh Kumar
2011-03-02 18:37   ` Koul, Vinod
2011-03-02 18:37     ` Koul, Vinod
2011-03-03  3:48     ` viresh kumar
2011-03-03  3:48       ` viresh kumar
2011-02-28 10:41 ` [PATCH 8/8 resend] dw_dmac.c: Pass Channel Priority " Viresh Kumar
2011-02-28 10:41   ` Viresh Kumar
2011-03-02 18:46   ` Koul, Vinod
2011-03-02 18:46     ` Koul, Vinod
2011-03-03  3:51     ` viresh kumar
2011-03-03  3:51       ` viresh kumar
2011-03-02 16:39 ` [PATCH 0/8 resend] dw_dmac: Extending support & minor fixes Koul, Vinod
2011-03-02 16:39   ` Koul, Vinod
2011-03-03  3:40   ` viresh kumar
2011-03-03  3:40     ` viresh kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D6B8F84.40905@ru.mvista.com \
    --to=sshtylyov@mvista.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.