From: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
To: "John W. Linville" <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
Cc: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Geert Uytterhoeven
<geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>,
George <george0505-Rasf1IRRPZFBDgjK7y7TUQ@public.gmane.org>,
linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] rtlwifi: usb parts should depend on CONFIG_USB
Date: Mon, 28 Feb 2011 15:16:32 -0600 [thread overview]
Message-ID: <4D6C10B0.2090402@lwfinger.net> (raw)
In-Reply-To: <20110228201357.GF2515-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
On 02/28/2011 02:13 PM, John W. Linville wrote:
> On Mon, Feb 28, 2011 at 09:08:51PM +0100, Johannes Berg wrote:
>> On Mon, 2011-02-28 at 14:48 -0500, John W. Linville wrote:
>>>
>>> +ifeq ($(CONFIG_USB),y)
>>> +rtlwifi-objs += usb.o
>>> +endif
>>
>> That reads weird, shouldn't
>>
>> rtlwifi-$(CONFIG_USB) += usb.o
>>
>> do? Or more likely actually use CONFIG_RTL8192CU?
>
> Maybe...really just following what Larry already had there for pci...?
Yes, and that was wrong too.
It could be either as Johannes wrote it, or
ifneq ($(CONFIG_USB),)
rtlwifi-objs += usb.o
endif
Yhe PCI entry will also fail if CONFIG_PCI=m.
Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Larry Finger <Larry.Finger@lwfinger.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
George <george0505@realtek.com>,
linux-next@vger.kernel.org
Subject: Re: [PATCH] rtlwifi: usb parts should depend on CONFIG_USB
Date: Mon, 28 Feb 2011 15:16:32 -0600 [thread overview]
Message-ID: <4D6C10B0.2090402@lwfinger.net> (raw)
In-Reply-To: <20110228201357.GF2515@tuxdriver.com>
On 02/28/2011 02:13 PM, John W. Linville wrote:
> On Mon, Feb 28, 2011 at 09:08:51PM +0100, Johannes Berg wrote:
>> On Mon, 2011-02-28 at 14:48 -0500, John W. Linville wrote:
>>>
>>> +ifeq ($(CONFIG_USB),y)
>>> +rtlwifi-objs += usb.o
>>> +endif
>>
>> That reads weird, shouldn't
>>
>> rtlwifi-$(CONFIG_USB) += usb.o
>>
>> do? Or more likely actually use CONFIG_RTL8192CU?
>
> Maybe...really just following what Larry already had there for pci...?
Yes, and that was wrong too.
It could be either as Johannes wrote it, or
ifneq ($(CONFIG_USB),)
rtlwifi-objs += usb.o
endif
Yhe PCI entry will also fail if CONFIG_PCI=m.
Larry
next prev parent reply other threads:[~2011-02-28 21:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 12:56 [-next] ERROR: "usb_unanchor_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! Geert Uytterhoeven
2011-02-17 12:56 ` Geert Uytterhoeven
2011-02-28 19:48 ` [PATCH] rtlwifi: usb parts should depend on CONFIG_USB John W. Linville
[not found] ` <1298922500-21632-1-git-send-email-linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2011-02-28 20:08 ` Johannes Berg
2011-02-28 20:08 ` Johannes Berg
[not found] ` <1298923731.10109.0.camel-8upI4CBIZJIJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2011-02-28 20:13 ` John W. Linville
2011-02-28 20:13 ` John W. Linville
[not found] ` <20110228201357.GF2515-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2011-02-28 21:16 ` Larry Finger [this message]
2011-02-28 21:16 ` Larry Finger
2011-02-28 21:21 ` Johannes Berg
[not found] ` <1298928111.12230.0.camel-8upI4CBIZJIJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2011-02-28 21:27 ` Larry Finger
2011-02-28 21:27 ` Larry Finger
2011-03-01 18:53 ` [PATCH v2] " John W. Linville
2011-03-01 19:54 ` Larry Finger
2011-02-28 21:01 ` [PATCH] " Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6C10B0.2090402@lwfinger.net \
--to=larry.finger-tq5ms3gmjblk1umjsbkqmq@public.gmane.org \
--cc=geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org \
--cc=george0505-Rasf1IRRPZFBDgjK7y7TUQ@public.gmane.org \
--cc=johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org \
--cc=linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.