All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trilok Soni <tsoni@codeaurora.org>
To: Stepan Moskovchenko <stepanm@codeaurora.org>
Cc: davidb@codeaurora.org, dwalker@fifo99.com, bryanh@codeaurora.org,
	linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] msm: iommu: Rework clock logic and add IOMMU bus clock control
Date: Tue, 01 Mar 2011 12:45:30 +0530	[thread overview]
Message-ID: <4D6C9D12.8090207@codeaurora.org> (raw)
In-Reply-To: <1298937782-28725-1-git-send-email-stepanm@codeaurora.org>

Hi Steve,

On 3/1/2011 5:33 AM, Stepan Moskovchenko wrote:
> Clean up the clock control code in the probe calls, and add
> support for controlling the clock for the IOMMU bus
> interconnect. With the (proper) clock driver in place, the
> clock control logic in the probe function can be made much
> cleaner since it does not have to deal with the placeholder
> driver anymore.
> 
> Signed-off-by: Stepan Moskovchenko <stepanm@codeaurora.org>
> ---
> v2: Use resource_size.

Looks good to me.

Reviewed-by: Trilok Soni <tsoni@codeaurora.org>

---Trilok Soni
-- 
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

WARNING: multiple messages have this Message-ID (diff)
From: tsoni@codeaurora.org (Trilok Soni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/4] msm: iommu: Rework clock logic and add IOMMU bus clock control
Date: Tue, 01 Mar 2011 12:45:30 +0530	[thread overview]
Message-ID: <4D6C9D12.8090207@codeaurora.org> (raw)
In-Reply-To: <1298937782-28725-1-git-send-email-stepanm@codeaurora.org>

Hi Steve,

On 3/1/2011 5:33 AM, Stepan Moskovchenko wrote:
> Clean up the clock control code in the probe calls, and add
> support for controlling the clock for the IOMMU bus
> interconnect. With the (proper) clock driver in place, the
> clock control logic in the probe function can be made much
> cleaner since it does not have to deal with the placeholder
> driver anymore.
> 
> Signed-off-by: Stepan Moskovchenko <stepanm@codeaurora.org>
> ---
> v2: Use resource_size.

Looks good to me.

Reviewed-by: Trilok Soni <tsoni@codeaurora.org>

---Trilok Soni
-- 
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

  reply	other threads:[~2011-03-01  7:15 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-25  2:00 [PATCH 1/4] msm: iommu: Clock control for the IOMMU driver Stepan Moskovchenko
2011-02-25  2:00 ` Stepan Moskovchenko
2011-02-25  2:00 ` [PATCH 2/4] msm: iommu: Rework clock logic and add IOMMU bus clock control Stepan Moskovchenko
2011-02-25  2:00   ` Stepan Moskovchenko
2011-02-25  7:29   ` Trilok Soni
2011-02-25  7:29     ` Trilok Soni
2011-02-25 22:09     ` Stepan Moskovchenko
2011-02-25 22:09       ` Stepan Moskovchenko
2011-02-28 12:13       ` Trilok Soni
2011-02-28 12:13         ` Trilok Soni
2011-03-01  0:03   ` [PATCH v2 " Stepan Moskovchenko
2011-03-01  0:03     ` Stepan Moskovchenko
2011-03-01  7:15     ` Trilok Soni [this message]
2011-03-01  7:15       ` Trilok Soni
2011-02-25  2:00 ` [PATCH 3/4] msm: iommu: Use ASID tagging instead of VMID tagging Stepan Moskovchenko
2011-02-25  2:00   ` Stepan Moskovchenko
2011-02-25  2:00 ` [PATCH 4/4] msm: iommu: Remove dependency on IDR Stepan Moskovchenko
2011-02-25  2:00   ` Stepan Moskovchenko
2011-03-08 23:43 ` [PATCH 1/4] msm: iommu: Clock control for the IOMMU driver David Brown
2011-03-08 23:43   ` David Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D6C9D12.8090207@codeaurora.org \
    --to=tsoni@codeaurora.org \
    --cc=bryanh@codeaurora.org \
    --cc=davidb@codeaurora.org \
    --cc=dwalker@fifo99.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stepanm@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.