All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/1] u-boot: don't install host mkimage on non-native builds
@ 2011-03-01 17:49 Bruce Ashfield
  2011-03-01 17:49 ` [PATCH 1/1] u-boot: remove do_install from u-boot.inc Bruce Ashfield
  2011-03-01 19:00   ` [poky] " Saul Wold
  0 siblings, 2 replies; 4+ messages in thread
From: Bruce Ashfield @ 2011-03-01 17:49 UTC (permalink / raw)
  To: rpurdie; +Cc: yocto, poky, saul.wold

Richar/Saul,

This fixes BUG 777.

The u-boot package clearly uses HOST_CC and HOST_STRIP to build
mkimage, so installing it into ${D}${bindir} for anything but the
native mkimage is a bad idea. The native recipe has its own install
function, so we can safely delete the entire do_install from 
u-boot.inc


Pull URL: git://git.pokylinux.org/poky-contrib.git
  Branch: zedd/uboot
  Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=zedd/uboot

Thanks,
    Bruce Ashfield <bruce.ashfield@windriver.com>
---


Bruce Ashfield (1):
  u-boot: remove do_install from u-boot.inc

 meta/recipes-bsp/uboot/u-boot.inc |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/1] u-boot: remove do_install from u-boot.inc
  2011-03-01 17:49 [PATCH 0/1] u-boot: don't install host mkimage on non-native builds Bruce Ashfield
@ 2011-03-01 17:49 ` Bruce Ashfield
  2011-03-01 19:00   ` [poky] " Saul Wold
  1 sibling, 0 replies; 4+ messages in thread
From: Bruce Ashfield @ 2011-03-01 17:49 UTC (permalink / raw)
  To: rpurdie; +Cc: yocto, poky, saul.wold

Fixes [BUGID #777]

The do_install rule in u-boot.inc was installing a host
tool into the target ${bindir}, which is subsequently
stripped with target strip during packaging, and the
obvious error ensues.

The native u-boot recipe has its own install rule, and
the machine specific u-boot doesn't require mkimage or
anything else in the do_install function. So we remove
it completely until it is needed again.

Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
---
 meta/recipes-bsp/uboot/u-boot.inc |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/meta/recipes-bsp/uboot/u-boot.inc b/meta/recipes-bsp/uboot/u-boot.inc
index 1457c04..d1cebee 100644
--- a/meta/recipes-bsp/uboot/u-boot.inc
+++ b/meta/recipes-bsp/uboot/u-boot.inc
@@ -31,8 +31,3 @@ do_deploy () {
 	ln -sf ${UBOOT_IMAGE} ${UBOOT_SYMLINK}
 }
 addtask deploy before do_build after do_compile
-
-do_install() {
-	install -d ${D}${bindir}
-	install -m 755 tools/mkimage ${D}${bindir}/
-}
-- 
1.7.0.4



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/1] u-boot: don't install host mkimage on non-native builds
  2011-03-01 17:49 [PATCH 0/1] u-boot: don't install host mkimage on non-native builds Bruce Ashfield
@ 2011-03-01 19:00   ` Saul Wold
  2011-03-01 19:00   ` [poky] " Saul Wold
  1 sibling, 0 replies; 4+ messages in thread
From: Saul Wold @ 2011-03-01 19:00 UTC (permalink / raw)
  To: Bruce Ashfield; +Cc: yocto, poky

On 03/01/2011 09:49 AM, Bruce Ashfield wrote:
> Richar/Saul,
>
> This fixes BUG 777.
>
> The u-boot package clearly uses HOST_CC and HOST_STRIP to build
> mkimage, so installing it into ${D}${bindir} for anything but the
> native mkimage is a bad idea. The native recipe has its own install
> function, so we can safely delete the entire do_install from
> u-boot.inc
>
>
> Pull URL: git://git.pokylinux.org/poky-contrib.git
>    Branch: zedd/uboot
>    Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=zedd/uboot
>
> Thanks,
>      Bruce Ashfield<bruce.ashfield@windriver.com>
> ---
>
>
> Bruce Ashfield (1):
>    u-boot: remove do_install from u-boot.inc
>
>   meta/recipes-bsp/uboot/u-boot.inc |    5 -----
>   1 files changed, 0 insertions(+), 5 deletions(-)
>
> _______________________________________________
> poky mailing list
> poky@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky
>
Pulled into Master and Bernard

Thanks
	Sau!



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [poky] [PATCH 0/1] u-boot: don't install host mkimage on non-native builds
@ 2011-03-01 19:00   ` Saul Wold
  0 siblings, 0 replies; 4+ messages in thread
From: Saul Wold @ 2011-03-01 19:00 UTC (permalink / raw)
  To: Bruce Ashfield; +Cc: yocto, poky

On 03/01/2011 09:49 AM, Bruce Ashfield wrote:
> Richar/Saul,
>
> This fixes BUG 777.
>
> The u-boot package clearly uses HOST_CC and HOST_STRIP to build
> mkimage, so installing it into ${D}${bindir} for anything but the
> native mkimage is a bad idea. The native recipe has its own install
> function, so we can safely delete the entire do_install from
> u-boot.inc
>
>
> Pull URL: git://git.pokylinux.org/poky-contrib.git
>    Branch: zedd/uboot
>    Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=zedd/uboot
>
> Thanks,
>      Bruce Ashfield<bruce.ashfield@windriver.com>
> ---
>
>
> Bruce Ashfield (1):
>    u-boot: remove do_install from u-boot.inc
>
>   meta/recipes-bsp/uboot/u-boot.inc |    5 -----
>   1 files changed, 0 insertions(+), 5 deletions(-)
>
> _______________________________________________
> poky mailing list
> poky@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky
>
Pulled into Master and Bernard

Thanks
	Sau!



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-03-01 19:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-01 17:49 [PATCH 0/1] u-boot: don't install host mkimage on non-native builds Bruce Ashfield
2011-03-01 17:49 ` [PATCH 1/1] u-boot: remove do_install from u-boot.inc Bruce Ashfield
2011-03-01 19:00 ` [PATCH 0/1] u-boot: don't install host mkimage on non-native builds Saul Wold
2011-03-01 19:00   ` [poky] " Saul Wold

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.