* [PATCH 0/1] Fix several small bugs for adt installer
@ 2011-02-25 0:55 Liping Ke
2011-02-25 0:56 ` [PATCH 1/1] ADT: Fix several " Liping Ke
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Liping Ke @ 2011-02-25 0:55 UTC (permalink / raw)
To: poky
From: Liping Ke <liping.ke@intel.com>
Two bugs are found
1) image download file path is not correct. So even if file is downloaded
already, it can't be detected.
2) sdk image now is renamed as sato-sdk, we need to change the name
accordingly.
This patch is for fixing the above two bugs.
Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: lke/adt-newfix
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=lke/adt-newfix
Thanks,
Liping Ke <liping.ke@intel.com>
---
Liping Ke (1):
ADT: Fix several bugs for adt installer
.../installer/adt-installer/adt_installer | 9 +++++----
.../installer/adt-installer/scripts/data_define | 2 +-
2 files changed, 6 insertions(+), 5 deletions(-)
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 1/1] ADT: Fix several bugs for adt installer 2011-02-25 0:55 [PATCH 0/1] Fix several small bugs for adt installer Liping Ke @ 2011-02-25 0:56 ` Liping Ke 2011-02-24 8:57 ` Ke, Liping 2011-03-01 18:52 ` [PATCH 0/1] Fix several small " Saul Wold 2011-03-02 0:44 ` Saul Wold 2 siblings, 1 reply; 8+ messages in thread From: Liping Ke @ 2011-02-25 0:56 UTC (permalink / raw) To: poky From: Liping Ke <liping.ke@intel.com> Two bugs are found 1) image download file path is not correct. So even if file is downloaded already, it can't be detected. 2) sdk image now is renamed as sato-sdk, we need to change the name accordingly. Signed-off-by: Liping Ke <liping.ke@intel.com> --- .../installer/adt-installer/adt_installer | 9 +++++---- .../installer/adt-installer/scripts/data_define | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/meta/recipes-devtools/installer/adt-installer/adt_installer b/meta/recipes-devtools/installer/adt-installer/adt_installer index 1f481de..cca576f 100755 --- a/meta/recipes-devtools/installer/adt-installer/adt_installer +++ b/meta/recipes-devtools/installer/adt-installer/adt_installer @@ -216,17 +216,18 @@ done download_file() { -if [ -f "$LOCAL_DOWNLOAD/$1" ]; then - confirm_download $1 +local filename=`echo ${1##*/}` +if [ -f "$LOCAL_DOWNLOAD/$filename" ]; then + confirm_download $filename result="$?" if [ ! "$result" == "0" ]; then return else echo "Removing old file [$1]" - rm -rf "$LOCAL_DOWNLOAD/$1" + rm -rf "$LOCAL_DOWNLOAD/$filename" fi fi -echo_info "Downloading file: $1..." +echo_info "Downloading file: $filename..." wget "$YOCTOADT_IPKG_REPO/$1" -P $LOCAL_DOWNLOAD --progress=bar:force 2>&1 | tee -a "$YOCTOADT_INSTALL_LOG_FILE" } diff --git a/meta/recipes-devtools/installer/adt-installer/scripts/data_define b/meta/recipes-devtools/installer/adt-installer/scripts/data_define index 2895c4f..f9a6a4f 100644 --- a/meta/recipes-devtools/installer/adt-installer/scripts/data_define +++ b/meta/recipes-devtools/installer/adt-installer/scripts/data_define @@ -31,7 +31,7 @@ OPKG_LIBDIR="/var/lib" # List all supported root fs types and target types, # it will be used in user configuration validity checking -YOCTOADT_SUPPORTED_ROOTFS="minimal sato sdk lsb" +YOCTOADT_SUPPORTED_ROOTFS="minimal sato sato-sdk lsb" YOCTOADT_SUPPORTED_TARGETS="x86 x86_64 arm powerpc mips" # Different host (32 bit or 64 bit) will have different opkg # configuration files -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] ADT: Fix several bugs for adt installer 2011-02-25 0:56 ` [PATCH 1/1] ADT: Fix several " Liping Ke @ 2011-02-24 8:57 ` Ke, Liping 2011-02-24 19:33 ` Zhang, Jessica 0 siblings, 1 reply; 8+ messages in thread From: Ke, Liping @ 2011-02-24 8:57 UTC (permalink / raw) To: Ke, Liping, poky@yoctoproject.org Hi, Jessica Since SDK image is now changed, if we want to extract sdk unfs, we should So in configuration file, I set below lines: YOCTOADT_ROOTFS_arm="minimal sato-sdk" YOCTOADT_TARGET_SYSROOT_IMAGE_arm="sato-sdk" Thanks& Regards, criping > -----Original Message----- > From: poky-bounces@yoctoproject.org [mailto:poky- > bounces@yoctoproject.org] On Behalf Of Liping Ke > Sent: Friday, February 25, 2011 8:56 AM > To: poky@yoctoproject.org > Subject: [poky] [PATCH 1/1] ADT: Fix several bugs for adt installer > > From: Liping Ke <liping.ke@intel.com> > > Two bugs are found > 1) image download file path is not correct. So even if file is > downloaded > already, it can't be detected. > 2) sdk image now is renamed as sato-sdk, we need to change the name > accordingly. > > Signed-off-by: Liping Ke <liping.ke@intel.com> > --- > .../installer/adt-installer/adt_installer | 9 +++++---- > .../installer/adt-installer/scripts/data_define | 2 +- > 2 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/meta/recipes-devtools/installer/adt- > installer/adt_installer b/meta/recipes-devtools/installer/adt- > installer/adt_installer > index 1f481de..cca576f 100755 > --- a/meta/recipes-devtools/installer/adt-installer/adt_installer > +++ b/meta/recipes-devtools/installer/adt-installer/adt_installer > @@ -216,17 +216,18 @@ done > > download_file() > { > -if [ -f "$LOCAL_DOWNLOAD/$1" ]; then > - confirm_download $1 > +local filename=`echo ${1##*/}` > +if [ -f "$LOCAL_DOWNLOAD/$filename" ]; then > + confirm_download $filename > result="$?" > if [ ! "$result" == "0" ]; then > return > else > echo "Removing old file [$1]" > - rm -rf "$LOCAL_DOWNLOAD/$1" > + rm -rf "$LOCAL_DOWNLOAD/$filename" > fi > fi > -echo_info "Downloading file: $1..." > +echo_info "Downloading file: $filename..." > wget "$YOCTOADT_IPKG_REPO/$1" -P $LOCAL_DOWNLOAD --progress=bar:force > 2>&1 | tee -a "$YOCTOADT_INSTALL_LOG_FILE" > } > > diff --git a/meta/recipes-devtools/installer/adt- > installer/scripts/data_define b/meta/recipes-devtools/installer/adt- > installer/scripts/data_define > index 2895c4f..f9a6a4f 100644 > --- a/meta/recipes-devtools/installer/adt-installer/scripts/data_define > +++ b/meta/recipes-devtools/installer/adt-installer/scripts/data_define > @@ -31,7 +31,7 @@ OPKG_LIBDIR="/var/lib" > > # List all supported root fs types and target types, > # it will be used in user configuration validity checking > -YOCTOADT_SUPPORTED_ROOTFS="minimal sato sdk lsb" > +YOCTOADT_SUPPORTED_ROOTFS="minimal sato sato-sdk lsb" > YOCTOADT_SUPPORTED_TARGETS="x86 x86_64 arm powerpc mips" > # Different host (32 bit or 64 bit) will have different opkg > # configuration files > -- > 1.7.0.4 > > _______________________________________________ > poky mailing list > poky@yoctoproject.org > https://lists.yoctoproject.org/listinfo/poky ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] ADT: Fix several bugs for adt installer 2011-02-24 8:57 ` Ke, Liping @ 2011-02-24 19:33 ` Zhang, Jessica 2011-03-01 1:30 ` Ke, Liping 0 siblings, 1 reply; 8+ messages in thread From: Zhang, Jessica @ 2011-02-24 19:33 UTC (permalink / raw) To: Ke, Liping, Ke, Liping, poky@yoctoproject.org [-- Attachment #1: Type: text/plain, Size: 3486 bytes --] Ke, Liping wrote: > Hi, Jessica > > Since SDK image is now changed, if we want to extract sdk unfs, we > should So in configuration file, I set below lines: > > YOCTOADT_ROOTFS_arm="minimal sato-sdk" > YOCTOADT_TARGET_SYSROOT_IMAGE_arm="sato-sdk" > > > Thanks& Regards, > criping > > >> -----Original Message----- >> From: poky-bounces@yoctoproject.org [mailto:poky- >> bounces@yoctoproject.org] On Behalf Of Liping Ke >> Sent: Friday, February 25, 2011 8:56 AM >> To: poky@yoctoproject.org >> Subject: [poky] [PATCH 1/1] ADT: Fix several bugs for adt installer >> >> From: Liping Ke <liping.ke@intel.com> >> >> Two bugs are found >> 1) image download file path is not correct. So even if file is >> downloaded already, it can't be detected. >> 2) sdk image now is renamed as sato-sdk, we need to change the name >> accordingly. >> >> Signed-off-by: Liping Ke <liping.ke@intel.com> >> --- >> .../installer/adt-installer/adt_installer | 9 +++++---- >> .../installer/adt-installer/scripts/data_define | 2 +- >> 2 files changed, 6 insertions(+), 5 deletions(-) >> >> diff --git a/meta/recipes-devtools/installer/adt- >> installer/adt_installer b/meta/recipes-devtools/installer/adt- >> installer/adt_installer index 1f481de..cca576f 100755 >> --- a/meta/recipes-devtools/installer/adt-installer/adt_installer >> +++ b/meta/recipes-devtools/installer/adt-installer/adt_installer @@ >> -216,17 +216,18 @@ done >> >> download_file() >> { >> -if [ -f "$LOCAL_DOWNLOAD/$1" ]; then >> - confirm_download $1 >> +local filename=`echo ${1##*/}` >> +if [ -f "$LOCAL_DOWNLOAD/$filename" ]; then >> + confirm_download $filename >> result="$?" >> if [ ! "$result" == "0" ]; then >> return >> else >> echo "Removing old file [$1]" >> - rm -rf "$LOCAL_DOWNLOAD/$1" >> + rm -rf "$LOCAL_DOWNLOAD/$filename" >> fi >> fi >> -echo_info "Downloading file: $1..." >> +echo_info "Downloading file: $filename..." >> wget "$YOCTOADT_IPKG_REPO/$1" -P $LOCAL_DOWNLOAD >> --progress=bar:force 2>&1 | tee -a "$YOCTOADT_INSTALL_LOG_FILE" >> } >> >> diff --git a/meta/recipes-devtools/installer/adt- >> installer/scripts/data_define b/meta/recipes-devtools/installer/adt- >> installer/scripts/data_define index 2895c4f..f9a6a4f 100644 >> --- >> a/meta/recipes-devtools/installer/adt-installer/scripts/data_define >> +++ >> b/meta/recipes-devtools/installer/adt-installer/scripts/data_define >> @@ -31,7 +31,7 @@ OPKG_LIBDIR="/var/lib" >> >> # List all supported root fs types and target types, >> # it will be used in user configuration validity checking >> -YOCTOADT_SUPPORTED_ROOTFS="minimal sato sdk lsb" >> +YOCTOADT_SUPPORTED_ROOTFS="minimal sato sato-sdk lsb" Liping, The full list of supported ROOTFS are: minimal, minimal-dev, sato, sato-dev, sato-sdk, lsb, lsb-dev, lsb-sdk. Also, can you update the list in the comment in the adt_installer.conf as well? Thanks, Jessica >> YOCTOADT_SUPPORTED_TARGETS="x86 x86_64 arm powerpc mips" >> # Different host (32 bit or 64 bit) will have different opkg # >> configuration files -- >> 1.7.0.4 >> >> _______________________________________________ >> poky mailing list >> poky@yoctoproject.org >> https://lists.yoctoproject.org/listinfo/poky > _______________________________________________ > poky mailing list > poky@yoctoproject.org > https://lists.yoctoproject.org/listinfo/poky [-- Attachment #2: smime.p7s --] [-- Type: application/x-pkcs7-signature, Size: 8455 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] ADT: Fix several bugs for adt installer 2011-02-24 19:33 ` Zhang, Jessica @ 2011-03-01 1:30 ` Ke, Liping 0 siblings, 0 replies; 8+ messages in thread From: Ke, Liping @ 2011-03-01 1:30 UTC (permalink / raw) To: Zhang, Jessica, poky@yoctoproject.org Hi, Jessica Thanks for the comment. I have updated the patch and re-sent it. Any problem, just let me know. Thanks& Regards, criping > -----Original Message----- > From: Zhang, Jessica > Sent: Friday, February 25, 2011 3:34 AM > To: Ke, Liping; Ke, Liping; poky@yoctoproject.org > Subject: RE: [poky] [PATCH 1/1] ADT: Fix several bugs for adt installer > > Ke, Liping wrote: > > Hi, Jessica > > > > Since SDK image is now changed, if we want to extract sdk unfs, we > > should So in configuration file, I set below lines: > > > > YOCTOADT_ROOTFS_arm="minimal sato-sdk" > > YOCTOADT_TARGET_SYSROOT_IMAGE_arm="sato-sdk" > > > > > > Thanks& Regards, > > criping > > > > > >> -----Original Message----- > >> From: poky-bounces@yoctoproject.org [mailto:poky- > >> bounces@yoctoproject.org] On Behalf Of Liping Ke > >> Sent: Friday, February 25, 2011 8:56 AM > >> To: poky@yoctoproject.org > >> Subject: [poky] [PATCH 1/1] ADT: Fix several bugs for adt installer > >> > >> From: Liping Ke <liping.ke@intel.com> > >> > >> Two bugs are found > >> 1) image download file path is not correct. So even if file is > >> downloaded already, it can't be detected. > >> 2) sdk image now is renamed as sato-sdk, we need to change the name > >> accordingly. > >> > >> Signed-off-by: Liping Ke <liping.ke@intel.com> > >> --- > >> .../installer/adt-installer/adt_installer | 9 +++++---- > >> .../installer/adt-installer/scripts/data_define | 2 +- > >> 2 files changed, 6 insertions(+), 5 deletions(-) > >> > >> diff --git a/meta/recipes-devtools/installer/adt- > >> installer/adt_installer b/meta/recipes-devtools/installer/adt- > >> installer/adt_installer index 1f481de..cca576f 100755 > >> --- a/meta/recipes-devtools/installer/adt-installer/adt_installer > >> +++ b/meta/recipes-devtools/installer/adt-installer/adt_installer @@ > >> -216,17 +216,18 @@ done > >> > >> download_file() > >> { > >> -if [ -f "$LOCAL_DOWNLOAD/$1" ]; then > >> - confirm_download $1 > >> +local filename=`echo ${1##*/}` > >> +if [ -f "$LOCAL_DOWNLOAD/$filename" ]; then > >> + confirm_download $filename > >> result="$?" > >> if [ ! "$result" == "0" ]; then > >> return > >> else > >> echo "Removing old file [$1]" > >> - rm -rf "$LOCAL_DOWNLOAD/$1" > >> + rm -rf "$LOCAL_DOWNLOAD/$filename" > >> fi > >> fi > >> -echo_info "Downloading file: $1..." > >> +echo_info "Downloading file: $filename..." > >> wget "$YOCTOADT_IPKG_REPO/$1" -P $LOCAL_DOWNLOAD > >> --progress=bar:force 2>&1 | tee -a "$YOCTOADT_INSTALL_LOG_FILE" > >> } > >> > >> diff --git a/meta/recipes-devtools/installer/adt- > >> installer/scripts/data_define b/meta/recipes-devtools/installer/adt- > >> installer/scripts/data_define index 2895c4f..f9a6a4f 100644 > >> --- > >> a/meta/recipes-devtools/installer/adt-installer/scripts/data_define > >> +++ > >> b/meta/recipes-devtools/installer/adt-installer/scripts/data_define > >> @@ -31,7 +31,7 @@ OPKG_LIBDIR="/var/lib" > >> > >> # List all supported root fs types and target types, > >> # it will be used in user configuration validity checking > >> -YOCTOADT_SUPPORTED_ROOTFS="minimal sato sdk lsb" > >> +YOCTOADT_SUPPORTED_ROOTFS="minimal sato sato-sdk lsb" > > Liping, > > The full list of supported ROOTFS are: minimal, minimal-dev, sato, > sato-dev, > sato-sdk, lsb, lsb-dev, lsb-sdk. Also, can you update the list in the > comment in the adt_installer.conf as well? > > Thanks, > Jessica > > >> YOCTOADT_SUPPORTED_TARGETS="x86 x86_64 arm powerpc mips" > >> # Different host (32 bit or 64 bit) will have different opkg # > >> configuration files -- > >> 1.7.0.4 > >> > >> _______________________________________________ > >> poky mailing list > >> poky@yoctoproject.org > >> https://lists.yoctoproject.org/listinfo/poky > > _______________________________________________ > > poky mailing list > > poky@yoctoproject.org > > https://lists.yoctoproject.org/listinfo/poky ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/1] Fix several small bugs for adt installer 2011-02-25 0:55 [PATCH 0/1] Fix several small bugs for adt installer Liping Ke 2011-02-25 0:56 ` [PATCH 1/1] ADT: Fix several " Liping Ke @ 2011-03-01 18:52 ` Saul Wold 2011-03-02 0:44 ` Saul Wold 2 siblings, 0 replies; 8+ messages in thread From: Saul Wold @ 2011-03-01 18:52 UTC (permalink / raw) To: Liping Ke; +Cc: poky On 02/24/2011 04:55 PM, Liping Ke wrote: > From: Liping Ke<liping.ke@intel.com> > > Two bugs are found > 1) image download file path is not correct. So even if file is downloaded > already, it can't be detected. > 2) sdk image now is renamed as sato-sdk, we need to change the name > accordingly. > This patch is for fixing the above two bugs. > > > Pull URL: git://git.pokylinux.org/poky-contrib.git > Branch: lke/adt-newfix > Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=lke/adt-newfix > > Thanks, > Liping Ke<liping.ke@intel.com> > --- > > > Liping Ke (1): > ADT: Fix several bugs for adt installer > > .../installer/adt-installer/adt_installer | 9 +++++---- > .../installer/adt-installer/scripts/data_define | 2 +- > 2 files changed, 6 insertions(+), 5 deletions(-) > > _______________________________________________ > poky mailing list > poky@yoctoproject.org > https://lists.yoctoproject.org/listinfo/poky > Merged into Master & Bernard Thanks Sau! ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/1] Fix several small bugs for adt installer 2011-02-25 0:55 [PATCH 0/1] Fix several small bugs for adt installer Liping Ke 2011-02-25 0:56 ` [PATCH 1/1] ADT: Fix several " Liping Ke 2011-03-01 18:52 ` [PATCH 0/1] Fix several small " Saul Wold @ 2011-03-02 0:44 ` Saul Wold 2 siblings, 0 replies; 8+ messages in thread From: Saul Wold @ 2011-03-02 0:44 UTC (permalink / raw) To: Liping Ke; +Cc: poky On 02/24/2011 04:55 PM, Liping Ke wrote: > From: Liping Ke<liping.ke@intel.com> > > Two bugs are found > 1) image download file path is not correct. So even if file is downloaded > already, it can't be detected. > 2) sdk image now is renamed as sato-sdk, we need to change the name > accordingly. > This patch is for fixing the above two bugs. > Are there bug numbers for these? In the future, please reference the bugs with [BUGID #XXXX] Thanks Sau! > > Pull URL: git://git.pokylinux.org/poky-contrib.git > Branch: lke/adt-newfix > Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=lke/adt-newfix > > Thanks, > Liping Ke<liping.ke@intel.com> > --- > > > Liping Ke (1): > ADT: Fix several bugs for adt installer > > .../installer/adt-installer/adt_installer | 9 +++++---- > .../installer/adt-installer/scripts/data_define | 2 +- > 2 files changed, 6 insertions(+), 5 deletions(-) > > _______________________________________________ > poky mailing list > poky@yoctoproject.org > https://lists.yoctoproject.org/listinfo/poky > ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 0/1] Fix several small bugs for adt installer
@ 2011-03-01 17:31 Liping Ke
0 siblings, 0 replies; 8+ messages in thread
From: Liping Ke @ 2011-03-01 17:31 UTC (permalink / raw)
To: poky
From: Liping Ke <liping.ke@intel.com>
Two bugs are found
1) image download file path is not correct. So even if file is downloaded
already, it can't be detected.
2) sdk image now is renamed as sato-sdk, we need to change the name
accordingly.
Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: lke/adt-newfix
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=lke/adt-newfix
Thanks,
Liping Ke <liping.ke@intel.com>
---
Liping Ke (1):
ADT: Fix several bugs for adt installer
.../installer/adt-installer/adt_installer | 9 +++++----
.../installer/adt-installer/adt_installer.conf | 8 ++++----
.../installer/adt-installer/scripts/data_define | 2 +-
3 files changed, 10 insertions(+), 9 deletions(-)
^ permalink raw reply [flat|nested] 8+ messages in threadend of thread, other threads:[~2011-03-02 0:44 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-02-25 0:55 [PATCH 0/1] Fix several small bugs for adt installer Liping Ke 2011-02-25 0:56 ` [PATCH 1/1] ADT: Fix several " Liping Ke 2011-02-24 8:57 ` Ke, Liping 2011-02-24 19:33 ` Zhang, Jessica 2011-03-01 1:30 ` Ke, Liping 2011-03-01 18:52 ` [PATCH 0/1] Fix several small " Saul Wold 2011-03-02 0:44 ` Saul Wold -- strict thread matches above, loose matches on Subject: below -- 2011-03-01 17:31 Liping Ke
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.