From: Sergei Shtylyov <sshtylyov@mvista.com>
To: John Crispin <blogic@openwrt.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
Ralph Hempel <ralph.hempel@lantiq.com>,
Wim Van Sebroeck <wim@iguana.be>,
linux-mips@linux-mips.org, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH V3 05/10] MIPS: lantiq: add watchdog support
Date: Thu, 03 Mar 2011 14:44:28 +0300 [thread overview]
Message-ID: <4D6F7F1C.5040001@mvista.com> (raw)
In-Reply-To: <1299146626-17428-6-git-send-email-blogic@openwrt.org>
Hello.
On 03-03-2011 13:03, John Crispin wrote:
> This patch adds the driver for the watchdog found inside the Lantiq SoC family.
> Signed-off-by: John Crispin<blogic@openwrt.org>
> Signed-off-by: Ralph Hempel<ralph.hempel@lantiq.com>
> Cc: Wim Van Sebroeck<wim@iguana.be>
> Cc: linux-mips@linux-mips.org
> Cc: linux-watchdog@vger.kernel.org
[...]
> diff --git a/drivers/watchdog/lantiq_wdt.c b/drivers/watchdog/lantiq_wdt.c
> new file mode 100644
> index 0000000..d49ddaa
> --- /dev/null
> +++ b/drivers/watchdog/lantiq_wdt.c
> @@ -0,0 +1,235 @@
[...]
> +static void
> +ltq_wdt_disable(void)
> +{
> +#ifndef CONFIG_WATCHDOG_NOWAYOUT
> + ltq_wdt_ok_to_close = 0;
> +#endif
> + /* write the first paswword magic */
^
You still didn't fix the typo here. :-)
> + ltq_w32(LTQ_WDT_PW1, ltq_wdt_membase + LTQ_WDT_CR);
> + /* write the second paswword magic with no config
^
And here...
> +static int
> +ltq_wdt_probe(struct platform_device *pdev)
Should be __init now that you're using platform_driver_probe()...
> + /* we do not need to enable the clock as it is always running */
> + clk = clk_get(&pdev->dev, "io");
> + if (!clk)
> + BUG();
BUG_ON(!clk);
> +static struct platform_driver ltq_wdt_driver = {
> + .probe = ltq_wdt_probe,
No need to initialize it now that you're using platform_driver_probe()...
> + .remove = ltq_wdt_remove,
Shouldn't 'ltq_wdt_remove' be enclosed in __exit_p()?
WBR, Sergei
next prev parent reply other threads:[~2011-03-03 11:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 10:03 [PATCH V3 00/10] MIPS: add initial support for the Lantiq SoCs John Crispin
2011-03-03 10:03 ` [PATCH V3 01/10] MIPS: lantiq: add initial support for " John Crispin
2011-03-03 10:03 ` [PATCH V3 02/10] MIPS: lantiq: add SoC specific code for XWAY family John Crispin
2011-03-03 10:03 ` [PATCH V3 03/10] MIPS: lantiq: add PCI controller support John Crispin
2011-03-03 10:03 ` [PATCH V3 04/10] MIPS: lantiq: add serial port support John Crispin
2011-03-03 10:03 ` [PATCH V3 05/10] MIPS: lantiq: add watchdog support John Crispin
2011-03-03 11:44 ` Sergei Shtylyov [this message]
2011-03-03 11:58 ` John Crispin
2011-03-03 10:03 ` [PATCH V3 06/10] MIPS: lantiq: add NOR flash support John Crispin
2011-03-03 10:03 ` John Crispin
2011-03-04 12:41 ` Sergei Shtylyov
2011-03-04 12:41 ` Sergei Shtylyov
2011-03-04 15:10 ` Sergei Shtylyov
2011-03-04 15:10 ` Sergei Shtylyov
2011-03-04 20:13 ` John Crispin
2011-03-04 20:13 ` John Crispin
2011-03-03 10:03 ` [PATCH V3 07/10] MIPS: lantiq: add platform device support John Crispin
2011-03-03 10:03 ` [PATCH V3 08/10] MIPS: lantiq: add mips_machine support John Crispin
2011-03-03 10:03 ` [PATCH V3 09/10] MIPS: lantiq: add machtypes for lantiq eval kits John Crispin
2011-03-03 10:03 ` [PATCH V3 10/10] MIPS: lantiq: add more gpio drivers John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6F7F1C.5040001@mvista.com \
--to=sshtylyov@mvista.com \
--cc=blogic@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=ralph.hempel@lantiq.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.