Re: [patch] Fix bug #13853: dereference pointer 'dev' before null check

[Jinqiu <crindy646@gmail.com>]

On 11-3-3 下午2:29, Randy Dunlap wrote:
> On Wed, 02 Mar 2011 21:20:21 -0500 Jinqiu wrote:
>
>> This patch fixes bug #13853 .This still exists in latest version.
>> 'dev' is dereferenced before testing for NULL.
>>
>> Signed-off-by: Jinqiu Yang<crindy646@gmail.com>
>> --- a/drivers/net/ariadne.c
>> +++ b/drivers/net/ariadne.c
>> @@ -420,7 +420,7 @@ static inline void ariadne_reset(struct
>> static irqreturn_t ariadne_interrupt(int irq, void *data)
>> {
>> 	struct net_device *dev = (struct net_device *) data;
>> - 	volatile struct Am79C960 *lance = (struct Am79C960*)dev->base_addr;
>> + 	volatile struct Am79C960 *lance;
>> 	struct ariadne_private *priv;
>> 	int csr0, boguscnt;
>> 	int handled = 0;
> Did you patch generator tool insert tabs in this patch?
No, I did not. This is weird. The original patch is fine.
  I would fix email client issues.
Thanks for your help! :-)

  Jinqiu
> The line below should be formatted as:
>
> @@ -429,6 +429,7 @@ static irqreturn_t ariadne_interrupt(int
>
> with no space between 429, and 7.
>
>> @@ -429,6 +429, 7 @@ static irqreturn_t ariadne_interrupt(int
>> 		printk(KERN_WARNING  "ariadne_interrupt(): irq for unknown device.\n");
>> 		return IRQ_NONE;
>> 	}
>> + 	lance = (struct Am79C960 *)dev->base_addr;
>>
>> 	lance->RAP = CSR0; 					/* PCnet-ISA Controller Status */
>>
>>
>>
>>
>> --
>
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***