From: Li Zefan <lizf@cn.fujitsu.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Wolfram Sang <w.sang@pengutronix.de>,
Jinqiu <crindy646@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [patch] Fix bug #13853: dereference pointer 'dev' before null check
Date: Fri, 04 Mar 2011 10:03:52 +0800 [thread overview]
Message-ID: <4D704888.7000707@cn.fujitsu.com> (raw)
In-Reply-To: <20110303084125.57f43b81.rdunlap@xenotime.net>
Randy Dunlap wrote:
> On Thu, 3 Mar 2011 09:11:56 +0100 Wolfram Sang wrote:
>
>> Hi,
>>
>>> Don't ever mention "bug #13853", because this number makes no sense
>>> for everyone except you. A proper subject may be:
>>>
>>> [PATCH] ariadne: fix possible null dereference.
>>
>> I agree for the subject line. Still, in the body or maybe after the "---" I'd
>> think it makes sense, so it is known there is a bugzilla entry to close? Also,
>> using search engines, one will be able to dig up the patch.
>
> It should just refer to the full bugzilla #13853 URL:
> https://bugzilla.kernel.org/show_bug.cgi?id=13853
>
Ok, then this should be made clear, for example add the URL in the changelog.
next prev parent reply other threads:[~2011-03-04 2:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 2:20 [patch] Fix bug #13853: dereference pointer 'dev' before null check Jinqiu
2011-03-03 2:50 ` Li Zefan
2011-03-03 8:11 ` Wolfram Sang
2011-03-03 16:41 ` Randy Dunlap
2011-03-04 2:03 ` Li Zefan [this message]
2011-03-03 16:42 ` Randy Dunlap
2011-03-03 19:23 ` Randy Dunlap
2011-03-03 19:29 ` Randy Dunlap
2011-03-03 21:19 ` Jinqiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D704888.7000707@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=crindy646@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.