From: "Zhai, Edwin" <edwin.zhai@intel.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: poky@yoctoproject.org,
Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 03/10] sato-icon-theme: Explictly use "Sato" as gtk icon theme
Date: Fri, 04 Mar 2011 09:05:51 +0800 [thread overview]
Message-ID: <4D703AEF.4060905@intel.com> (raw)
In-Reply-To: <1299194668.17567.181.camel@rex>
Richard Purdie wrote:
>
>
> > --- a/meta/recipes-sato/sato-icon-theme/sato-icon-theme.inc
> > +++ b/meta/recipes-sato/sato-icon-theme/sato-icon-theme.inc
> > @@ -16,9 +16,12 @@ PACKAGE_ARCH = "all"
> >
> > EXTRA_OECONF +=
> "--with-iconmap=${STAGING_LIBDIR_NATIVE}/../libexec/icon-name-mapping"
> >
> > +#explictly setting "Sato" as default icon theme to avoid icon
> missing due to
> > +#tricky race condition
> > pkg_postinst_${PN} () {
> > if [ "x$D" != "x" ]; then
> > exit 1
> > fi
> > gtk-update-icon-cache -q /usr/share/icons/Sato
> > + echo 'gtk-icon-theme-name = "Sato"' >> /etc/gtk-2.0/gtkrc
> > }
>
> I've deliberately merged the previous version of this patch as this one
> wipes out any contents of the file! I can live with duplicate lines for
> now.
>
> I'd like the bug to remain open on this one as this is a workaround, not
> a proper fix for the problem. It can change priority/target milestone
> though.
>
Agree. We can revisit it in future. It is very hard for reproducing and
debugging.
>
> Cheers,
>
> Richard
>
WARNING: multiple messages have this Message-ID (diff)
From: "Zhai, Edwin" <edwin.zhai@intel.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: poky@yoctoproject.org,
Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH 03/10] sato-icon-theme: Explictly use "Sato" as gtk icon theme
Date: Fri, 04 Mar 2011 09:05:51 +0800 [thread overview]
Message-ID: <4D703AEF.4060905@intel.com> (raw)
In-Reply-To: <1299194668.17567.181.camel@rex>
Richard Purdie wrote:
>
>
> > --- a/meta/recipes-sato/sato-icon-theme/sato-icon-theme.inc
> > +++ b/meta/recipes-sato/sato-icon-theme/sato-icon-theme.inc
> > @@ -16,9 +16,12 @@ PACKAGE_ARCH = "all"
> >
> > EXTRA_OECONF +=
> "--with-iconmap=${STAGING_LIBDIR_NATIVE}/../libexec/icon-name-mapping"
> >
> > +#explictly setting "Sato" as default icon theme to avoid icon
> missing due to
> > +#tricky race condition
> > pkg_postinst_${PN} () {
> > if [ "x$D" != "x" ]; then
> > exit 1
> > fi
> > gtk-update-icon-cache -q /usr/share/icons/Sato
> > + echo 'gtk-icon-theme-name = "Sato"' >> /etc/gtk-2.0/gtkrc
> > }
>
> I've deliberately merged the previous version of this patch as this one
> wipes out any contents of the file! I can live with duplicate lines for
> now.
>
> I'd like the bug to remain open on this one as this is a workaround, not
> a proper fix for the problem. It can change priority/target milestone
> though.
>
Agree. We can revisit it in future. It is very hard for reproducing and
debugging.
>
> Cheers,
>
> Richard
>
next prev parent reply other threads:[~2011-03-04 1:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 22:49 [PATCH 00/10] Consolidated Pull Request [v2] Saul Wold
2011-03-03 22:49 ` [PATCH 01/10] libpcre: fix the name collision with libc Saul Wold
2011-03-03 22:49 ` [PATCH 02/10] x11vnc: Fix the start failure Saul Wold
2011-03-03 22:49 ` [PATCH 03/10] sato-icon-theme: Explictly use "Sato" as gtk icon theme Saul Wold
2011-03-03 23:24 ` Richard Purdie
2011-03-03 23:24 ` [OE-core] " Richard Purdie
2011-03-04 1:05 ` Zhai, Edwin [this message]
2011-03-04 1:05 ` Zhai, Edwin
2011-03-03 22:49 ` [PATCH 05/10] Add libtool-nativesdk for ADT Saul Wold
2011-03-03 22:49 ` [PATCH 04/10] gstreamer: install the sound card driver of es1370 Saul Wold
2011-03-03 22:49 ` [PATCH 06/10] ADT: Bug fix for Suse Linux Saul Wold
2011-03-03 22:49 ` [PATCH 08/10] recipe: add newt from OE Saul Wold
2011-03-03 22:49 ` [PATCH 07/10] recipe: add chkconfig for LSB command test Saul Wold
2011-03-03 22:49 ` [PATCH 10/10] task-poky-lsb: add chkconfig Saul Wold
2011-03-03 22:49 ` [PATCH 09/10] recipe: add slang from OE Saul Wold
2011-03-03 23:27 ` [PATCH 00/10] Consolidated Pull Request [v2] Richard Purdie
2011-03-03 23:27 ` [OE-core] " Richard Purdie
2011-03-03 23:41 ` Richard Purdie
2011-03-03 23:41 ` [OE-core] " Richard Purdie
-- strict thread matches above, loose matches on Subject: below --
2011-03-03 20:02 [PATCH 00/10] Colsolidated Pull Request Saul Wold
2011-03-03 20:02 ` [PATCH 03/10] sato-icon-theme: Explictly use "Sato" as gtk icon theme Saul Wold
2011-03-03 20:25 ` Khem Raj
2011-03-04 0:58 ` Zhai, Edwin
2011-03-04 9:05 ` Koen Kooi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D703AEF.4060905@intel.com \
--to=edwin.zhai@intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=poky@yoctoproject.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.