All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saravana Kannan <skannan@codeaurora.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Stephen Boyd" <sboyd@codeaurora.org>,
	"Russell King - ARM Linux" <linux@arm.linux.org.uk>,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	"Daniel Walker" <dwalker@codeaurora.org>,
	"Nicolas Pitre" <nicolas.pitre@linaro.org>,
	"John Stultz" <johnstul@us.ibm.com>,
	"Brian Swetland" <swetland@google.com>,
	"Arve Hjønnevåg" <arve@android.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Mattias Wallin" <Mattias.Wallin@stericsson.com>
Subject: Re: [PATCHv4 0/4] ARM: Fixing udelay() for SMP and non-SMP systems
Date: Fri, 04 Mar 2011 15:48:45 -0800	[thread overview]
Message-ID: <4D717A5D.8010608@codeaurora.org> (raw)
In-Reply-To: <AANLkTi=KU_zUrBsp0a9iJyj6RmTgYqZcffQynTV-2tKW@mail.gmail.com>

On 03/04/2011 02:10 AM, Linus Walleij wrote:
> 2010/12/20 Stephen Boyd<sboyd@codeaurora.org>:
>
>> These patches fix the udelay() issue pointed out on
>> arm-lkml[1][2]. A quick recap: some SMP machines can scale
>> their CPU frequencies independent of one another. loops_per_jiffy
>> is calibrated globally and used in __const_udelay(). If one CPU
>> is running faster than what the loops_per_jiffy is calculated
>> (or scaled) for, udelay() will be incorrect and not wait long
>> enough (or too long). A similar problem occurs if the cpu
>> frequency is scaled during a udelay() call.
>
> Hwt's happening to this patch set? We have applied it and
> implemented a timer for the U8500.
>
> Tested-by: Linus Walleij<linus.walleij@linaro.org>
>
> Mattias WALLIN can probably also provide a Tested-by:
> from ST-Ericsson if it helps.
>
> Generally I think this is good and important stuff that should
> be merged, will you be submitting it to Russells patch tracker
> or pull request for 2.6.39?
>

Thanks for testing and reporting it Linus. We are certainly interested 
in getting this in. If I'm not mistaken, the last time we sent it out, 
there was a C vs. assembly argument and got side tracked or no one acked 
or responded to it. Will try to send out the patches again within the 
next few weeks.

Thanks,
Saravana

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

WARNING: multiple messages have this Message-ID (diff)
From: skannan@codeaurora.org (Saravana Kannan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv4 0/4] ARM: Fixing udelay() for SMP and non-SMP systems
Date: Fri, 04 Mar 2011 15:48:45 -0800	[thread overview]
Message-ID: <4D717A5D.8010608@codeaurora.org> (raw)
In-Reply-To: <AANLkTi=KU_zUrBsp0a9iJyj6RmTgYqZcffQynTV-2tKW@mail.gmail.com>

On 03/04/2011 02:10 AM, Linus Walleij wrote:
> 2010/12/20 Stephen Boyd<sboyd@codeaurora.org>:
>
>> These patches fix the udelay() issue pointed out on
>> arm-lkml[1][2]. A quick recap: some SMP machines can scale
>> their CPU frequencies independent of one another. loops_per_jiffy
>> is calibrated globally and used in __const_udelay(). If one CPU
>> is running faster than what the loops_per_jiffy is calculated
>> (or scaled) for, udelay() will be incorrect and not wait long
>> enough (or too long). A similar problem occurs if the cpu
>> frequency is scaled during a udelay() call.
>
> Hwt's happening to this patch set? We have applied it and
> implemented a timer for the U8500.
>
> Tested-by: Linus Walleij<linus.walleij@linaro.org>
>
> Mattias WALLIN can probably also provide a Tested-by:
> from ST-Ericsson if it helps.
>
> Generally I think this is good and important stuff that should
> be merged, will you be submitting it to Russells patch tracker
> or pull request for 2.6.39?
>

Thanks for testing and reporting it Linus. We are certainly interested 
in getting this in. If I'm not mistaken, the last time we sent it out, 
there was a C vs. assembly argument and got side tracked or no one acked 
or responded to it. Will try to send out the patches again within the 
next few weeks.

Thanks,
Saravana

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

  reply	other threads:[~2011-03-04 23:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-20 22:20 [PATCHv4 0/4] ARM: Fixing udelay() for SMP and non-SMP systems Stephen Boyd
2010-12-20 22:20 ` Stephen Boyd
2010-12-20 22:20 ` [PATCHv4 1/4] ARM: Translate delay.S into (mostly) C Stephen Boyd
2010-12-20 22:20   ` Stephen Boyd
2010-12-20 22:20 ` [PATCHv4 2/4] ARM: Allow machines to override __delay() Stephen Boyd
2010-12-20 22:20   ` Stephen Boyd
2011-04-05 22:13   ` Linus Walleij
2011-04-05 22:13     ` Linus Walleij
2011-04-05 23:29     ` Stephen Boyd
2011-04-05 23:29       ` Stephen Boyd
2010-12-20 22:20 ` [PATCHv4 3/4] ARM: Implement a timer based __delay() loop Stephen Boyd
2010-12-20 22:20   ` Stephen Boyd
2010-12-20 22:20 ` [PATCHv4 4/4] msm: timer: Migrate to timer based __delay() Stephen Boyd
2010-12-20 22:20   ` Stephen Boyd
2011-03-04 10:10 ` [PATCHv4 0/4] ARM: Fixing udelay() for SMP and non-SMP systems Linus Walleij
2011-03-04 10:10   ` Linus Walleij
2011-03-04 23:48   ` Saravana Kannan [this message]
2011-03-04 23:48     ` Saravana Kannan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D717A5D.8010608@codeaurora.org \
    --to=skannan@codeaurora.org \
    --cc=Mattias.Wallin@stericsson.com \
    --cc=akpm@linux-foundation.org \
    --cc=arve@android.com \
    --cc=dwalker@codeaurora.org \
    --cc=johnstul@us.ibm.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=nicolas.pitre@linaro.org \
    --cc=sboyd@codeaurora.org \
    --cc=swetland@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.