All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Jan Kiszka <jan.kiszka@web.de>, xming <xmingske@gmail.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	kvm@vger.kernel.org, qemu-devel <qemu-devel@nongnu.org>,
	Avi Kivity <avi@redhat.com>
Subject: Re: kvm crashes with spice while loading qxl
Date: Sat, 05 Mar 2011 18:11:41 +0100	[thread overview]
Message-ID: <4D726ECD.1010707@redhat.com> (raw)
In-Reply-To: <20110305163558.GA4607@amt.cnet>

On 03/05/2011 05:35 PM, Marcelo Tosatti wrote:
> TCG and KVM execution behaviour can become more
> similar wrt locking by dropping qemu_global_mutex during generation and
> execution of TBs.
>
> Of course for memory or PIO accesses from vcpu context qemu_global_mutex
> must be acquired.

-icount already has most of the machinery needed for this.

At this point, I think people interested in TCG should choose between 
staying with legacy and gaining a bit more speed for uniprocessor 
simulation, or following KVM with a more complex architecture and 
finer-grained locking---but also a more future-proof design.

BTW, I'll post soon patches for iothread -icount that work (at least in 
my tests), are much simpler than anything I posted so far, and hopefully 
will show that iothread is not fundamentally incompatible with anything 
(and in fact can simplify things much more than complicate them).

> With that in place, it becomes easier to justify further improvements
> regarding parallelization, such as using a read-write lock for
> l1_phys_map / phys_page_find_alloc.

Or URCU (userspace RCU), too.

Paolo

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org, qemu-devel <qemu-devel@nongnu.org>,
	xming <xmingske@gmail.com>, Jan Kiszka <jan.kiszka@web.de>,
	Avi Kivity <avi@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] Re: kvm crashes with spice while loading qxl
Date: Sat, 05 Mar 2011 18:11:41 +0100	[thread overview]
Message-ID: <4D726ECD.1010707@redhat.com> (raw)
In-Reply-To: <20110305163558.GA4607@amt.cnet>

On 03/05/2011 05:35 PM, Marcelo Tosatti wrote:
> TCG and KVM execution behaviour can become more
> similar wrt locking by dropping qemu_global_mutex during generation and
> execution of TBs.
>
> Of course for memory or PIO accesses from vcpu context qemu_global_mutex
> must be acquired.

-icount already has most of the machinery needed for this.

At this point, I think people interested in TCG should choose between 
staying with legacy and gaining a bit more speed for uniprocessor 
simulation, or following KVM with a more complex architecture and 
finer-grained locking---but also a more future-proof design.

BTW, I'll post soon patches for iothread -icount that work (at least in 
my tests), are much simpler than anything I posted so far, and hopefully 
will show that iothread is not fundamentally incompatible with anything 
(and in fact can simplify things much more than complicate them).

> With that in place, it becomes easier to justify further improvements
> regarding parallelization, such as using a read-write lock for
> l1_phys_map / phys_page_find_alloc.

Or URCU (userspace RCU), too.

Paolo

  reply	other threads:[~2011-03-05 17:11 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-26 11:43 kvm crashes with spice while loading qxl xming
2011-02-26 12:29 ` Jan Kiszka
2011-02-26 12:29   ` [Qemu-devel] " Jan Kiszka
2011-02-26 14:44   ` xming
2011-02-26 14:44     ` [Qemu-devel] " xming
2011-02-27 19:03   ` Alon Levy
2011-02-27 19:03     ` Alon Levy
2011-02-27 19:11     ` Jan Kiszka
2011-02-27 19:11       ` Jan Kiszka
2011-02-27 19:16       ` Alon Levy
2011-02-27 19:16         ` Alon Levy
2011-02-27 19:27         ` Jan Kiszka
2011-02-27 19:27           ` Jan Kiszka
2011-02-27 19:29           ` Alon Levy
2011-02-27 19:29             ` Alon Levy
2011-02-27 19:32           ` Alon Levy
2011-02-27 19:32             ` Alon Levy
2011-03-01 12:58       ` Alon Levy
2011-03-01 12:58         ` Alon Levy
2011-03-02  8:22         ` Jan Kiszka
2011-03-02 10:56           ` Alon Levy
2011-03-02 10:56             ` Alon Levy
2011-03-02 11:34             ` Jan Kiszka
2011-03-02 12:32               ` Alon Levy
2011-03-02 12:32                 ` Alon Levy
2011-02-28 12:56     ` xming
2011-03-01  3:56     ` Rick Vernam
2011-03-01  3:56       ` [Qemu-devel] " Rick Vernam
2011-03-05 16:35   ` Marcelo Tosatti
2011-03-05 16:35     ` [Qemu-devel] " Marcelo Tosatti
2011-03-05 17:11     ` Paolo Bonzini [this message]
2011-03-05 17:11       ` Paolo Bonzini
2011-03-06 10:30     ` Alon Levy
2011-03-06 10:30       ` [Qemu-devel] " Alon Levy
2011-03-07 16:02       ` Marcelo Tosatti
2011-03-07 16:02         ` [Qemu-devel] " Marcelo Tosatti
2011-03-06 10:38     ` Avi Kivity
2011-03-06 10:38       ` [Qemu-devel] " Avi Kivity
2011-03-07 16:13       ` Marcelo Tosatti
2011-03-07 16:13         ` [Qemu-devel] " Marcelo Tosatti
2011-03-07 22:27         ` Paolo Bonzini
2011-03-07 22:27           ` [Qemu-devel] " Paolo Bonzini
2011-03-08  9:17         ` Avi Kivity
2011-03-08  9:17           ` [Qemu-devel] " Avi Kivity
2011-03-08  9:28           ` Paolo Bonzini
2011-03-08  9:28             ` [Qemu-devel] " Paolo Bonzini
2011-03-08  9:32             ` Avi Kivity
2011-03-08  9:32               ` [Qemu-devel] " Avi Kivity
2011-04-26  8:53   ` Gerd Hoffmann
2011-04-26  8:53     ` [Qemu-devel] " Gerd Hoffmann
2011-04-26  9:06     ` Jan Kiszka
2011-04-26  9:06       ` [Qemu-devel] " Jan Kiszka
2011-04-26  9:43       ` Gerd Hoffmann
2011-04-26  9:43         ` [Qemu-devel] " Gerd Hoffmann
2011-04-26  9:34     ` Alon Levy
2011-04-26  9:34       ` [Qemu-devel] " Alon Levy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D726ECD.1010707@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=avi@redhat.com \
    --cc=jan.kiszka@web.de \
    --cc=kraxel@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=xmingske@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.