All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
To: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org
Subject: Re: [PATCH 2/3] ARM: tegra: harmony: register i2c devices
Date: Mon, 07 Mar 2011 18:43:44 +0300	[thread overview]
Message-ID: <4D74FD30.5010806@ru.mvista.com> (raw)
In-Reply-To: <1299486399-21761-3-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>

Hello.

On 07-03-2011 11:26, Olof Johansson wrote:

> Register the base i2c busses on harmony. Devices coming at a later date,
> but this allows for hand-probing of some of them at least.

> Signed-off-by: Olof Johansson<olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
> ---
>   arch/arm/mach-tegra/board-harmony.c |   32 ++++++++++++++++++++++++++++++++
>   1 files changed, 32 insertions(+), 0 deletions(-)

> diff --git a/arch/arm/mach-tegra/board-harmony.c b/arch/arm/mach-tegra/board-harmony.c
> index 38c2ab8..d46268d 100644
> --- a/arch/arm/mach-tegra/board-harmony.c
> +++ b/arch/arm/mach-tegra/board-harmony.c
[...]
> @@ -78,6 +80,35 @@ static struct platform_device harmony_audio_device = {
>   	},
>   };
>
> +static struct tegra_i2c_platform_data harmony_i2c1_platform_data = {
> +	.bus_clk_rate   = 400000,
> +};
> +
> +static struct tegra_i2c_platform_data harmony_i2c2_platform_data = {
> +	.bus_clk_rate   = 400000,
> +};
> +
> +static struct tegra_i2c_platform_data harmony_i2c3_platform_data = {
> +	.bus_clk_rate   = 400000,
> +};
> +
> +static struct tegra_i2c_platform_data harmony_dvc_platform_data = {
> +	.bus_clk_rate   = 400000,
> +};

    Why not share the paltform data between devices if it's the same anyway?

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: tegra: harmony: register i2c devices
Date: Mon, 07 Mar 2011 18:43:44 +0300	[thread overview]
Message-ID: <4D74FD30.5010806@ru.mvista.com> (raw)
In-Reply-To: <1299486399-21761-3-git-send-email-olof@lixom.net>

Hello.

On 07-03-2011 11:26, Olof Johansson wrote:

> Register the base i2c busses on harmony. Devices coming at a later date,
> but this allows for hand-probing of some of them at least.

> Signed-off-by: Olof Johansson<olof@lixom.net>
> ---
>   arch/arm/mach-tegra/board-harmony.c |   32 ++++++++++++++++++++++++++++++++
>   1 files changed, 32 insertions(+), 0 deletions(-)

> diff --git a/arch/arm/mach-tegra/board-harmony.c b/arch/arm/mach-tegra/board-harmony.c
> index 38c2ab8..d46268d 100644
> --- a/arch/arm/mach-tegra/board-harmony.c
> +++ b/arch/arm/mach-tegra/board-harmony.c
[...]
> @@ -78,6 +80,35 @@ static struct platform_device harmony_audio_device = {
>   	},
>   };
>
> +static struct tegra_i2c_platform_data harmony_i2c1_platform_data = {
> +	.bus_clk_rate   = 400000,
> +};
> +
> +static struct tegra_i2c_platform_data harmony_i2c2_platform_data = {
> +	.bus_clk_rate   = 400000,
> +};
> +
> +static struct tegra_i2c_platform_data harmony_i2c3_platform_data = {
> +	.bus_clk_rate   = 400000,
> +};
> +
> +static struct tegra_i2c_platform_data harmony_dvc_platform_data = {
> +	.bus_clk_rate   = 400000,
> +};

    Why not share the paltform data between devices if it's the same anyway?

WBR, Sergei

  parent reply	other threads:[~2011-03-07 15:43 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-07  8:26 [PATCH 0/3] Tegra i2c board changes + defconfig update Olof Johansson
2011-03-07  8:26 ` Olof Johansson
     [not found] ` <1299486399-21761-1-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
2011-03-07  8:26   ` [PATCH 1/3] ARM: tegra: seaboard: register i2c devices Olof Johansson
2011-03-07  8:26     ` Olof Johansson
     [not found]     ` <1299486399-21761-2-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
2011-03-07 17:24       ` Stephen Warren
2011-03-07 17:24         ` Stephen Warren
     [not found]         ` <74CDBE0F657A3D45AFBB94109FB122FF045687B855-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-03-07 19:29           ` Olof Johansson
2011-03-07 19:29             ` Olof Johansson
     [not found]             ` <AANLkTin6kCEnOFuua70ze4D3igtZuUEVTNRf4zq-qD4D-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-03-07 19:39               ` Stephen Warren
2011-03-07 19:39                 ` Stephen Warren
     [not found]                 ` <74CDBE0F657A3D45AFBB94109FB122FF045687B8E2-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-03-07 23:26                   ` Olof Johansson
2011-03-07 23:26                     ` Olof Johansson
2011-03-07  8:26   ` [PATCH 2/3] ARM: tegra: harmony: " Olof Johansson
2011-03-07  8:26     ` Olof Johansson
     [not found]     ` <1299486399-21761-3-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
2011-03-07 15:43       ` Sergei Shtylyov [this message]
2011-03-07 15:43         ` Sergei Shtylyov
2011-03-07 17:29       ` Stephen Warren
2011-03-07 17:29         ` Stephen Warren
2011-03-07  8:26   ` [PATCH 3/3] ARM: tegra: enable new drivers in defconfig Olof Johansson
2011-03-07  8:26     ` Olof Johansson
     [not found]     ` <1299486399-21761-4-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
2011-03-07 17:34       ` Stephen Warren
2011-03-07 17:34         ` Stephen Warren
     [not found]         ` <74CDBE0F657A3D45AFBB94109FB122FF045687B863-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-03-07 19:18           ` Olof Johansson
2011-03-07 19:18             ` Olof Johansson
     [not found]             ` <AANLkTi=ca32_k+6f65RoxnhpC=yn19Ee2uN72z+pH27s-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-03-07 19:24               ` Stephen Warren
2011-03-07 19:24                 ` Stephen Warren
2011-03-07 19:59   ` [PATCH 0/3] Tegra i2c board changes + defconfig update Colin Cross
2011-03-07 19:59     ` Colin Cross
     [not found]     ` <AANLkTikxNgsE37t86VkLamzzt9W-E7jBTOTfXkqEvK9p-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-03-07 20:04       ` Mark Brown
2011-03-07 20:04         ` Mark Brown
     [not found]         ` <20110307200452.GM1829-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2011-03-07 20:07           ` Colin Cross
2011-03-07 20:07             ` Colin Cross
     [not found]             ` <AANLkTimWi2z30tBK_1N_6gjqgbugCeCwc1oV3zWtModj-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-03-07 23:13               ` Olof Johansson
2011-03-07 23:13                 ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D74FD30.5010806@ru.mvista.com \
    --to=sshtylyov-igf4poytycdqt0dzr+alfa@public.gmane.org \
    --cc=ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.