All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Jes.Sorensen@redhat.com
Cc: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com
Subject: [Qemu-devel] Re: [PATCH v3] Improve error handling in do_snapshot_blkdev()
Date: Mon, 07 Mar 2011 16:44:14 +0100	[thread overview]
Message-ID: <4D74FD4E.4080901@redhat.com> (raw)
In-Reply-To: <1299511653-11357-1-git-send-email-Jes.Sorensen@redhat.com>

Am 07.03.2011 16:27, schrieb Jes.Sorensen@redhat.com:
> From: Jes Sorensen <Jes.Sorensen@redhat.com>
> 
> In case we cannot open the newly created snapshot image, try to fall
> back to the original image file and continue running on that, which
> should prevent the guest from aborting.
> 
> This is a corner case which can happen if the admin by mistake
> specifies the snapshot file on a virtual file system which does not
> support O_DIRECT. bdrv_create() does not use O_DIRECT, but the
> following open in bdrv_open() does and will then fail.
> 
> Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>

Thanks, applied to the block branch.

Kevin

  reply	other threads:[~2011-03-07 15:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-07 15:27 [Qemu-devel] [PATCH v3] Improve error handling in do_snapshot_blkdev() Jes.Sorensen
2011-03-07 15:44 ` Kevin Wolf [this message]
2011-03-07 16:34 ` Anthony Liguori
2011-03-07 16:39   ` Jes Sorensen
2011-03-07 17:47     ` Anthony Liguori
2011-03-08  8:24       ` Jes Sorensen
2011-03-08 13:42         ` Anthony Liguori
2011-03-08 16:44           ` Jes Sorensen
2011-03-08 17:46             ` Anthony Liguori
2011-03-09 10:20               ` Jes Sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D74FD4E.4080901@redhat.com \
    --to=kwolf@redhat.com \
    --cc=Jes.Sorensen@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.