From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH v3] Improve error handling in do_snapshot_blkdev()
Date: Wed, 09 Mar 2011 11:20:58 +0100 [thread overview]
Message-ID: <4D77548A.3030506@redhat.com> (raw)
In-Reply-To: <4D766B6F.9060307@codemonkey.ws>
On 03/08/11 18:46, Anthony Liguori wrote:
> On 03/08/2011 10:44 AM, Jes Sorensen wrote:
>> On 03/08/11 14:42, Anthony Liguori wrote:
>> It kinda sorta covers it. The problem with that is that you then have to
>> do a string match of the return values to determine which of the cases
>> happened, which isn't very nice. But I guess we can do that for now.
>
> Right, but this can be done in the HMP command such that the HMP command
> still prints out the warning message.
>
> The key is to have well documented error semantics where the various
> cases can be distinguished because then we can ensure that we can not
> only print out a nice error message in HMP, but that a remote QMP client
> (like libvirt) can also generate a high quality error message.
Have a look at v4 then, I've changed it to report errors back according
to this.
Jes
prev parent reply other threads:[~2011-03-09 10:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-07 15:27 [Qemu-devel] [PATCH v3] Improve error handling in do_snapshot_blkdev() Jes.Sorensen
2011-03-07 15:44 ` [Qemu-devel] " Kevin Wolf
2011-03-07 16:34 ` [Qemu-devel] " Anthony Liguori
2011-03-07 16:39 ` Jes Sorensen
2011-03-07 17:47 ` Anthony Liguori
2011-03-08 8:24 ` Jes Sorensen
2011-03-08 13:42 ` Anthony Liguori
2011-03-08 16:44 ` Jes Sorensen
2011-03-08 17:46 ` Anthony Liguori
2011-03-09 10:20 ` Jes Sorensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D77548A.3030506@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.