* [PATCH] drm: index i shadowed in 2nd loop
@ 2011-03-07 17:00 roel
2011-03-07 17:07 ` Chris Wilson
0 siblings, 1 reply; 2+ messages in thread
From: roel @ 2011-03-07 17:00 UTC (permalink / raw)
To: David Airlie, dri-devel, Andrew Morton, LKML
Index i was already used in thhe first loop
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
drivers/gpu/drm/drm_fb_helper.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
The original was wrong, isn't it?
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 6977a1c..f73ef43 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -672,7 +672,7 @@ int drm_fb_helper_setcmap(struct fb_cmap *cmap, struct fb_info *info)
struct drm_crtc_helper_funcs *crtc_funcs;
u16 *red, *green, *blue, *transp;
struct drm_crtc *crtc;
- int i, rc = 0;
+ int i, j, rc = 0;
int start;
for (i = 0; i < fb_helper->crtc_count; i++) {
@@ -685,7 +685,7 @@ int drm_fb_helper_setcmap(struct fb_cmap *cmap, struct fb_info *info)
transp = cmap->transp;
start = cmap->start;
- for (i = 0; i < cmap->len; i++) {
+ for (j = 0; j < cmap->len; j++) {
u16 hred, hgreen, hblue, htransp = 0xffff;
hred = *red++;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm: index i shadowed in 2nd loop
2011-03-07 17:00 [PATCH] drm: index i shadowed in 2nd loop roel
@ 2011-03-07 17:07 ` Chris Wilson
0 siblings, 0 replies; 2+ messages in thread
From: Chris Wilson @ 2011-03-07 17:07 UTC (permalink / raw)
To: roel, David Airlie, dri-devel, Andrew Morton, LKML
On Mon, 07 Mar 2011 18:00:34 +0100, roel <roel.kluin@gmail.com> wrote:
> Index i was already used in thhe first loop
Probably related to https://bugzilla.kernel.org/show_bug.cgi?id=19512
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-07 17:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-07 17:00 [PATCH] drm: index i shadowed in 2nd loop roel
2011-03-07 17:07 ` Chris Wilson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.