All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Shweta Gulati <shweta.gulati@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2 2/3] OMAP4: Update Voltage Rail Values for MPU/IVA
Date: Tue, 08 Mar 2011 07:36:54 +0530	[thread overview]
Message-ID: <4D758F3E.4020209@ti.com> (raw)
In-Reply-To: <1299318713-21389-1-git-send-email-shweta.gulati@ti.com>

Shweta Gulati wrote, on 03/05/2011 03:21 PM:
> Update MPU/IVA voltage Rail values obtained from
> OMAP4430 Data Manual Operating Condition Addendum_v0.3.
>
> Tested on OMAP4430 SDP Board.
>
> Signed-off-by: Shweta Gulati<shweta.gulati@ti.com>
> Cc: linux-arm-kernel@lists.infradead.org
> ---
>   arch/arm/mach-omap2/opp4xxx_data.c |   14 +++++++-------
>   1 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/opp4xxx_data.c b/arch/arm/mach-omap2/opp4xxx_data.c
> index 93b9744..36a4517 100644
> --- a/arch/arm/mach-omap2/opp4xxx_data.c
> +++ b/arch/arm/mach-omap2/opp4xxx_data.c
> @@ -31,10 +31,10 @@
>    * voltage dependent data for each VDD.
>    */
>
> -#define OMAP4430_VDD_MPU_OPP50_UV		930000
> -#define OMAP4430_VDD_MPU_OPP100_UV		1100000
> -#define OMAP4430_VDD_MPU_OPPTURBO_UV		1260000
> -#define OMAP4430_VDD_MPU_OPPNITRO_UV		1350000
> +#define OMAP4430_VDD_MPU_OPP50_UV		1025000
> +#define OMAP4430_VDD_MPU_OPP100_UV		1200000
> +#define OMAP4430_VDD_MPU_OPPTURBO_UV		1313000
> +#define OMAP4430_VDD_MPU_OPPNITRO_UV		1375000
>
>   struct omap_volt_data omap44xx_vdd_mpu_volt_data[] = {
>   	VOLT_DATA_DEFINE(OMAP4430_VDD_MPU_OPP50_UV, OMAP44XX_CONTROL_FUSE_MPU_OPP50, 0xf4, 0x0c),
> @@ -44,9 +44,9 @@ struct omap_volt_data omap44xx_vdd_mpu_volt_data[] = {
>   	VOLT_DATA_DEFINE(0, 0, 0, 0),
>   };
>
> -#define OMAP4430_VDD_IVA_OPP50_UV		930000
> -#define OMAP4430_VDD_IVA_OPP100_UV		1100000
> -#define OMAP4430_VDD_IVA_OPPTURBO_UV		1260000
> +#define OMAP4430_VDD_IVA_OPP50_UV		1013000
> +#define OMAP4430_VDD_IVA_OPP100_UV		1188000
> +#define OMAP4430_VDD_IVA_OPPTURBO_UV		1300000
>
>   struct omap_volt_data omap44xx_vdd_iva_volt_data[] = {
>   	VOLT_DATA_DEFINE(OMAP4430_VDD_IVA_OPP50_UV, OMAP44XX_CONTROL_FUSE_IVA_OPP50, 0xf4, 0x0c),
Acked-by: Nishanth Menon <nm@ti.com>


Side note: unrelated to this patch: PMICs have discrete step sizes of 
10mV, 12.5, 25mV etc.. which makes something lik 1.118V probably not 
exactly possible on a PMIC with 25mV step. We need to next probably 
create a framework to round_up the voltages to the PMIC step size once 
the PMIC voltage layer changes are in.

-- 
Regards,
Nishanth Menon

WARNING: multiple messages have this Message-ID (diff)
From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 2/3] OMAP4: Update Voltage Rail Values for MPU/IVA
Date: Tue, 08 Mar 2011 07:36:54 +0530	[thread overview]
Message-ID: <4D758F3E.4020209@ti.com> (raw)
In-Reply-To: <1299318713-21389-1-git-send-email-shweta.gulati@ti.com>

Shweta Gulati wrote, on 03/05/2011 03:21 PM:
> Update MPU/IVA voltage Rail values obtained from
> OMAP4430 Data Manual Operating Condition Addendum_v0.3.
>
> Tested on OMAP4430 SDP Board.
>
> Signed-off-by: Shweta Gulati<shweta.gulati@ti.com>
> Cc: linux-arm-kernel at lists.infradead.org
> ---
>   arch/arm/mach-omap2/opp4xxx_data.c |   14 +++++++-------
>   1 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/opp4xxx_data.c b/arch/arm/mach-omap2/opp4xxx_data.c
> index 93b9744..36a4517 100644
> --- a/arch/arm/mach-omap2/opp4xxx_data.c
> +++ b/arch/arm/mach-omap2/opp4xxx_data.c
> @@ -31,10 +31,10 @@
>    * voltage dependent data for each VDD.
>    */
>
> -#define OMAP4430_VDD_MPU_OPP50_UV		930000
> -#define OMAP4430_VDD_MPU_OPP100_UV		1100000
> -#define OMAP4430_VDD_MPU_OPPTURBO_UV		1260000
> -#define OMAP4430_VDD_MPU_OPPNITRO_UV		1350000
> +#define OMAP4430_VDD_MPU_OPP50_UV		1025000
> +#define OMAP4430_VDD_MPU_OPP100_UV		1200000
> +#define OMAP4430_VDD_MPU_OPPTURBO_UV		1313000
> +#define OMAP4430_VDD_MPU_OPPNITRO_UV		1375000
>
>   struct omap_volt_data omap44xx_vdd_mpu_volt_data[] = {
>   	VOLT_DATA_DEFINE(OMAP4430_VDD_MPU_OPP50_UV, OMAP44XX_CONTROL_FUSE_MPU_OPP50, 0xf4, 0x0c),
> @@ -44,9 +44,9 @@ struct omap_volt_data omap44xx_vdd_mpu_volt_data[] = {
>   	VOLT_DATA_DEFINE(0, 0, 0, 0),
>   };
>
> -#define OMAP4430_VDD_IVA_OPP50_UV		930000
> -#define OMAP4430_VDD_IVA_OPP100_UV		1100000
> -#define OMAP4430_VDD_IVA_OPPTURBO_UV		1260000
> +#define OMAP4430_VDD_IVA_OPP50_UV		1013000
> +#define OMAP4430_VDD_IVA_OPP100_UV		1188000
> +#define OMAP4430_VDD_IVA_OPPTURBO_UV		1300000
>
>   struct omap_volt_data omap44xx_vdd_iva_volt_data[] = {
>   	VOLT_DATA_DEFINE(OMAP4430_VDD_IVA_OPP50_UV, OMAP44XX_CONTROL_FUSE_IVA_OPP50, 0xf4, 0x0c),
Acked-by: Nishanth Menon <nm@ti.com>


Side note: unrelated to this patch: PMICs have discrete step sizes of 
10mV, 12.5, 25mV etc.. which makes something lik 1.118V probably not 
exactly possible on a PMIC with 25mV step. We need to next probably 
create a framework to round_up the voltages to the PMIC step size once 
the PMIC voltage layer changes are in.

-- 
Regards,
Nishanth Menon

  reply	other threads:[~2011-03-08  2:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-05  9:51 [PATCH V2 2/3] OMAP4: Update Voltage Rail Values for MPU/IVA Shweta Gulati
2011-03-05  9:51 ` Shweta Gulati
2011-03-08  2:06 ` Nishanth Menon [this message]
2011-03-08  2:06   ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D758F3E.4020209@ti.com \
    --to=nm@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=shweta.gulati@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.