[PATCH] Add the possibility to specify the modem in test/test-call-settings

[PATCH] Add the possibility to specify the modem in test/test-call-settings

[Bertrand Aygon]

[-- Attachment #1: Type: text/plain, Size: 1907 bytes --]

---
 test/test-call-settings |   19 +++++++++++++------
 1 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/test/test-call-settings b/test/test-call-settings
index f31fd1a..187b405 100755
--- a/test/test-call-settings
+++ b/test/test-call-settings
@@ -14,15 +14,12 @@ def property_changed(name, value):
 
 if __name__ == "__main__":
 	if len(sys.argv) < 3:
-		print "Usage: %s <property> <newvalue>" % (sys.argv[0])
+		print "Usage: %s [modem] <property> <newvalue>" % (sys.argv[0])
 		print "Properties can be: VoiceCallWaiting, HideCallerId"
 		sys.exit(1)
 
 	canexit = False
 
-	property = sys.argv[1]
-	newvalue = sys.argv[2]
-
 	dbus.mainloop.glib.DBusGMainLoop(set_as_default=True)
 
 	bus = dbus.SystemBus()
@@ -31,8 +28,18 @@ if __name__ == "__main__":
 							'org.ofono.Manager')
 
 	modems = manager.GetModems()
-
-	cs = dbus.Interface(bus.get_object('org.ofono', modems[0][0]),
+	modem = modems[0][0]
+
+	if (len(sys.argv) == 4):
+		modem = sys.argv[1]
+		property = sys.argv[2]
+		newvalue = sys.argv[3]
+	else:
+		property = sys.argv[1]
+		newvalue = sys.argv[2]
+	print "Using modem %s" % modem
+
+	cs = dbus.Interface(bus.get_object('org.ofono', modem),
 						'org.ofono.CallSettings')
 
 	cs.connect_to_signal("PropertyChanged", property_changed)
-- 
1.7.1

---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris, 
92196 Meudon Cedex, France
Registration Number:  302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

Re: [PATCH] Add the possibility to specify the modem in test/test-call-settings

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

Hi Bertrand,

On 03/04/2011 04:22 AM, Bertrand Aygon wrote:
> ---
>  test/test-call-settings |   19 +++++++++++++------
>  1 files changed, 13 insertions(+), 6 deletions(-)
> 

Patch has been applied, thanks.

Regards,
-Denis