[PATCH RESEND] cyclictest: Fixed incorrect wakeup reset interface

[PATCH RESEND] cyclictest: Fixed incorrect wakeup reset interface

[Geunsik Lim]

When we try to run ftrace with cyclictest command of rt-test,
We view the error according to base kernel version.
We need to modify this hard coded interface.

Signed-off-by: Geunsik Lim <geunsik.lim@samsung.com>
---
 src/cyclictest/cyclictest.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
index 0847aed..abc0b4e 100644
--- a/src/cyclictest/cyclictest.c
+++ b/src/cyclictest/cyclictest.c
@@ -487,7 +487,7 @@ static void setup_tracer(void)
 				setkernvar(traceroptions, traceptr[i]);
 		}
 		setkernvar("tracing_max_latency", "0");
-		setkernvar("latency_hist/wakeup_latency/reset", "1");
+		setkernvar("latency_hist/wakeup/reset", "1");
 	} else {
 		setkernvar("trace_all_cpus", "1");
 		setkernvar("trace_freerunning", "1");
@@ -501,6 +501,7 @@ static void setup_tracer(void)
 		if (ftrace)
 			setkernvar("mcount_enabled", "1");
 		setkernvar("trace_enabled", "1");
+		setkernvar("latency_hist/wakeup_latency/reset", "1");
 	}
 
 	tracing(1);
-- 
1.7.1

Re: [PATCH RESEND] cyclictest: Fixed incorrect wakeup reset interface

[Carsten Emde]

On 03/05/2011 02:18 AM, Geunsik Lim wrote:
> When we try to run ftrace with cyclictest command of rt-test,
> We view the error according to base kernel version.
> We need to modify this hard coded interface.
>
> Signed-off-by: Geunsik Lim<geunsik.lim@samsung.com>
> ---
>   src/cyclictest/cyclictest.c |    3 ++-
>   1 files changed, 2 insertions(+), 1 deletions(-)
>[..]
> -		setkernvar("latency_hist/wakeup_latency/reset", "1");
> +		setkernvar("latency_hist/wakeup/reset", "1");
This is correct. It considers a directory name change made longtime ago.

> [..]
>   		setkernvar("trace_enabled", "1");
> +		setkernvar("latency_hist/wakeup_latency/reset", "1");
This is not correct - probably an unintended insertion of the line that 
was removed above.

Would you mind to resubmit the patch with the first part only?

	-Carsten.

Re: [PATCH RESEND] cyclictest: Fixed incorrect wakeup reset interface

[Geunsik Lim]

On Wed, Mar 9, 2011 at 6:17 AM, Carsten Emde <C.Emde@osadl.org> wrote:
> On 03/05/2011 02:18 AM, Geunsik Lim wrote:
>>
>> When we try to run ftrace with cyclictest command of rt-test,
>> We view the error according to base kernel version.
>> We need to modify this hard coded interface.
>>
>> Signed-off-by: Geunsik Lim<geunsik.lim@samsung.com>
>> ---
>>  src/cyclictest/cyclictest.c |    3 ++-
>>  1 files changed, 2 insertions(+), 1 deletions(-)
>> [..]
>> -               setkernvar("latency_hist/wakeup_latency/reset", "1");
>> +               setkernvar("latency_hist/wakeup/reset", "1");
>
> This is correct. It considers a directory name change made longtime ago.
>
>> [..]
>>                setkernvar("trace_enabled", "1");
>> +               setkernvar("latency_hist/wakeup_latency/reset", "1");
>
> This is not correct - probably an unintended insertion of the line that was
> removed above.
>
> Would you mind to resubmit the patch with the first part only?
Ok. I will resubmit this patch after modification.
Thank you for your review.
>
>        -Carsten.
>



-- 
Regards,
Geunsik Lim ( Samsung Electronics )
Blog : http://blog.naver.com/invain/
e-Mail: geunsik.lim@samsung.com
           leemgs@gmail.com , leemgs1@gmail.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html