From: Mike Rapoport <mike-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
To: Marc Dietrich <marvin24-Mmb7MZpHnFY@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Colin Cross <ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>,
Erik Gilling <konkers-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>,
Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 2/3] ARM: tegra: harmony: initialize the TPS65862 PMIC
Date: Wed, 09 Mar 2011 08:23:31 +0200 [thread overview]
Message-ID: <4D771CE3.6020606@compulab.co.il> (raw)
In-Reply-To: <201103082312.06911.marvin24-Mmb7MZpHnFY@public.gmane.org>
On 03/09/11 00:12, Marc Dietrich wrote:
> Hi Mike,
>
> Am Dienstag 08 März 2011, um 13:58:58 schrieb Mike Rapoport:
>> Signed-off-by: Mike Rapoport <mike-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
>> ---
>> arch/arm/mach-tegra/Makefile | 1 +
>> arch/arm/mach-tegra/board-harmony-power.c | 161 +++++++++++++++++++++++++++++
>> arch/arm/mach-tegra/board-harmony.c | 1 +
>> arch/arm/mach-tegra/board-harmony.h | 1 +
>> 4 files changed, 164 insertions(+), 0 deletions(-)
>> create mode 100644 arch/arm/mach-tegra/board-harmony-power.c
>
> ...
>>
>> diff --git a/arch/arm/mach-tegra/board-harmony-power.c b/arch/arm/mach-tegra/board-harmony-power.c
>> new file mode 100644
>> index 0000000..ca43d7a
>> --- /dev/null
>> +++ b/arch/arm/mach-tegra/board-harmony-power.c
> ...
>> +static struct i2c_board_info __initdata harmony_regulators[] = {
>> + {
>> + I2C_BOARD_INFO("tps6586x", 0x34),
>> + .irq = INT_EXTERNAL_PMU,
>> + .platform_data = &tps_platform,
>> + },
>> +};
>> +
>> +int __init harmony_regulator_init(void)
>> +{
>> + i2c_register_board_info(3, harmony_regulators, 1);
>
> I don't know harmony well, but are you sure this is 3, not 4, as on all other boards?
In the mainline version of i2c-tegra the adapter (and therefore bus) number
equals the platform device id, and in case of DVC adapter it's 3.
>
> Marc
--
Sincerely yours,
Mike.
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: mike@compulab.co.il (Mike Rapoport)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: tegra: harmony: initialize the TPS65862 PMIC
Date: Wed, 09 Mar 2011 08:23:31 +0200 [thread overview]
Message-ID: <4D771CE3.6020606@compulab.co.il> (raw)
In-Reply-To: <201103082312.06911.marvin24@gmx.de>
On 03/09/11 00:12, Marc Dietrich wrote:
> Hi Mike,
>
> Am Dienstag 08 M?rz 2011, um 13:58:58 schrieb Mike Rapoport:
>> Signed-off-by: Mike Rapoport <mike@compulab.co.il>
>> ---
>> arch/arm/mach-tegra/Makefile | 1 +
>> arch/arm/mach-tegra/board-harmony-power.c | 161 +++++++++++++++++++++++++++++
>> arch/arm/mach-tegra/board-harmony.c | 1 +
>> arch/arm/mach-tegra/board-harmony.h | 1 +
>> 4 files changed, 164 insertions(+), 0 deletions(-)
>> create mode 100644 arch/arm/mach-tegra/board-harmony-power.c
>
> ...
>>
>> diff --git a/arch/arm/mach-tegra/board-harmony-power.c b/arch/arm/mach-tegra/board-harmony-power.c
>> new file mode 100644
>> index 0000000..ca43d7a
>> --- /dev/null
>> +++ b/arch/arm/mach-tegra/board-harmony-power.c
> ...
>> +static struct i2c_board_info __initdata harmony_regulators[] = {
>> + {
>> + I2C_BOARD_INFO("tps6586x", 0x34),
>> + .irq = INT_EXTERNAL_PMU,
>> + .platform_data = &tps_platform,
>> + },
>> +};
>> +
>> +int __init harmony_regulator_init(void)
>> +{
>> + i2c_register_board_info(3, harmony_regulators, 1);
>
> I don't know harmony well, but are you sure this is 3, not 4, as on all other boards?
In the mainline version of i2c-tegra the adapter (and therefore bus) number
equals the platform device id, and in case of DVC adapter it's 3.
>
> Marc
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2011-03-09 6:23 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 12:58 [PATCH 0/3] Harmony PCI-e and regulators Mike Rapoport
2011-03-08 12:58 ` Mike Rapoport
[not found] ` <cover.1299588456.git.mike-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2011-03-08 12:58 ` [PATCH 1/3] ARM: tegra: harmony: update PCI-e initialization sequence Mike Rapoport
2011-03-08 12:58 ` Mike Rapoport
2011-03-08 12:58 ` [PATCH 2/3] ARM: tegra: harmony: initialize the TPS65862 PMIC Mike Rapoport
2011-03-08 12:58 ` Mike Rapoport
[not found] ` <4ade6d195fff78271085eafb0a99de3be8beb426.1299588456.git.mike-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2011-03-08 13:15 ` Mark Brown
2011-03-08 13:15 ` Mark Brown
[not found] ` <20110308131541.GB5892-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2011-03-09 7:41 ` Mike Rapoport
2011-03-09 7:41 ` Mike Rapoport
[not found] ` <4D772F23.70304-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2011-03-09 10:15 ` Mark Brown
2011-03-09 10:15 ` Mark Brown
[not found] ` <20110309101508.GD6923-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2011-03-09 11:53 ` Mike Rapoport
2011-03-09 11:53 ` Mike Rapoport
[not found] ` <4D776A42.9030107-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2011-03-09 12:22 ` Mark Brown
2011-03-09 12:22 ` Mark Brown
[not found] ` <20110309122222.GG6923-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2011-03-09 13:19 ` Mike Rapoport
2011-03-09 13:19 ` Mike Rapoport
[not found] ` <4D777E6C.5040000-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2011-03-09 13:15 ` Mark Brown
2011-03-09 13:15 ` Mark Brown
[not found] ` <20110309131511.GB30257-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2011-03-09 13:23 ` Mike Rapoport
2011-03-09 13:23 ` Mike Rapoport
2011-03-08 22:12 ` Marc Dietrich
2011-03-08 22:12 ` Marc Dietrich
[not found] ` <201103082312.06911.marvin24-Mmb7MZpHnFY@public.gmane.org>
2011-03-09 6:23 ` Mike Rapoport [this message]
2011-03-09 6:23 ` Mike Rapoport
2011-03-09 11:14 ` Marvin
2011-03-09 11:14 ` Marvin
2011-03-08 12:58 ` [PATCH 3/3] ARM: tegra: update defconfig Mike Rapoport
2011-03-08 12:58 ` Mike Rapoport
2011-03-08 18:06 ` [PATCH 0/3] Harmony PCI-e and regulators Olof Johansson
2011-03-08 18:06 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D771CE3.6020606@compulab.co.il \
--to=mike-utxizqzc01rs1mouv/rt9w@public.gmane.org \
--cc=ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
--cc=konkers-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marvin24-Mmb7MZpHnFY@public.gmane.org \
--cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.