From: Stephen Boyd <sboyd@codeaurora.org>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: David Brown <davidb@codeaurora.org>,
Daniel Walker <dwalker@fifo99.com>,
linux-arm-msm@vger.kernel.org,
Saravana Kannan <skannan@codeaurora.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] msm: 8660: Add clock control regions to iomap
Date: Thu, 10 Mar 2011 12:19:34 -0800 [thread overview]
Message-ID: <4D793256.5070904@codeaurora.org> (raw)
In-Reply-To: <4D78F0D8.7000408@ru.mvista.com>
On 03/10/2011 07:40 AM, Sergei Shtylyov wrote:
>
>> diff --git a/arch/arm/mach-msm/include/mach/msm_iomap-8x60.h
>> b/arch/arm/mach-msm/include/mach/msm_iomap-8x60.h
>> index 3b19b8f..ddfc85b 100644
>> --- a/arch/arm/mach-msm/include/mach/msm_iomap-8x60.h
>> +++ b/arch/arm/mach-msm/include/mach/msm_iomap-8x60.h
>> @@ -53,6 +53,14 @@
>> #define MSM_TLMM_PHYS 0x00800000
>> #define MSM_TLMM_SIZE SZ_16K
>>
>> +#define MSM_CLK_CTL_BASE IOMEM(0xFA010000)
>> +#define MSM_CLK_CTL_PHYS 0x00900000
>> +#define MSM_CLK_CTL_SIZE SZ_16K
>
> Surrounding code separates the macro names from values by tabs, and
> you're using spaces. Should be more consistent...
Thanks, will fix.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] msm: 8660: Add clock control regions to iomap
Date: Thu, 10 Mar 2011 12:19:34 -0800 [thread overview]
Message-ID: <4D793256.5070904@codeaurora.org> (raw)
In-Reply-To: <4D78F0D8.7000408@ru.mvista.com>
On 03/10/2011 07:40 AM, Sergei Shtylyov wrote:
>
>> diff --git a/arch/arm/mach-msm/include/mach/msm_iomap-8x60.h
>> b/arch/arm/mach-msm/include/mach/msm_iomap-8x60.h
>> index 3b19b8f..ddfc85b 100644
>> --- a/arch/arm/mach-msm/include/mach/msm_iomap-8x60.h
>> +++ b/arch/arm/mach-msm/include/mach/msm_iomap-8x60.h
>> @@ -53,6 +53,14 @@
>> #define MSM_TLMM_PHYS 0x00800000
>> #define MSM_TLMM_SIZE SZ_16K
>>
>> +#define MSM_CLK_CTL_BASE IOMEM(0xFA010000)
>> +#define MSM_CLK_CTL_PHYS 0x00900000
>> +#define MSM_CLK_CTL_SIZE SZ_16K
>
> Surrounding code separates the macro names from values by tabs, and
> you're using spaces. Should be more consistent...
Thanks, will fix.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-03-10 20:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-10 4:44 [PATCH 0/3] Peripheral image loader (PIL) Stephen Boyd
2011-03-10 4:44 ` Stephen Boyd
2011-03-10 4:44 ` [PATCH 1/3] msm: 8660: Add clock control regions to iomap Stephen Boyd
2011-03-10 4:44 ` Stephen Boyd
2011-03-10 15:40 ` Sergei Shtylyov
2011-03-10 15:40 ` Sergei Shtylyov
2011-03-10 20:12 ` David Brown
2011-03-10 20:12 ` David Brown
2011-03-10 20:19 ` Stephen Boyd [this message]
2011-03-10 20:19 ` Stephen Boyd
2011-03-10 4:44 ` [PATCH 2/3] msm: Peripheral Image Loader (PIL) driver Stephen Boyd
2011-03-10 4:44 ` Stephen Boyd
2011-03-16 10:20 ` Daniel Walker
2011-03-16 10:20 ` Daniel Walker
2011-03-16 18:40 ` David Brown
2011-03-16 18:40 ` David Brown
2011-03-16 18:48 ` Saravana Kannan
2011-03-16 18:48 ` Saravana Kannan
2011-03-23 12:27 ` Daniel Walker
2011-03-23 12:27 ` Daniel Walker
2011-03-23 12:37 ` Daniel Walker
2011-03-23 12:37 ` Daniel Walker
2011-03-16 21:12 ` Bryan Huntsman
2011-03-16 21:12 ` Bryan Huntsman
2011-03-16 21:12 ` Bryan Huntsman
2011-03-10 4:44 ` [PATCH 3/3] msm: documentation: Add pil documentation Stephen Boyd
2011-03-10 4:44 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D793256.5070904@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=dwalker@fifo99.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=skannan@codeaurora.org \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.