From: Saul Wold <sgw@linux.intel.com>
To: Kang Kai <kai.kang@windriver.com>
Cc: poky@yoctoproject.org
Subject: Re: [PATCH 1/1] PATCH: fix Bug 812 about slang
Date: Thu, 10 Mar 2011 22:50:44 -0800 [thread overview]
Message-ID: <4D79C644.7000708@linux.intel.com> (raw)
In-Reply-To: <108cd6309917017e537b63d8951f7c9b6f48bb08.1299727511.git.kai.kang@windriver.com>
On 03/09/2011 10:07 PM, Kang Kai wrote:
> From: Kang Kai<kai.kang@windriver.com>
>
> Fix cross compile warnings: when bitbake slang, it links to building machine's
> library, add fix-cross-configure.patch to fix it.
>
> Add necessary files to run slsh.
>
> Signed-off-by: Kang Kai<kai.kang@windriver.com>
> ---
> .../slang/slang/fix-cross-configure.patch | 16 ++++++++++++++++
> meta/recipes-extended/slang/slang_2.2.2.bb | 7 +++++--
> 2 files changed, 21 insertions(+), 2 deletions(-)
> create mode 100644 meta/recipes-extended/slang/slang/fix-cross-configure.patch
>
> diff --git a/meta/recipes-extended/slang/slang/fix-cross-configure.patch b/meta/recipes-extended/slang/slang/fix-cross-configure.patch
> new file mode 100644
> index 0000000..0a22a1f
> --- /dev/null
> +++ b/meta/recipes-extended/slang/slang/fix-cross-configure.patch
> @@ -0,0 +1,16 @@
> +$(SLANG_INST_LIB) refer to absolute dir /usr/lib, it will make link to build machine's library
> +when do cross compilation, remove it.
> +
> +create by Kang Kai<kai.kang@windriver.com>
> +--- slang-2.2.2/slsh/Makefile.in.orig 2011-03-09 10:17:25.315245968 +0800
> ++++ slang-2.2.2/slsh/Makefile.in 2011-03-09 10:17:48.425245969 +0800
> +@@ -65,7 +65,8 @@
> + @SET_MAKE@
> + SHELL = /bin/sh
> + #INST_LIBS = $(RPATH) $(SLANG_INST_LIB) $(DEST_LIB_DIR) -lslang $(READLINE_LIB) $(OTHER_LIBS)
> +-INST_LIBS = $(DEST_LIB_DIR) $(RPATH) $(SLANG_INST_LIB) -lslang $(READLINE_LIB) $(OTHER_LIBS)
> ++#INST_LIBS = $(DEST_LIB_DIR) $(RPATH) $(SLANG_INST_LIB) -lslang $(READLINE_LIB) $(OTHER_LIBS)
> ++INST_LIBS = $(DEST_LIB_DIR) $(RPATH) -lslang $(READLINE_LIB) $(OTHER_LIBS)
> + DEFS = -DSLSH_CONF_DIR='"$(SLSH_CONF_DIR)"' -DSLSH_PATH='"$(SLSH_LIB_DIR)"' \
> + -DSLSH_CONF_DIR_ENV='$(SLSH_CONF_DIR_ENV)' -DSLSH_LIB_DIR_ENV='$(SLSH_LIB_DIR_ENV)' \
> + -DSLSH_PATH_ENV='$(SLSH_PATH_ENV)'
This is not the right approach, you should be looking at modifiying the
configure script.
> diff --git a/meta/recipes-extended/slang/slang_2.2.2.bb b/meta/recipes-extended/slang/slang_2.2.2.bb
> index 7fe76af..2498d85 100644
> --- a/meta/recipes-extended/slang/slang
> DEPENDS = "pcre"
> -PR = "r0"
> +PR = "r1"
>
> LICENSE = "GPL Artistic"
> LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
>
>
> SRC_URI = "ftp://space.mit.edu/pub/davis/slang/v2.2/OLD/slang-${PV}.tar.bz2 \
> - file://fix-uclibc.patch"
> + file://fix-uclibc.patch \
> + file://fix-cross-configure.patch"
>
> inherit autotools
>
> SRC_URI[md5sum] = "974437602a781cfe92ab61433dd16d03"
> SRC_URI[sha256sum] = "cfaf8551fa3855f9b0043309bb553ef6d457f931b404df5a6ba6a5a69371fc42"
> +
> +FILES_${PN} += "/usr/share/slsh/"
This should be ${datadir}/slsh
Sau!
next prev parent reply other threads:[~2011-03-11 6:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-10 6:07 [PATCH 0/1] PATCH:fix Bug 812 Kang Kai
2011-03-10 6:07 ` [PATCH 1/1] PATCH: fix Bug 812 about slang Kang Kai
2011-03-11 6:50 ` Saul Wold [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-03-14 6:29 [PATCH 0/1] PATCH RESEND: " Kang Kai
2011-03-14 6:29 ` [PATCH 1/1] PATCH: " Kang Kai
2011-03-15 1:17 ` Saul Wold
2011-03-15 3:23 ` Kang Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D79C644.7000708@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=kai.kang@windriver.com \
--cc=poky@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.