Re: [PATCH 1/1] PATCH: fix Bug 812 about slang

[Saul Wold <sgw@linux.intel.com>]

Kang,

The proper first line of a commit (commit subject line) should contain 
the package name followed by what you have done in this commit.

Also, the bug # should not be in the first line, it should be in the 
Body of the commit message in the [YOCTO #XXX] format.

So your commit message should read something like:

slang: Export INST_LIB_DIR in do_install to fix compile problems

Export "INST_LIB_DIR" to slang/slsh to fix cross compile warnings
Fixes [YOCTO #812]

Signed-off-by: Kang Kai<kai.kang@windriver.com>


Sau!


On 03/13/2011 11:29 PM, Kang Kai wrote:
> From: Kang Kai<kai.kang@windriver.com>
>
> Export "INST_LIB_DIR" to slang/slsh to fix cross compile warnings
>
> Add necessary files to run slsh.
>
> Signed-off-by: Kang Kai<kai.kang@windriver.com>
> ---
>   meta/recipes-extended/slang/slang_2.2.2.bb |    8 +++++++-
>   1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-extended/slang/slang_2.2.2.bb b/meta/recipes-extended/slang/slang_2.2.2.bb
> index 7fe76af..8459e24 100644
> --- a/meta/recipes-extended/slang/slang_2.2.2.bb
> +++ b/meta/recipes-extended/slang/slang_2.2.2.bb
> @@ -10,7 +10,7 @@ to recode S-Lang procedures in C if you need to."
>   SECTION = "libs"
>   PRIORITY = "optional"
>   DEPENDS = "pcre"
> -PR = "r0"
> +PR = "r1"
>
>   LICENSE = "GPL Artistic"
>   LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
> @@ -23,3 +23,9 @@ inherit autotools
>
>   SRC_URI[md5sum] = "974437602a781cfe92ab61433dd16d03"
>   SRC_URI[sha256sum] = "cfaf8551fa3855f9b0043309bb553ef6d457f931b404df5a6ba6a5a69371fc42"
> +
> +do_install() {
> +	oe_runmake install DESTDIR=${D} -e 'INST_LIB_DIR=${STAGING_DIR_HOST}/usr/lib'
> +}
> +
> +FILES_${PN} += "/usr/share/slsh/"