* Re: [lm-sensors] [PATCH 00/10] hwmon/f71882fg: Add support for new
2011-03-09 19:57 [lm-sensors] [PATCH 00/10] hwmon/f71882fg: Add support for new Hans de Goede
@ 2011-03-10 7:51 ` Hans de Goede
2011-03-10 16:00 ` Guenter Roeck
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Hans de Goede @ 2011-03-10 7:51 UTC (permalink / raw)
To: lm-sensors
Hi,
On 03/09/2011 08:57 PM, Hans de Goede wrote:
> Hi All,
>
> As already indicated in my testing request mail, I no longer have any
> hardware for testing these changes. The purpose of me posting these
> patches is to get a first round of review on them (although I hope no
> second round will be needed). Please wait with putting these patches into
> a tree for Linus until I've gotten some feedback from testers.
>
Ok, I've gotten some feedback from various testers and this looks good
to go. So ignore my last remark, and please queue this for pulling
by Linus (assuming it passes review).
Note there is a small bug in the 10th patch I'll send a fixed version of
that.
Regards,
Hans
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [lm-sensors] [PATCH 00/10] hwmon/f71882fg: Add support for new
2011-03-09 19:57 [lm-sensors] [PATCH 00/10] hwmon/f71882fg: Add support for new Hans de Goede
2011-03-10 7:51 ` Hans de Goede
@ 2011-03-10 16:00 ` Guenter Roeck
2011-03-11 16:09 ` Hans de Goede
2011-03-11 18:32 ` Guenter Roeck
3 siblings, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2011-03-10 16:00 UTC (permalink / raw)
To: lm-sensors
On Thu, Mar 10, 2011 at 02:51:44AM -0500, Hans de Goede wrote:
> Hi,
>
> On 03/09/2011 08:57 PM, Hans de Goede wrote:
> > Hi All,
> >
> > As already indicated in my testing request mail, I no longer have any
> > hardware for testing these changes. The purpose of me posting these
> > patches is to get a first round of review on them (although I hope no
> > second round will be needed). Please wait with putting these patches into
> > a tree for Linus until I've gotten some feedback from testers.
> >
>
> Ok, I've gotten some feedback from various testers and this looks good
> to go. So ignore my last remark, and please queue this for pulling
> by Linus (assuming it passes review).
>
> Note there is a small bug in the 10th patch I'll send a fixed version of
> that.
>
The series looks good to me, so with the test feedback I'll queue it for 2.6.39.
Do you have any Tested-by: tags ?
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [lm-sensors] [PATCH 00/10] hwmon/f71882fg: Add support for new
2011-03-09 19:57 [lm-sensors] [PATCH 00/10] hwmon/f71882fg: Add support for new Hans de Goede
2011-03-10 7:51 ` Hans de Goede
2011-03-10 16:00 ` Guenter Roeck
@ 2011-03-11 16:09 ` Hans de Goede
2011-03-11 18:32 ` Guenter Roeck
3 siblings, 0 replies; 5+ messages in thread
From: Hans de Goede @ 2011-03-11 16:09 UTC (permalink / raw)
To: lm-sensors
Hi,
On 03/10/2011 05:00 PM, Guenter Roeck wrote:
> On Thu, Mar 10, 2011 at 02:51:44AM -0500, Hans de Goede wrote:
>> Hi,
>>
>> On 03/09/2011 08:57 PM, Hans de Goede wrote:
>>> Hi All,
>>>
>>> As already indicated in my testing request mail, I no longer have any
>>> hardware for testing these changes. The purpose of me posting these
>>> patches is to get a first round of review on them (although I hope no
>>> second round will be needed). Please wait with putting these patches into
>>> a tree for Linus until I've gotten some feedback from testers.
>>>
>>
>> Ok, I've gotten some feedback from various testers and this looks good
>> to go. So ignore my last remark, and please queue this for pulling
>> by Linus (assuming it passes review).
>>
>> Note there is a small bug in the 10th patch I'll send a fixed version of
>> that.
>>
> The series looks good to me, so with the test feedback I'll queue it for 2.6.39.
>
Thanks for the review! Also thanks for the sch5627 review, I agree with all
your comments and I'll do a new version soon.
> Do you have any Tested-by: tags ?
Oh, good one I mailed people who have been kind enough to test for me to
ask if I could add a Tested-by tag, results:
Please add the following Tested-by tags to the
"hwmon/f71882fg: Add support for f71889ed" commit:
Tested-by: Thomas Greve <tg42@gmx.net>
Tested-by: Sander Eikelenboom <linux@eikelenboom.it>
And the following tags to the
"hwmon/f71882fg: Add support for f71869f and f71869e" commit:
Tested-by: Thomas Faber <thfabba@gmx.de>
Tested-by: Alexey Sychev <owl@umail.ru>
Tested-by: Dieter Bloms <dieter@bloms.de>
And the following tag to the
"hwmon/f71882fg: Add support for f71808e" commit:
Tested-by: Jonathan Michalon <johndescs@gmail.com>
Thanks & Regards,
Hans
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [lm-sensors] [PATCH 00/10] hwmon/f71882fg: Add support for new
2011-03-09 19:57 [lm-sensors] [PATCH 00/10] hwmon/f71882fg: Add support for new Hans de Goede
` (2 preceding siblings ...)
2011-03-11 16:09 ` Hans de Goede
@ 2011-03-11 18:32 ` Guenter Roeck
3 siblings, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2011-03-11 18:32 UTC (permalink / raw)
To: lm-sensors
Hi Hans,
On Fri, 2011-03-11 at 11:09 -0500, Hans de Goede wrote:
> Hi,
>
> On 03/10/2011 05:00 PM, Guenter Roeck wrote:
> > On Thu, Mar 10, 2011 at 02:51:44AM -0500, Hans de Goede wrote:
> >> Hi,
> >>
> >> On 03/09/2011 08:57 PM, Hans de Goede wrote:
> >>> Hi All,
> >>>
> >>> As already indicated in my testing request mail, I no longer have any
> >>> hardware for testing these changes. The purpose of me posting these
> >>> patches is to get a first round of review on them (although I hope no
> >>> second round will be needed). Please wait with putting these patches into
> >>> a tree for Linus until I've gotten some feedback from testers.
> >>>
> >>
> >> Ok, I've gotten some feedback from various testers and this looks good
> >> to go. So ignore my last remark, and please queue this for pulling
> >> by Linus (assuming it passes review).
> >>
> >> Note there is a small bug in the 10th patch I'll send a fixed version of
> >> that.
> >>
> > The series looks good to me, so with the test feedback I'll queue it for 2.6.39.
> >
>
> Thanks for the review! Also thanks for the sch5627 review, I agree with all
> your comments and I'll do a new version soon.
>
> > Do you have any Tested-by: tags ?
>
> Oh, good one I mailed people who have been kind enough to test for me to
> ask if I could add a Tested-by tag, results:
>
> Please add the following Tested-by tags to the
> "hwmon/f71882fg: Add support for f71889ed" commit:
>
> Tested-by: Thomas Greve <tg42@gmx.net>
> Tested-by: Sander Eikelenboom <linux@eikelenboom.it>
>
> And the following tags to the
> "hwmon/f71882fg: Add support for f71869f and f71869e" commit:
>
> Tested-by: Thomas Faber <thfabba@gmx.de>
> Tested-by: Alexey Sychev <owl@umail.ru>
> Tested-by: Dieter Bloms <dieter@bloms.de>
>
> And the following tag to the
> "hwmon/f71882fg: Add support for f71808e" commit:
>
> Tested-by: Jonathan Michalon <johndescs@gmail.com>
Excellent - all added.
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 5+ messages in thread