Re: [PATCH v6 6/9] memcg: add cgroupfs interface to memcg dirty limits

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Mike Heffner <mike@librato.com>
To: Greg Thelen <gthelen@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Chad Talbott <ctalbott@google.com>,
	Justin TerAvest <teravest@google.com>,
	Andrea Righi <arighi@develer.com>,
	Ciju Rajan K <ciju@linux.vnet.ibm.com>,
	David Rientjes <rientjes@google.com>,
	Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
	linux-kernel@vger.kernel.org, Vivek Goyal <vgoyal@redhat.com>,
	linux-mm@kvack.org, Johannes Weiner <hannes@cmpxchg.org>,
	containers@lists.osdl.org, linux-fsdevel@vger.kernel.org,
	Wu Fengguang <fengguang.wu@intel.com>,
	Balbir Singh <balbir@linux.vnet.ibm.com>
Subject: Re: [PATCH v6 6/9] memcg: add cgroupfs interface to memcg dirty limits
Date: Tue, 15 Mar 2011 10:01:05 -0400	[thread overview]
Message-ID: <4D7F7121.5040009@librato.com> (raw)
In-Reply-To: <1299869011-26152-7-git-send-email-gthelen@google.com>

On 03/11/2011 01:43 PM, Greg Thelen wrote:
> Add cgroupfs interface to memcg dirty page limits:
>    Direct write-out is controlled with:
>    - memory.dirty_ratio
>    - memory.dirty_limit_in_bytes
>
>    Background write-out is controlled with:
>    - memory.dirty_background_ratio
>    - memory.dirty_background_limit_bytes


What's the overlap, if any, with the current memory limits controlled by 
`memory.limit_in_bytes` and the above `memory.dirty_limit_in_bytes`? If 
I want to fairly balance memory between two cgroups be one a dirty page 
antagonist (dd) and the other an anonymous page (memcache), do I just 
set `memory.limit_in_bytes`? Does this patch simply provide a more 
granular level of control of the dirty limits?


Thanks,

Mike

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)

From: Mike Heffner <mike@librato.com>
To: Greg Thelen <gthelen@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Chad Talbott <ctalbott@google.com>,
	Justin TerAvest <teravest@google.com>,
	Andrea Righi <arighi@develer.com>,
	Ciju Rajan K <ciju@linux.vnet.ibm.com>,
	David Rientjes <rientjes@google.com>,
	Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
	linux-kernel@vger.kernel.org, Vivek Goyal <vgoyal@redhat.com>,
	linux-mm@kvack.org, Johannes Weiner <hannes@cmpxchg.org>,
	containers@lists.osdl.org, linux-fsdevel@vger.kernel.org,
	Wu Fengguang <fengguang.wu@intel.com>,
	Balbir Singh <balbir@linux.vnet.ibm.com>
Subject: Re: [PATCH v6 6/9] memcg: add cgroupfs interface to memcg dirty limits
Date: Tue, 15 Mar 2011 10:01:05 -0400	[thread overview]
Message-ID: <4D7F7121.5040009@librato.com> (raw)
In-Reply-To: <1299869011-26152-7-git-send-email-gthelen@google.com>

On 03/11/2011 01:43 PM, Greg Thelen wrote:
> Add cgroupfs interface to memcg dirty page limits:
>    Direct write-out is controlled with:
>    - memory.dirty_ratio
>    - memory.dirty_limit_in_bytes
>
>    Background write-out is controlled with:
>    - memory.dirty_background_ratio
>    - memory.dirty_background_limit_bytes


What's the overlap, if any, with the current memory limits controlled by 
`memory.limit_in_bytes` and the above `memory.dirty_limit_in_bytes`? If 
I want to fairly balance memory between two cgroups be one a dirty page 
antagonist (dd) and the other an anonymous page (memcache), do I just 
set `memory.limit_in_bytes`? Does this patch simply provide a more 
granular level of control of the dirty limits?


Thanks,

Mike

next prev parent reply	other threads:[~2011-03-15 14:01 UTC|newest]

Thread overview: 136+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-11 18:43 [PATCH v6 0/9] memcg: per cgroup dirty page accounting Greg Thelen
2011-03-11 18:43 ` Greg Thelen
2011-03-11 18:43 ` [PATCH v6 1/9] memcg: document cgroup dirty memory interfaces Greg Thelen
2011-03-11 18:43   ` Greg Thelen
2011-03-14 14:50   ` Minchan Kim
2011-03-14 14:50     ` Minchan Kim
2011-03-11 18:43 ` [PATCH v6 2/9] memcg: add page_cgroup flags for dirty page tracking Greg Thelen
2011-03-11 18:43   ` Greg Thelen
2011-03-11 18:43 ` [PATCH v6 3/9] memcg: add dirty page accounting infrastructure Greg Thelen
2011-03-11 18:43   ` Greg Thelen
2011-03-14 14:56   ` Minchan Kim
2011-03-14 14:56     ` Minchan Kim
2011-03-11 18:43 ` [PATCH v6 4/9] memcg: add kernel calls for memcg dirty page stats Greg Thelen
2011-03-11 18:43   ` Greg Thelen
2011-03-14 15:10   ` Minchan Kim
2011-03-14 15:10     ` Minchan Kim
2011-03-15  6:32     ` Greg Thelen
2011-03-15  6:32       ` Greg Thelen
2011-03-15  6:32       ` Greg Thelen
2011-03-15 13:50       ` Ryusuke Konishi
2011-03-15 13:50         ` Ryusuke Konishi
2011-03-11 18:43 ` [PATCH v6 5/9] memcg: add dirty limits to mem_cgroup Greg Thelen
2011-03-11 18:43   ` Greg Thelen
2011-03-11 18:43 ` [PATCH v6 6/9] memcg: add cgroupfs interface to memcg dirty limits Greg Thelen
2011-03-11 18:43   ` Greg Thelen
2011-03-14 15:16   ` Minchan Kim
2011-03-14 15:16     ` Minchan Kim
2011-03-15 14:01   ` Mike Heffner [this message]
2011-03-15 14:01     ` Mike Heffner
2011-03-16  0:00     ` KAMEZAWA Hiroyuki
2011-03-16  0:00       ` KAMEZAWA Hiroyuki
2011-03-16  0:50     ` Greg Thelen
2011-03-16  0:50       ` Greg Thelen
2011-03-11 18:43 ` [PATCH v6 7/9] memcg: add dirty limiting routines Greg Thelen
2011-03-11 18:43   ` Greg Thelen
2011-03-11 18:43 ` [PATCH v6 8/9] memcg: check memcg dirty limits in page writeback Greg Thelen
2011-03-11 18:43   ` Greg Thelen
2011-03-14 17:54   ` Vivek Goyal
2011-03-14 17:54     ` Vivek Goyal
2011-03-14 17:59     ` Vivek Goyal
2011-03-14 17:59       ` Vivek Goyal
2011-03-14 21:10     ` Jan Kara
2011-03-14 21:10       ` Jan Kara
2011-03-15  3:27       ` Greg Thelen
2011-03-15  3:27         ` Greg Thelen
2011-03-15 23:12         ` Jan Kara
2011-03-15 23:12           ` Jan Kara
2011-03-15 23:12           ` Jan Kara
2011-03-16  2:35           ` Greg Thelen
2011-03-16  2:35             ` Greg Thelen
2011-03-16  2:35             ` Greg Thelen
2011-03-16 12:35             ` Jan Kara
2011-03-16 12:35               ` Jan Kara
2011-03-16 12:35               ` Jan Kara
2011-03-16 18:07               ` Vivek Goyal
2011-03-16 18:07                 ` Vivek Goyal
2011-03-16 18:07                 ` Vivek Goyal
2011-03-15 16:20       ` Vivek Goyal
2011-03-15 16:20         ` Vivek Goyal
2011-03-11 18:43 ` [PATCH v6 9/9] memcg: make background writeback memcg aware Greg Thelen
2011-03-11 18:43   ` Greg Thelen
2011-03-15 22:54   ` Vivek Goyal
2011-03-15 22:54     ` Vivek Goyal
2011-03-16  1:00     ` Greg Thelen
2011-03-16  1:00       ` Greg Thelen
2011-03-12  1:10 ` [PATCH v6 0/9] memcg: per cgroup dirty page accounting Andrew Morton
2011-03-12  1:10   ` Andrew Morton
2011-03-14 18:29   ` Greg Thelen
2011-03-14 18:29     ` Greg Thelen
2011-03-14 20:23     ` Vivek Goyal
2011-03-14 20:23       ` Vivek Goyal
2011-03-15  2:41       ` Greg Thelen
2011-03-15  2:41         ` Greg Thelen
2011-03-15 18:48         ` Vivek Goyal
2011-03-15 18:48           ` Vivek Goyal
2011-03-15 18:48           ` Vivek Goyal
2011-03-16 13:13           ` Johannes Weiner
2011-03-16 13:13             ` Johannes Weiner
2011-03-16 13:13             ` Johannes Weiner
2011-03-16 14:59             ` Vivek Goyal
2011-03-16 14:59               ` Vivek Goyal
2011-03-16 14:59               ` Vivek Goyal
2011-03-16 16:35               ` Johannes Weiner
2011-03-16 16:35                 ` Johannes Weiner
2011-03-16 16:35                 ` Johannes Weiner
2011-03-16 17:06                 ` Vivek Goyal
2011-03-16 17:06                   ` Vivek Goyal
2011-03-16 21:19             ` Greg Thelen
2011-03-16 21:19               ` Greg Thelen
2011-03-16 21:52               ` Johannes Weiner
2011-03-16 21:52                 ` Johannes Weiner
2011-03-16 21:52                 ` Johannes Weiner
2011-03-17  4:41                 ` Greg Thelen
2011-03-17  4:41                   ` Greg Thelen
2011-03-17 12:43                   ` Johannes Weiner
2011-03-17 12:43                     ` Johannes Weiner
2011-03-17 14:49                     ` Vivek Goyal
2011-03-17 14:49                       ` Vivek Goyal
2011-03-17 14:53                     ` Jan Kara
2011-03-17 14:53                       ` Jan Kara
2011-03-17 15:42                       ` Curt Wohlgemuth
2011-03-17 15:42                         ` Curt Wohlgemuth
2011-03-17 15:42                         ` Curt Wohlgemuth
2011-03-18  7:57                     ` Greg Thelen
2011-03-18  7:57                       ` Greg Thelen
2011-03-18 14:50                       ` Vivek Goyal
2011-03-18 14:50                         ` Vivek Goyal
2011-03-23  9:06                       ` KAMEZAWA Hiroyuki
2011-03-23  9:06                         ` KAMEZAWA Hiroyuki
2011-03-23  9:06                         ` KAMEZAWA Hiroyuki
2011-03-18 14:29                     ` Vivek Goyal
2011-03-18 14:29                       ` Vivek Goyal
2011-03-18 14:46                       ` Johannes Weiner
2011-03-18 14:46                         ` Johannes Weiner
2011-03-17 14:46                   ` Jan Kara
2011-03-17 14:46                     ` Jan Kara
2011-03-17 17:12                     ` Vivek Goyal
2011-03-17 17:12                       ` Vivek Goyal
2011-03-17 17:59                       ` Jan Kara
2011-03-17 17:59                         ` Jan Kara
2011-03-17 18:15                         ` Vivek Goyal
2011-03-17 18:15                           ` Vivek Goyal
2011-03-15 21:23         ` Vivek Goyal
2011-03-15 21:23           ` Vivek Goyal
2011-03-15 21:23           ` Vivek Goyal
2011-03-15 23:11           ` Vivek Goyal
2011-03-15 23:11             ` Vivek Goyal
2011-03-15 23:11             ` Vivek Goyal
2011-03-15  1:56     ` KAMEZAWA Hiroyuki
2011-03-15  1:56       ` KAMEZAWA Hiroyuki
2011-03-15  2:51       ` Greg Thelen
2011-03-15  2:51         ` Greg Thelen
2011-03-15  2:54         ` KAMEZAWA Hiroyuki
2011-03-15  2:54           ` KAMEZAWA Hiroyuki
2011-03-16 12:45 ` Johannes Weiner
2011-03-16 12:45   ` Johannes Weiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D7F7121.5040009@librato.com \
    --to=mike@librato.com \
    --cc=akpm@linux-foundation.org \
    --cc=arighi@develer.com \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=ciju@linux.vnet.ibm.com \
    --cc=containers@lists.osdl.org \
    --cc=ctalbott@google.com \
    --cc=fengguang.wu@intel.com \
    --cc=gthelen@google.com \
    --cc=hannes@cmpxchg.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nishimura@mxp.nes.nec.co.jp \
    --cc=rientjes@google.com \
    --cc=teravest@google.com \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.