All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Jes.Sorensen@redhat.com, qemu-devel@nongnu.org, jan.kiszka@siemens.com
Subject: [Qemu-devel] Re: [PATCH 2/7] Introduce -display argument
Date: Tue, 15 Mar 2011 09:53:26 -0500	[thread overview]
Message-ID: <4D7F7D66.8090805@codemonkey.ws> (raw)
In-Reply-To: <AANLkTimr2FdSddsav0t81DLta4XuQUQZprzYLRLWeith@mail.gmail.com>

On 03/15/2011 09:07 AM, Peter Maydell wrote:
> On 15 March 2011 12:36,<Jes.Sorensen@redhat.com>  wrote:
>> From: Jes Sorensen<Jes.Sorensen@redhat.com>
>>
>> This patch introduces a -display argument which consolidates the
>> setting of the display mode. Valid options are:
>> sdl/curses/default/serial (serial is equivalent to -nographic)
> So I still think that we should not be including any new
> -display subargument which mirrors the behaviour of -nographic.
>
> -display represents an opportunity to provide a set of orthogonal
> command line options which affect the handling of particular
> devices; it ought to mean "what happens to VGA/video output?",
> and should not change the behaviour of any other devices.
>
> -nographic is effectively a convenience shortcut which changes
> the behaviour of several different devices (display, serial,
> parallel, at least). It doesn't belong under '-display' from
> an orthogonality argument, and people who want it because it
> is a shortcut will be better served by the existing '-nographic'
> because it's less typing than '-display serial' anyway.

Yeah, I think I agree.  We shouldn't have a -display nographic.

Regards,

Anthony Liguori

> (Ideally we should document '-nographic' by saying that it
> is equivalent to some set of other options including
> -display none -serial stdio and whatever else it does.)
>
> -- PMM

  reply	other threads:[~2011-03-15 14:53 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-15 12:36 [Qemu-devel] [PATCH v2 0/7] Introduce -display and make VNC optional Jes.Sorensen
2011-03-15 12:36 ` [Qemu-devel] [PATCH 1/7] Consolidate DisplaySurface allocation in qemu_alloc_display() Jes.Sorensen
2011-03-15 14:49   ` [Qemu-devel] " Anthony Liguori
2011-03-15 14:53     ` Jes Sorensen
2011-03-15 12:36 ` [Qemu-devel] [PATCH 2/7] Introduce -display argument Jes.Sorensen
2011-03-15 14:07   ` [Qemu-devel] " Peter Maydell
2011-03-15 14:53     ` Anthony Liguori [this message]
2011-03-15 14:55       ` Jes Sorensen
2011-03-15 15:14     ` Alexander Graf
2011-03-15 14:51   ` Anthony Liguori
2011-03-15 14:54     ` Jes Sorensen
2011-03-15 12:36 ` [Qemu-devel] [PATCH 3/7] Introduce -display none Jes.Sorensen
2011-03-15 12:36 ` [Qemu-devel] [PATCH 4/7] Add support for -display vnc Jes.Sorensen
2011-03-15 12:36 ` [Qemu-devel] [PATCH 5/7] error message if user specifies SDL cmd line option when SDL is disabled Jes.Sorensen
2011-03-15 12:36 ` [Qemu-devel] [PATCH 6/7] error message if user specifies curses on cmd line when curses " Jes.Sorensen
2011-03-15 12:36 ` [Qemu-devel] [PATCH 7/7] Make VNC support optional Jes.Sorensen
  -- strict thread matches above, loose matches on Subject: below --
2011-03-16 11:00 [Qemu-devel] [PATCH v4 0/7] Introduce -display and make VNC optional Jes.Sorensen
2011-03-16 11:00 ` [Qemu-devel] [PATCH 2/7] Introduce -display argument Jes.Sorensen
2011-03-16 11:46   ` [Qemu-devel] " Peter Maydell
2011-03-16 12:08     ` Jes Sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D7F7D66.8090805@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=Jes.Sorensen@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.