[Qemu-devel] Re: [PATCH 2/7] Introduce -display argument

[Jes Sorensen <Jes.Sorensen@redhat.com>]

On 03/16/11 12:46, Peter Maydell wrote:
> On 16 March 2011 11:00,  <Jes.Sorensen@redhat.com> wrote:
>> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>>
>> This patch introduces a -display argument which consolidates the
>> setting of the display mode. Valid options are:
>> sdl/curses/default/serial (serial is equivalent to -nographic)
> 
> You forgot to update the commit message when you took out 'serial'...

Good catch, thanks!

>> +Pick the SDL display option.
> 
> How about "Display video output via SDL (usually in a separate graphics
> window; see the SDL documentation for other possibilities)." ?

Looks good to me.

>> +@item curses
>> +Pick the curses display option. Normally, QEMU uses SDL to display the
>> +VGA output.  With this option, QEMU can display the VGA output when in
>> +text mode using a curses/ncurses interface.  Nothing is displayed in
>> +graphical mode.
>> +@end table
>> +ETEXI
> 
> This kind of implies that the only kind of video is VGA, which isn't
> true.
> 
> "Display video output via curses. For graphics device models which
> support a text mode, QEMU can display this output using a curses/ncurses
> interface. Nothing is displayed when the graphics device is in
> graphical mode or if the graphics device does not support a text mode.
> Generally only the VGA device models support text mode."

Ditto

Cheers,
Jes