Re: [Openembedded-users] Problem with patch version 2.6.1-7 and after

Re: [Openembedded-users] Problem with patch version 2.6.1-7 and after

[Terry Barnaby]

On 03/16/2011 08:39 AM, Ludovic Desroches wrote:
> Hello,
> 
> On 3/16/2011 8:22 AM, Terry Barnaby wrote:
>> Hi,
>>
>> I am getting the error:
>>
>> NOTE: Applying patch 'arm-thumb-mutex_db5.patch'
>> (openembedded/recipes/db/db-5.1.19/arm-thumb-mutex_db5.patch)
>> ERROR: Execution of 'quilt
>> --quiltrc=/scratch/OpenEmbeddedNew/tmp/sysroots/i686-linux/usr/bin/quiltrc
>> push' failed with exit code 1:
>> Applying patch arm-thumb-mutex_db5.patch
>> patch: **** rejecting target file name with ".." component:
>> ../src/dbinc/mutex_int.h
>> Patch arm-thumb-mutex_db5.patch does not apply (enforce with -f)
>>
>> ERROR: Function 'patch_do_patch' failed
> 
> I have no problem to apply the patch manually or running bitbake db-5.1.19. I am
> using the latest bitbake release and the 2011.03 oe release.
> 
>>
>> This appears to be due to a security enhancement made to the patch utility
>> relatively recently. 
> I have updated my patch utility we the latest release, not version on the alpha
> ftp :
> 
> $ bitbake db-5.1.19
> ...
> Build Configuration:
> BB_VERSION        = "1.12.0"
> METADATA_BRANCH   = "2011.03_atmel"
> METADATA_REVISION = "8c6a371"
> TARGET_ARCH       = "arm"
> TARGET_OS         = "linux-gnueabi"
> MACHINE           = "at91sam9m10g45"
> DISTRO            = "angstrom"
> DISTRO_VERSION    = "v20110316"
> TARGET_FPU        = "soft"
> 
> NOTE: Resolving any missing task queue dependencies
> NOTE: Preparing runqueue
> NOTE: Executing RunQueue Tasks
> ...
> NOTE: package db-5.1.19-r1: task do_patch: Started
> NOTE: package db-5.1.19-r1: task do_patch: Succeeded
> NOTE: Running task 721 of 732 (ID: 11,
> /local/users/ldesroch/workspace/openembedded/openembedded/recipes/db/db_5.1.19.bb,
> do_configure)
> ...
> 
> ldesroch@RFOLXTS02:openembedded (master)$ patch --version
> patch 2.6.1
> 
>> Is there a known clean way of fixing this and where
>> should I report the bug ?
>>
> You should use the openembedded-devel list. I think you will have more answers.
> 
> 
> Regards
> 
> Ludovic Desroches
> 
> 
> 
> _______________________________________________
> Openembedded-users mailing list
> Openembedded-users@linuxtogo.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-users
Hi,

### Forwarded to openembedded-devel ###

We are using Fedora14. That is using patch 2.6.1-8.

The -8 release includes the following patches to patch.
Patch1: patch-2.5.4-sigsegv.patch
Patch2: patch-get-arg.patch
Patch3: patch-CVE-2010-4651.patch
Patch100: patch-selinux.patch

I think one of those fixes a security issue in patch where ".." in
path names were allowed. With this version of patch (which I assume
will become standard ?) the OpenEmbedded fails.
Any ideas on a way to get around this (ideally without using a
different patch version :) )

Cheers


Terry

Re: [Openembedded-users] Problem with patch version 2.6.1-7 and after

[Tom Rini]

On 03/16/2011 07:03 AM, Terry Barnaby wrote:

[snip]
> Hi,
>
> ### Forwarded to openembedded-devel ###
>
> We are using Fedora14. That is using patch 2.6.1-8.
>
> The -8 release includes the following patches to patch.
> Patch1: patch-2.5.4-sigsegv.patch
> Patch2: patch-get-arg.patch
> Patch3: patch-CVE-2010-4651.patch
> Patch100: patch-selinux.patch
>
> I think one of those fixes a security issue in patch where ".." in
> path names were allowed. With this version of patch (which I assume
> will become standard ?) the OpenEmbedded fails.
> Any ideas on a way to get around this (ideally without using a
> different patch version :) )

So, there's a lot of recipes with patches with .. in the path:
openembedded$ git grep -lE "^---.*[^.]\.\.\/" recipes/ | wc -l
80

Some of these will be easy fixups (first one I peeked at we can just 
change the patch and not have to modify the recipe) but others like the 
tcl one will require a little thought.

-- 
Tom Rini
Mentor Graphics Corporation

Re: [Openembedded-users] Problem with patch version 2.6.1-7 and after

[Tom Rini]

On 03/16/2011 10:08 AM, Tom Rini wrote:
> On 03/16/2011 07:03 AM, Terry Barnaby wrote:
>
> [snip]
>> Hi,
>>
>> ### Forwarded to openembedded-devel ###
>>
>> We are using Fedora14. That is using patch 2.6.1-8.
>>
>> The -8 release includes the following patches to patch.
>> Patch1: patch-2.5.4-sigsegv.patch
>> Patch2: patch-get-arg.patch
>> Patch3: patch-CVE-2010-4651.patch
>> Patch100: patch-selinux.patch
>>
>> I think one of those fixes a security issue in patch where ".." in
>> path names were allowed. With this version of patch (which I assume
>> will become standard ?) the OpenEmbedded fails.
>> Any ideas on a way to get around this (ideally without using a
>> different patch version :) )
>
> So, there's a lot of recipes with patches with .. in the path:
> openembedded$ git grep -lE "^---.*[^.]\.\.\/" recipes/ | wc -l
> 80
>
> Some of these will be easy fixups (first one I peeked at we can just
> change the patch and not have to modify the recipe) but others like the
> tcl one will require a little thought.

Everything should be happy now.

-- 
Tom Rini
Mentor Graphics Corporation

Re: [Openembedded-users] Problem with patch version 2.6.1-7 and after

[Terry Barnaby]

On 03/16/2011 07:57 PM, Tom Rini wrote:
> On 03/16/2011 10:08 AM, Tom Rini wrote:
>> On 03/16/2011 07:03 AM, Terry Barnaby wrote:
>>
>> [snip]
>>> Hi,
>>>
>>> ### Forwarded to openembedded-devel ###
>>>
>>> We are using Fedora14. That is using patch 2.6.1-8.
>>>
>>> The -8 release includes the following patches to patch.
>>> Patch1: patch-2.5.4-sigsegv.patch
>>> Patch2: patch-get-arg.patch
>>> Patch3: patch-CVE-2010-4651.patch
>>> Patch100: patch-selinux.patch
>>>
>>> I think one of those fixes a security issue in patch where ".." in
>>> path names were allowed. With this version of patch (which I assume
>>> will become standard ?) the OpenEmbedded fails.
>>> Any ideas on a way to get around this (ideally without using a
>>> different patch version :) )
>>
>> So, there's a lot of recipes with patches with .. in the path:
>> openembedded$ git grep -lE "^---.*[^.]\.\.\/" recipes/ | wc -l
>> 80
>>
>> Some of these will be easy fixups (first one I peeked at we can just
>> change the patch and not have to modify the recipe) but others like the
>> tcl one will require a little thought.
> 
> Everything should be happy now.
> 
Indeed it is :)
Thanks very much, I wasn't expecting changes that quick !

Cheers


Terry