All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yannick Heneault <yannick_heneault@matrox.com>
To: Gary Hade <garyhade@us.ibm.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	djwong@us.ibm.com, Linus Torvalds <torvalds@linux-foundation.org>,
	linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Krzysztof Helt <krzysztof.h1@wp.pl>,
	Petr Vandrovec <vandrove@vc.cvut.cz>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] matroxfb: remove incorrect Matrox G200eV support
Date: Wed, 16 Mar 2011 19:58:09 +0000	[thread overview]
Message-ID: <4D811651.6020607@matrox.com> (raw)
In-Reply-To: <20110311222337.GC7614@us.ibm.com>

It impossible that this patch should have work on a system. The patch 
only declare the G200eV as a regular G200 which is not case. Many 
registers are different, including at least the PLL programming 
sequence. If the G200eV is programmed like a regular G200, it will not 
display anything.

Yannick

On 03/11/2011 05:23 PM, Gary Hade wrote:
> On Mon, Mar 07, 2011 at 07:59:16PM +1100, Benjamin Herrenschmidt wrote:
>    
>> On Fri, 2011-03-04 at 12:29 -0800, Darrick J. Wong wrote:
>>      
>>> This is all quite strange -- 2.5 years ago when I wrote the patch it
>>> seemed to
>>> work ok.  On newer revisions of the x3650M2 it seems broken.  The
>>> original
>>> machine I wrote it for was cut up ages ago.
>>>
>>> I suppose we could simply blacklist any G200eV with a subsystem vendor
>>> ID of
>>> 0x1014 (IBM) until we figure out how to correct the driver.  Our
>>> customers will
>>> be deprived, but as it seems to be broken across most of our product
>>> lines I
>>> doubt any of them are making serious use of it anyway. :)
>>>
>>> Something like this?
>>>        
>> Does X work with the open source drivers ?
>>      
> Yes, X works fine on at least the IBM System x boxes that have
> the Matrox G200eV.
>
>    
>> In that case a better
>> approach would be to try to figure out what's different between the way
>> the 2 drivers setup the card registers and fix matroxfb..
>>      
> I suppose someone could attempt this but with vesafb available as
> an alternate fb provider and no known demand for repaired G200eV
> support in matroxfb, I am not sure what benefit it would provide.
>
> Gary
>
>
>    


WARNING: multiple messages have this Message-ID (diff)
From: Yannick Heneault <yannick_heneault@matrox.com>
To: Gary Hade <garyhade@us.ibm.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	djwong@us.ibm.com, Linus Torvalds <torvalds@linux-foundation.org>,
	linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Krzysztof Helt <krzysztof.h1@wp.pl>,
	Petr Vandrovec <vandrove@vc.cvut.cz>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] matroxfb: remove incorrect Matrox G200eV support
Date: Wed, 16 Mar 2011 15:58:09 -0400	[thread overview]
Message-ID: <4D811651.6020607@matrox.com> (raw)
In-Reply-To: <20110311222337.GC7614@us.ibm.com>

It impossible that this patch should have work on a system. The patch 
only declare the G200eV as a regular G200 which is not case. Many 
registers are different, including at least the PLL programming 
sequence. If the G200eV is programmed like a regular G200, it will not 
display anything.

Yannick

On 03/11/2011 05:23 PM, Gary Hade wrote:
> On Mon, Mar 07, 2011 at 07:59:16PM +1100, Benjamin Herrenschmidt wrote:
>    
>> On Fri, 2011-03-04 at 12:29 -0800, Darrick J. Wong wrote:
>>      
>>> This is all quite strange -- 2.5 years ago when I wrote the patch it
>>> seemed to
>>> work ok.  On newer revisions of the x3650M2 it seems broken.  The
>>> original
>>> machine I wrote it for was cut up ages ago.
>>>
>>> I suppose we could simply blacklist any G200eV with a subsystem vendor
>>> ID of
>>> 0x1014 (IBM) until we figure out how to correct the driver.  Our
>>> customers will
>>> be deprived, but as it seems to be broken across most of our product
>>> lines I
>>> doubt any of them are making serious use of it anyway. :)
>>>
>>> Something like this?
>>>        
>> Does X work with the open source drivers ?
>>      
> Yes, X works fine on at least the IBM System x boxes that have
> the Matrox G200eV.
>
>    
>> In that case a better
>> approach would be to try to figure out what's different between the way
>> the 2 drivers setup the card registers and fix matroxfb..
>>      
> I suppose someone could attempt this but with vesafb available as
> an alternate fb provider and no known demand for repaired G200eV
> support in matroxfb, I am not sure what benefit it would provide.
>
> Gary
>
>
>    


  reply	other threads:[~2011-03-16 19:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-01 17:50 matroxfb: remove incorrect Matrox G200eV support Gary Hade
2011-03-01 17:50 ` Gary Hade
2011-03-01 18:29 ` Linus Torvalds
2011-03-01 18:29   ` Linus Torvalds
2011-03-04 20:29   ` [PATCH v2] " Darrick J. Wong
2011-03-04 20:29     ` Darrick J. Wong
2011-03-07  8:59     ` Benjamin Herrenschmidt
2011-03-07  8:59       ` Benjamin Herrenschmidt
2011-03-11 22:23       ` Gary Hade
2011-03-11 22:23         ` Gary Hade
2011-03-16 19:58         ` Yannick Heneault [this message]
2011-03-16 19:58           ` Yannick Heneault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D811651.6020607@matrox.com \
    --to=yannick_heneault@matrox.com \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=djwong@us.ibm.com \
    --cc=garyhade@us.ibm.com \
    --cc=krzysztof.h1@wp.pl \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=vandrove@vc.cvut.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.