All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] CBMs are always fixed size, so improve PDU length check
@ 2011-03-16  9:12 Bertrand Aygon
  2011-03-17  2:30 ` Denis Kenzior
  0 siblings, 1 reply; 2+ messages in thread
From: Bertrand Aygon @ 2011-03-16  9:12 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 1168 bytes --]

---
 drivers/atmodem/cbs.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/atmodem/cbs.c b/drivers/atmodem/cbs.c
index 8cc3ef0..e2e1ca4 100644
--- a/drivers/atmodem/cbs.c
+++ b/drivers/atmodem/cbs.c
@@ -68,8 +68,8 @@ static void at_cbm_notify(GAtResult *result, gpointer user_data)
 	if (!g_at_result_iter_next_number(&iter, &pdulen))
 		return;
 
-	if (pdulen > 88) {
-		ofono_error("Got a CBM message bigger than maximum size!");
+	if (pdulen != 88) {
+		ofono_error("Got a CBM message with invalid PDU size!");
 		return;
 	}
 
-- 
1.7.1

---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris, 
92196 Meudon Cedex, France
Registration Number:  302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] CBMs are always fixed size, so improve PDU length check
  2011-03-16  9:12 [PATCH] CBMs are always fixed size, so improve PDU length check Bertrand Aygon
@ 2011-03-17  2:30 ` Denis Kenzior
  0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2011-03-17  2:30 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

Hi Bertrand,

On 03/16/2011 04:12 AM, Bertrand Aygon wrote:
> ---
>  drivers/atmodem/cbs.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 

Patch has been applied, thanks.

Regards,
-Denis

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-03-17  2:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-16  9:12 [PATCH] CBMs are always fixed size, so improve PDU length check Bertrand Aygon
2011-03-17  2:30 ` Denis Kenzior

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.